[HOLD for payment 2024-01-03] [$125] Split Bill - Merchant must have the same value after creating the split bill

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.84.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697047715565069

Action Performed:

1. Click FAB button
2. Click request money
3. Enter amount => Next
4. Click split 2 users
5. Click add to split
6. Click show more => Merchant, Observe that the default value is "Request"
7. Click split
8. Click Split preview
9. Click show more, in merchant, Observe "Split with...."

Expected Result:

Merchant must have the same value after creating the split bill

Actual Result:

There is a difference between the merchant after splitting the bill, when they create the merchant the value is "Request" but when the slit bill is created the merchant has the value "Split with...."

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-12.at.16.01.35.1.mov

Android: mWeb Chrome

Screen.Recording.2023-10-12.at.15.47.34.1.mov

iOS: Native

RPReplay_Final1697100622.MP4

iOS: mWeb Safari

RPReplay_Final1697100658.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-12.at.01.09.35.mov

Recording.5015.mp4

MacOS: Desktop

Screen.Recording.2023-10-12.at.15.49.12.mov

View all open jobs on GitHub

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[sicarius97]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Instead of taking in the user input in the merchant field (by default "Request") in the split bill screen, it automatically defaults to "Split with [participants]".

What is the root cause of that problem?

The cause of this issue is that in this code the merchant is automatically formatted on splits to the above mentioned:

App/src/libs/actions/IOU.js

Lines 914 to 927 in a456ef9

	const splitTransaction = TransactionUtils.buildOptimisticTransaction(
	amount,
	currency,
	CONST.REPORT.SPLIT_REPORTID,
	comment,
	'',
	'',
	'',
	`${Localize.translateLocal('iou.splitBill')} ${Localize.translateLocal('common.with')} ${formattedParticipants} [${DateUtils.getDBTime().slice(0, 10)}]`,
	undefined,
	undefined,
	undefined,
	category,
	);

What changes do you think we should make in order to solve the problem?

Instead of automatically formatting it to the "Split with [participants]" by default like it is currently, line 922 above should instead take in the submitted user input when building the transaction so that it reflects that value on submission like it does for the other fields. Specifically, that line and one other just need to be changed to the input prop var merchant .

[trjExpensify]

Oh interesting, I think @youssef-lr should have solved this.

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

[trjExpensify]

Summin' up with Upwork to create this job. Sigh..

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

[youssef-lr]

Sorry @sicarius97 this needs to be internal as we also hardcode that merchant in the backend, so even if you send the merchant from the frontend it won't be used.

[sicarius97]

@youssef-lr Gotcha, no worries. I saw it looked like you had merged some updates for the one on one splits that seemed to be the correct requested format as well

[sicarius97]

If there is any part of that or the TS transition I can contribute to, let me know!

[youssef-lr]

@trjExpensify I missed a Web-E PR that I have locally that's needed, as well as an App PR, will work on these now and request a review shortly.

[melvin-bot]

This issue has not been updated in over 15 days. @youssef-lr, @trjExpensify, @aimane-chnaif eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[aimane-chnaif]

@youssef-lr is OOO until this week

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.17-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Allow setting merchant for split bill #30721

If no regressions arise, payment will be issued on 2024-01-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment (Needs manual offer from BZ)
• @namhihi237 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 @aimane-chnaif checklist time, please!

[aimane-chnaif]

Not able to find offending PR. There were back and forth changes related to merchant field.

Regression Test Proposal

1. Create a manual split with contacts and make sure you set a merchant and a description
2. Verify that split preview shows the merchant but not the description
3. Create another split by supplying only the description, not merchant
4. Verify that the description is shown in the preview
5. Click on split preview detail
6. Verify that merchant is not set

[aimane-chnaif]

Payment will be handled in #29732

[trjExpensify]

Nice, so similarly I think the regression test will get added holistically with the project. So we can close this now.

[namhihi237]

@trjExpensify i think i can receive bonus as a reporter

[trjExpensify]

Yup, Oct 24th the program change went into effect, so I've sent you an offer of $50 for the bug report.