[$500] Details - Wrong text in tooltip on 3 dots of owes report details

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.84.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697471268360179

Action Performed:

1. Open the app
2. Open owes report or send request money request to any user and click IOU message once
3. Click in header to open details
4. Observe that we display participants as title in details
5. Hover on 3 dots in the report and observe that it displays report title text instead of displaying user list

Expected Result:

Hover on 3 dots in owes report details should display user list as tooltip text

Actual Result:

Hover on 3 dots in owes report details shows report title text

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

mac.chrome.owes.3.dot.display.wrong.name.mov

Recording.5018.mp4

MacOS: Desktop

mac.desktop.wrong.name.owes.2.dot.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011c5b71f132322fe9
• Upwork Job ID: 1713984868090105856
• Last Price Increase: 2023-10-16

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011c5b71f132322fe9

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

3 dots shows the report title instead of display name list in report detail page

What is the root cause of that problem?

We're showing the full title in the tooltip as you can see below

App/src/components/DisplayNames/DisplayNamesWithTooltip.js

Line 73 in 2fb47ac

<Tooltip text={props.fullTitle}>

This is the root cause

What changes do you think we should make in order to solve the problem?

We need to show display names when we don't show title
Update the above line to

        <Tooltip text={props.shouldUseFullTitle ? props.fullTitle : _.map(props.displayNamesWithTooltips, ({displayName}) => displayName).join(', ')}>

This works as expected

Result

29703.mp4

What alternative solutions did you explore? (Optional)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

wrong tool tip display in the report details page

What is the root cause of that problem?

we display the report name instead of the participants list in the fullTitle prop

App/src/pages/ReportDetailsPage.js

Lines 165 to 172 in 7393ec5

	<DisplayNames
	fullTitle={ReportUtils.getReportName(props.report)}
	displayNamesWithTooltips={displayNamesWithTooltips}
	tooltipEnabled
	numberOfLines={isChatRoom && !isThread ? 0 : 1}
	textStyles={[styles.textHeadline, styles.textAlignCenter, isChatRoom && !isThread ? undefined : styles.pre]}
	shouldUseFullTitle={shouldUseFullTitle}
	/>

What changes do you think we should make in order to solve the problem?

use participants names instead of the report name.. to do that we can use the displayNamesWithTooltips arr and access the displayname and join it by ","

    const participantsNames = useMemo(() => _.map(displayNamesWithTooltips, (participantDisplay) => participantDisplay.displayName).join(', '), [displayNamesWithTooltips]);

     <DisplayNames
                                    fullTitle={participantsNames}
                                    displayNamesWithTooltips={displayNamesWithTooltips}
                                    tooltipEnabled
                                    numberOfLine
                                    s={isChatRoom && !isThread ? 0 : 1}
                                    textStyles={[styles.textHeadline, styles.textAlignCenter, isChatRoom && !isThread ? undefined : styles.pre]}
                                    shouldUseFullTitle={shouldUseFullTitle}
                                />

POC

[bernhardoj]

The IOU report details title now show the report name after this PR

[jliexpensify]

Thanks @bernhardoj - closing this!