[WAITING ON CHECKLIST] [$1000] Web - missing translations on additional details page in wallet enablement flow

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.84.9
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697480656854849

Action Performed:

1. User A: login, navigate to Settings > Wallet
2. User A: add personal bank account
3. User B: login, select Request money
4. User B: enter User A as the person you're requesting from
5. User A: Navigate to IOU from User B
6. User A: select Pay with Expensify

Expected Result:

There should be translations for every field.

• Zip code: código postal
• Personal address: Dirección personal

Actual Result:

Personal address and zip code both show "MISSING TRANSLATION" on expensify.com emails, to call out that we are missing a translation (#27759 for more details)

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01df8c2e9cdd1c685b
• Upwork Job ID: 1714058361895460864
• Last Price Increase: 2024-01-23
• Automatic offers:
• 0xmiroslav | Reviewer | 27267086
• tienifr | Contributor | 27267089
• situchan | Contributor | 28118287

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ishpaul777]

Proposal

Problem

"MISSING TRANSLATION" shown in the wallet upgrade flow

Root Cause

We are traslating the error message 2 times first when we are setting the error message here and second when we are displaying the error message here.
So for the second time we are getting "Missing Translation" instead of error message as the phrase key (actual error message) is not present in the translation file. This was not noticable before #27759 as we were just returning the phrase key when translation is not present. But after #27759 we are returning "Missing Translation" when translation is not present to accounts logged in with Expensify email address.

This issue is only reproducable for accounts with expensify email, was earlier reported here - https://expensify.slack.com/archives/C049HHMV9SM/p1696940644742429

cc - @mountiny

Changes Suggested

We should not translate the errorText in TextInput and send the translation key only. We should identify and fix all other FormHelpMessage and TextInputs, where we are passing the translated text instead of keys.

[kevinksullivan]

looking for translation

https://expensify.slack.com/archives/C21FRDWCV/p1697498156628909

[kevinksullivan]

Updated the OP. the problem is that we are missing translations, and not that MISSING TRANSLATION is shown on expensify accounts.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01df8c2e9cdd1c685b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[mountiny]

@kevinksullivan as @ishpaul777 mentioned, the problem is that we provide already translated text to the translate method again, we should make sure we are not passing this through the translation twice

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Personal address and zip code both show "MISSING TRANSLATION" on expensify.com emails, to call out that we are missing a translation (#27759 for more details)

What is the root cause of that problem?

The errorText of TextInput is supposed to accept:

1. Translation key, which internally TextInput will translate here
2. Translated message/server error message: In this case we should pass the isTranslated: true so TextInput won't attempt to translate it again thanks to this logic

But in here, we're passing translated message to errorText, without the isTranslated: true

So inside TextInput it will try to translate it again, which results in the MISSING TRANSLATION because it cannot find any key matching that translated message.

What changes do you think we should make in order to solve the problem?

We need to fix properly for 2 types of errors:

1. For server error message like in ErrorUtils.getLatestErrorMessage here, which is not a translation key, and we cannot predict what error message will be returned so we need to show it as is. For this case we should pass isTranslated: true to make sure it doesn't show MISSING TRANSLATION
2. For translatable message like in here, we can either remove the props.translate and pass the translation key only, or we can pass isTranslated: true as well (only if there's any reason we need to translate outside of the TextInput component.

We need to find all occurrences of the above 2 cases in the codebase and fix as below

What alternative solutions did you explore? (Optional)

NA

[0xmiros]

We need to find all occurrences of the above 2 cases in the codebase and fix as below

@tienifr can you find all occurrences where this issue happens?

[mountiny]

@tienifr @0xmiroslav This has popped up in couple of flows in the app, for example here too #28907 Could we please fix all these occurences here and try to fix this as generically as possible for Form component? thanks!

[tienifr]

@tienifr can you find all occurrences where this issue happens?

@0xmiroslav Here're the places:

• All 4 errorText= in src/pages/ReimbursementAccount/AddressForm.js
• All 4 errorText= in src/pages/ReimbursementAccount/IdentityForm.js
• errorText in src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js
• errorText in src/pages/settings/Security/TwoFactorAuth/TwoFactorAuthForm/BaseTwoFactorAuthForm.js
• errorText in src/pages/settings/Wallet/ActivatePhysicalCardPage.js
• errorText in src/pages/signin/LoginForm/BaseLoginForm.js
• errorText in src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

And a few other places. We need to double check pretty much every place where we use errorText in the app, we can do that as part of the PR process.

[0xmiros]

@tienifr's proposal looks good to me.
🎀 👀 🎀 C+ reviewed

And a few other places. We need to double check pretty much every place where we use errorText in the app

Please start on it to save time

[melvin-bot]

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @0xmiroslav 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[marcaaron]

honestly i don't understand how this is a new issue and not a regression caused by that PR but 🤷‍♂️

[mountiny]

@marcaaron I can take it over if you prefer.

I dont think its a regression because that PR just surfaced this bad practice which should be fixed imho.

[marcaaron]

It looks like a bug. I thought all the server errors show MISSING TRANSLATION? Why do we want this? 😂

[melvin-bot]

@jliexpensify, @marcaaron, @situchan, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jliexpensify]

Not overdue, @tienifr is working on the PR

[situchan]

Not overdue

[mallenexpensify]

PR was merged yesterday!!!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Missing translation for server errors #30073

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

• @situchan requires payment automatic offer (Contributor)
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Bump @situchan to complete the checklist please

EDIT: Looks like the Upworks job is closed so I will make another one today

[jliexpensify]

I made a new job + here is a payment summary:

• Contributor: @tienifr $1000
• C+: @situchan $1000

Upworks job

[tienifr]

@jliexpensify I've accepted the job offer, thanks 🙏

[situchan]

I already have offer accepted here

This doesn't require BZ checklist as no way to reproduce on non-Expensify accounts.

[jliexpensify]

@situchan I'm aware that you've accepted the offer, but that was for the old posting and it's now been closed by Upworks:

I don't have a way to pay you on that job, so I created a new, active job.

[situchan]

ok no problem. Accepted new offer

[jliexpensify]

Paid and job closed. Waiting on @situchan to complete checklist

[situchan]

@jliexpensify here's my feedback on checklist - #29712 (comment)

[jliexpensify]

Cool, thanks! Closing!