Deploy Checklist: New Expensify 2023-10-16

[OSBotify]

Release Version: 1.3.85-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Refactor DatePicker component for ios #24528
• Improve Google Sign In error logging #25446
• feat(Wallet): add empty state and redesign wallet page #26406
• Feature/add assigned card tile and display expensify cards #26862
• Show eReceipts for distance requests #27204
• refactor: transformed class component to the functional #27424
• Upgrade react-native-sdk to v8.3.0 #27432
• chore: migrate withViewportOffsetTop.js class to function component #27492
• [No QA] [TS migration] Review and clean up Styles files #27660
• [No QA][TS migration] Migrate 'Timing.js' lib to TypeScript #27705
• Update react-native-vision-camera #27820
• [No QA] [TS migration] Migrate 'localFileDownload' lib to TypeScript  #27857
• [No QA] [TS migration] Migrate 'Pusher' lib to TypeScript #28116
• Hide three dot in header when request is deleted #28214
• [No QA] [TS migration] Migrate 'Performance.js' lib to TypeScript #28271
• Android - Deeplink navigation does not work for RHN links. #28278
• Trim the value when going back on connect bank account #28305
• [TS migration] Migrate 'BankAccounts.js' lib to TypeScript #28316
• [SAML NewDot] Add SAML flow for web, mweb, desktop #28372
• Fix splash screen logo size jump on Samsung OneUI v4 #28644
• Create removing-users.md #28732
• Improve new form validation #28821
• Fix/28324 : App keeps both right click LHN popup and delete message popup open together #28846
• Bump Onyx to 1.0.100 #28894
• Make Bun compatible #28900
• Fix: Footer for anonymous user sign in modal distorted #28904
• fix: show large suggestion menu only if there is space #28927
• Create Set-Up-the-Card-for-Your-Company.md #28990
• Update and rename Report-Comments.md to Report-Audit-Log-and-Comments.md #28994
• [No QA]Update Add-a-Business-Bank-Account-(AUD).md #29026
• Implement a bash script needed to configure simulators for App development #29061
• Rename Send message to Start chat #29065
• Add files via upload - Company Cards Direct Connection Images #29071
• added composer focus glitch fix #29073
• Add pin icon in the IOU report page of request amount #29078
• Add DateTimeFormat polyfill #29113
• fix: default merchant for money request with receipt #29118
• ignore concierge report id during deep link launch #29122
• feat: enable next button #29125
• fix chat-link in end of line displays tooltip over text and not on link #29134
• Add 2x files via upload #29139
• fix check of available dates of next month #29143
• [Wave 8 - ECard Transactions] Update Money Request View Fields to support Ecard transactions #29201
• fix: 22850 task title is not focused after refresh #29203
• fix: 25779 Accessing an attachment via link that is not found shows the error page twice #29206
• Create Hosting repository for help.expensify.com support files #29242
• Fix report screen scrollbar on Android is on the left screen #29253
• Fix: App focuses back on composer even if RHN is open on copy link from app download link in about settings #29254
• [#16935] Workspace creation with Policy Draft info #29256
• [No QA] [TS migration] Migrate 'useDragAndDrop.js' hook to TypeScript #29257
• fix blinking loader in connect bank account page #29260
• fix: Use localized message for split requests in LHN #29263
• fix MapView.tsx cleanup when blur #29270
• prevent optimisticID creation for a user already existing in personal details #29279
• [Wave 8 - ECard Transactions] Show %Name Spent:% on ReportPreview  #29287
• [Money2020] Adding in activation flow for money20/20 #29288
• [Wave 8- ECard Transactions] Show [Reversed transaction] for deleted transactions #29310
• Feat: add jsDoc to billable #29327
• fix: 28841 keyboard opens for a second when user switches to password protected PDF #29331
• optionslist-to-selectionslist #29337
• Fix app crash when visiting bank account page #29339
• [NoQA] Revert "Testing deploy changes" #29355
• User current location button onClick fix #29366
• Changed inconmark color for adhoc build loading screen #29383
• Rename Xero to Xero.md #29385
• Update Third-Party-Payments.md #29396
• fix: close not-found page when dismissing modal #29404
• Fix Error message displays briefly after reopening the 2FA step 2 page #29406
• update notification count #29409
• [CP Staging] Fix crash on task settings #29412
• Workspace admin checkbox #29422
• fix: reduce rerendering of EmojiPickerMenu when hovering #29423
• update text and alternateText in getPolicyExpenseReportOption function #29424
• [Wave 8- ECard Transactions] Update ReportPreview styling (ReportActionItemImages) #29431
• [NoQA] Change variant to mode in run-android command in package.json #29440
• [CP Staging] Fix regression -- empty search box not displaying suggestions #29445
• [CP Staging] Fix: Workspace money request preview containing a receipt is misaligned #29447
• fix: Cursor freeze on paste emoji in edit message #29448
• fix style console error on open avatar #29461
• [NoQA] Temporarily update the getPreviousVeriosn to skip over missing tag #29465
• fix: set default textBreakStrategy for TextInput as simple #29467
• Use getBoundingClientRect as a fallback #29468
• Update Annual-Subscription.md #29472
• [CP Staging] Hide merchant and date field for split bill with scan #29473
• fix: No margin top on zip code input #29480
• Update Pay-Per-Use-Subscription.md #29482
• [CP Staging] Fix: Send money - Avatars and names overlap in Send money report details page #29483
• [No QA] Actions can have childReportName #29486
• Update and rename Mileage.md to distance-tracking.md #29489
• [CP Staging] Fix missing isOwnPolicyExpenseChat #29507
• Create Additional-Travel-Integrations.md #29520
• [CP Staging] fixes: invalid file modal and delete option shown for setted IOU #29524
• [CP Staging] Fix crash on navigation aware camera #29525
• Fix wrong onyx config in ReportFooter #29529
• fix: Emojis, emoji picker icon, and edit icon are disappeared when hovering over notification from completed task #29530
• Allow Welcome Message on Room Creation #29541
• fix: 29543 Dot separator in the report preview component appears bottom aligned  #29544
• [NoQA] refactor(28585): perf test for GooglePlacesUtils.getAddressComponents #29545
• Only show Split Bill option in the user's own workspace chat #29551
• [NoQA] Updated podfile #29562
• Cleanup completing a split bill #29568
• [CP Staging] [NoQA] Switch to the production teachers unite policy #29572
• update: expensify-common #29575
• Page is skewed when dragging Scan content to the right #29578
• [No QA]Comment out bot messages since e2e are too flaky #29579
• Update Sage-Intacct.md #29588
• fix: 404 authenticate pusher api call #29590
• [No QA]Add a check for the new OS Botify App in the deploy process #29592
• fix click room avatar footer #29599
• Fix duplicate offline indicator enable payment  #29600
• remove console error #29603
• add bottom safe area padding on the EditRequestReceiptPage. #29617
• fix hovering header menu #29662
• Update Expense-Rules.md #29671
• [CP Staging] fix/regression LHN-App crashes on long pressing any report in the LHN #29752
• [CP Staging] Fix CreateChatReport is still called when visiting /money2020 for the second time #29792
• Fix disappearing finish waypoint when start waypoint is selected #29811
• [CP Staging] Fix signin in via Abracadabra tab #29831

Internal QA:

• feat 22876 allow users to update the card address via update address link #28907 - @MrMuzyk
• Minimal server search / enable improved focus mode #27819 - @marcaaron

Deploy Blockers:

• [HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] [$500] LHN-App crashes on long pressing any report in the LHN #29746
• [HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] [$500] Web - Chat - CreateChatReport is called (API call) even though chat is already created #29747
• [HOLD for payment 2023-10-25] [$500] IOU-In distance request, after selecting start waypoint finish section disappears #29748
• Adding Stop first in distance request leads to remove finsh point and other data #29773
• [HOLD for payment 2023-12-08] [$1000] IOU - Tapping download on manual money request receipt app crashes #29788
• [HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab #29807
• Log in - There is no error message when trying to log in into an account with SAML required #29819

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.85-0 🚀

[francoisl]

Heads up, it looks like there are PRs that were already tested in the last checklist. I'll go through the list and mark off the dupes.

Here are the dupes I'm checking:

https://github.com/Expensify/App/pull/25446
https://github.com/Expensify/App/pull/26406
https://github.com/Expensify/App/pull/27204
https://github.com/Expensify/App/pull/27424
https://github.com/Expensify/App/pull/27432
https://github.com/Expensify/App/pull/27492
https://github.com/Expensify/App/pull/27660
https://github.com/Expensify/App/pull/27820
https://github.com/Expensify/App/pull/28116
https://github.com/Expensify/App/pull/28214
https://github.com/Expensify/App/pull/28278
https://github.com/Expensify/App/pull/28305
https://github.com/Expensify/App/pull/28732
https://github.com/Expensify/App/pull/28821
https://github.com/Expensify/App/pull/28904
https://github.com/Expensify/App/pull/28927
https://github.com/Expensify/App/pull/28994
https://github.com/Expensify/App/pull/29026
https://github.com/Expensify/App/pull/29061
https://github.com/Expensify/App/pull/29071
https://github.com/Expensify/App/pull/29073
https://github.com/Expensify/App/pull/29078
https://github.com/Expensify/App/pull/29113
https://github.com/Expensify/App/pull/29118
https://github.com/Expensify/App/pull/29122
https://github.com/Expensify/App/pull/29125
https://github.com/Expensify/App/pull/29134
https://github.com/Expensify/App/pull/29139
https://github.com/Expensify/App/pull/29143
https://github.com/Expensify/App/pull/29201
https://github.com/Expensify/App/pull/29203
https://github.com/Expensify/App/pull/29206
https://github.com/Expensify/App/pull/29253
https://github.com/Expensify/App/pull/29254
https://github.com/Expensify/App/pull/29257
https://github.com/Expensify/App/pull/29260
https://github.com/Expensify/App/pull/29263
https://github.com/Expensify/App/pull/29270
https://github.com/Expensify/App/pull/29287
https://github.com/Expensify/App/pull/29310
https://github.com/Expensify/App/pull/29327
https://github.com/Expensify/App/pull/29339
https://github.com/Expensify/App/pull/29355
https://github.com/Expensify/App/pull/29366
https://github.com/Expensify/App/pull/29383
https://github.com/Expensify/App/pull/29404
https://github.com/Expensify/App/pull/29406
https://github.com/Expensify/App/pull/29409
https://github.com/Expensify/App/pull/29424
https://github.com/Expensify/App/pull/29431
https://github.com/Expensify/App/pull/29440
https://github.com/Expensify/App/pull/29461
https://github.com/Expensify/App/pull/29465
https://github.com/Expensify/App/pull/29467
https://github.com/Expensify/App/pull/29468
https://github.com/Expensify/App/pull/29472
https://github.com/Expensify/App/pull/29480
https://github.com/Expensify/App/pull/29486
https://github.com/Expensify/App/pull/29489
https://github.com/Expensify/App/pull/29520
https://github.com/Expensify/App/pull/29529
https://github.com/Expensify/App/pull/29541
https://github.com/Expensify/App/pull/29544
https://github.com/Expensify/App/pull/29562

[kavimuru]

PRs from the past buildd
#25446
#26406
#27204
#27424
#27432
#27492
#27820
#28214
#28278
#28305
#28732
#28821
#28904
#28927
#28994
#29061
#29071
#29073
#29078
#29113
#29118
#29122
#29125
#29134
#29139
#29143
#29201
#29203
#29206
#29253
#29254
#29260
#29263
#29270
#29287
#29310
#29327
#29339
#29366
#29383
#29404
#29406
#29409
#29412
#29424
#29431
#29445
#29447
#29461
#29467
#29468
#29472
#29473
#29480
#29483
#29489
#29507
#29520
#29524
#29525
#29529
#29541
#29544

[francoisl]

Updated, it's now more manageable with 43 PRs.

[kavimuru]

@francoisl Regression TR is 62% of progress.

#28846 failing with #29746
#29288 failing with #29747
#29568 didn't test "Workspace chat" part as this is real teachers and principals

[youssef-lr]

Checking off #29551

[kavimuru]

@francoisl only 4% left in regression. Validating last PR and CP.

#28846 failing with #29746
#29288 failing with #29747
#29568 didn't test "Workspace chat" part as this is real teachers and principals

[youssef-lr]

Checking off #29568, we tested it thoroughly internally.

[francoisl]

29752 / 29746 tested on staging, checking those off.

[francoisl]

Removed the blocker label from 29819, SAML required sign-in is not implemented on production either and there are more changes coming in for SAML, I reassigned to the engineer who's working on this.

[francoisl]

• 29788 is also happening on production and the deploy blocker label was removed, going to check it
• we're CP'ing a fix for [HOLD for payment 2023-10-25] [HOLD for payment 2023-10-24] Login - User is not automatically logged in with magic link in different tab #29807, I'll test it on staging
• I'm checking with the assignee on the status of the last remaining blocker after those two

[francoisl]

#29807 tested on staging, checking off

[francoisl]

#29288 looks good too now, though @Beamanator I don't get automatically redirected to the Money2020 report (step 5). I see it's being created and I can open it, I'm just not automatically redirected to it.

[francoisl]

#29748 tested on staging, we're good to go.

[francoisl]