Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Members - Workspace Member List Page Stuck in Forever Loading State After Inviting New Members #29762

Closed
6 tasks done
kbecciv opened this issue Oct 17, 2023 · 57 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Oct 17, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.85.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697477533816919

Action Performed:

  1. Login to any account
  2. Go to Account Settings.
  3. Open any Workspace (or create a new one).
  4. Click on Members >> Invite.
  5. Type an not-existing email with the domain @‌applause.expensifail.com, for example: [email protected]
  6. Send the invite >> there will be a error message
  7. Go to the #announce room and confirm that the invited email from step Fix babel build on master #5 is added to the member list.
  8. Logout and then log in again.
  9. Again, navigate to Account Settings >> Workspace >> Members.
  10. Observed: The Workspace’s member list keeps loading indefinitely.

Expected Result:

Expected Result: .

  1. The Workspace's member list should load and display without any issues, as the invited email has already been added as a member in the #announce room.
  2. Alternatively, if there is an issue, the invited email should not be added as a new member.

Actual Result:

The Workspace's member list keeps loading indefinitely.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android.-.Native.2.mov
Android: mWeb Chrome
Android.-.Chrome.2.mov
iOS: Native
iOS.-.Native.2.MP4
iOS: mWeb Safari
iOS.-.Safari.1.MP4
MacOS: Chrome / Safari
MacOS.-.Safari.2.mov
MacOS.-.Chrome.4.mp4
Recording.5030.mp4
MacOS: Desktop
MacOS.-.Desktop.2.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0171cf99eaf358016e
  • Upwork Job ID: 1714258626307084288
  • Last Price Increase: 2023-10-31
Issue OwnerCurrent Issue Owner: @youssef-lr
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot changed the title Members - Workspace Member List Page Stuck in Forever Loading State After Inviting New Members [$500] Members - Workspace Member List Page Stuck in Forever Loading State After Inviting New Members Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0171cf99eaf358016e

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@s-alves10
Copy link
Contributor

This looks like a backend issue

image

The backend should return valid data

@jjcoffee
Copy link
Contributor

@s-alves10 Maybe we're providing the incorrect account ID? What's in the payload there?

@s-alves10
Copy link
Contributor

@jjcoffee

image

@melvin-bot melvin-bot bot added the Overdue label Oct 20, 2023
@alexpensify
Copy link
Contributor

@jjcoffee - what's the plan here? Do you agree with this feedback?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 20, 2023
@alexpensify
Copy link
Contributor

@jjcoffee - we need your feedback here. Thanks!

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@jjcoffee
Copy link
Contributor

@alexpensify Confirmed that this is a BE issue!

@melvin-bot
Copy link

melvin-bot bot commented Oct 24, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2023
@alexpensify alexpensify added the Internal Requires API changes or must be handled by Expensify staff label Oct 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

Current assignee @jjcoffee is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot removed the Overdue label Oct 26, 2023
@alexpensify
Copy link
Contributor

@youssef-lr - looks like the team found a backend issue. Can you please review for the next steps? Thanks!

@youssef-lr
Copy link
Contributor

No update yet, I'm still on it. I should have an update by EOW or early next one.

@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 11, 2024
@youssef-lr
Copy link
Contributor

youssef-lr commented Jan 15, 2024

Ok I made some progress. It looks like this only happens in controlled domains (such as expensifail), when a domain is validated, only the admin of the domain will be able to invite someone to a workspace from the domain. This is because only the admin is able to invite members and in the process create accounts for them that are not in the closed state.

I think this is by design, but we probably need to figure out how to show a cleaner error in this case, or even find another solution to make this possible. I'll start a discussion in #eng-chat on Monday to get some input.

@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 24, 2024
@youssef-lr
Copy link
Contributor

Resuming work on this one this week.

@melvin-bot melvin-bot bot removed the Overdue label Jan 31, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 9, 2024
@youssef-lr youssef-lr added the Reviewing Has a PR in review label Feb 11, 2024
@melvin-bot melvin-bot bot removed the Overdue label Feb 11, 2024
@youssef-lr
Copy link
Contributor

PR's ready.

@youssef-lr
Copy link
Contributor

We're all set here.

@tranvantoan-qn
Copy link

tranvantoan-qn commented Feb 15, 2024

@youssef-lr @alexpensify
What about the reporting bonus that should be applied for me, maybe we missed it?

@youssef-lr
Copy link
Contributor

My bad sorry. @alexpensify I think we need to pay the reporting bonus here.

@youssef-lr youssef-lr reopened this Feb 16, 2024
@alexpensify
Copy link
Contributor

Heads up, I'm OOO until Tuesday and will review this request then.

@alexpensify
Copy link
Contributor

I'm still catching up from being OOO-- I need another day to review this one.

@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Feb 21, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 21, 2024
Copy link

melvin-bot bot commented Feb 21, 2024

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 21, 2024
@alexpensify alexpensify removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 21, 2024
@alexpensify
Copy link
Contributor

@tranvantoan-qn - please accept the proposal in Upwork and I can complete the payment process there. Thanks!

https://www.upwork.com/jobs/~0186ed4230f672bcfe

@tranvantoan-qn
Copy link

@alexpensify I have accepted the offer, thank you!

@alexpensify
Copy link
Contributor

All set here @tranvantoan-qn has been paid via Upwork! Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants