[Form Provider Refactor] RoomNameInput #29771

kowczarz · 2023-10-17T13:30:42Z

Details

Fixed Issues

$ #28877

Tests

IMPORTANT: User needs to have the permission to use policy rooms enabled.

Workspace new room:

Log in
Press + button > Press Start chat > Switch to # Room
Check if errors appears when incorrect data is typed in
Type correct data and create a new room

Room name:

Log in
If there are no rooms, create a new one (steps above)
In the chat room press its name > Press Settings > Press Room name
Check if errors appears when incorrect data is typed in
Type correct data and update the name of the room

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

widelo_dla_kamila_3_H.265.mp4

Android: mWeb Chrome

android.web_H.265.mp4

iOS: Native

ios.native_H.265.mp4

iOS: mWeb Safari

ios.web_H.265.mp4

MacOS: Chrome / Safari

web_H.265.mp4

MacOS: Desktop

desktop_H.265.mp4

…m-name-page # Conflicts: # src/components/Form/FormWrapper.js # src/pages/workspace/WorkspaceNewRoomPage.js

…m-name-page

melvin-bot · 2023-10-17T13:30:47Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

src/components/Form/FormProvider.js

…m-name-page

melvin-bot · 2023-10-18T13:46:29Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-10-18T13:47:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-26.at.9.35.12.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-10-26.at.9.46.16.AM.mov

Mobile Web - Safari

Screen.Recording.2023-10-26.at.9.49.29.AM.mov

Desktop

Screen.Recording.2023-10-26.at.9.37.55.AM.mov

iOS

Screen.Recording.2023-10-26.at.9.51.42.AM.mov

Android

Screen.Recording.2023-10-26.at.9.47.32.AM.mov

kowczarz · 2023-10-18T13:47:31Z

@luacmartins the PR is ready for the review.

luacmartins · 2023-10-18T17:08:10Z

src/components/RoomNameInput/index.js

-        // Prevent cursor jump behaviour:
-        // Check if newRoomNameWithHash is the same as modifiedRoomName
-        // If it is then the room name is valid (does not contain unallowed characters); no action required
-        // If not then the room name contains unvalid characters and we must adjust the cursor position manually
-        // Read more: https://github.com/Expensify/App/issues/12741


This is no longer an issue with the new solution?

Yes, with current approach if we are parsing the value of the input, it's completely separated from the value we display, so it's faster (we are limiting numbers of re-renders) and it doesn't affect the cursor.

luacmartins

LGTM! All yours @allroundexperts

kowczarz · 2023-10-20T09:31:04Z

Hey @allroundexperts will you manage to do a review today?

allroundexperts · 2023-10-26T17:40:04Z

Just confirmed that this is not appearing on Staging. @luacmartins Other than this, its working well. Since @kowczarz is going on a leave, I think its best to merge this PR (since its not creating any functional issue) and I can do a follow up PR fixing these errors. Let me know if you agree!

kowczarz · 2023-10-26T17:41:14Z

I will handle this in a couple minutes.

allroundexperts · 2023-10-26T17:42:10Z

Cool. Thanks. I thought you had ended your day 😄

kowczarz · 2023-10-26T17:50:13Z

Done

allroundexperts · 2023-10-26T17:58:01Z

@kowczarz Another one?

kowczarz · 2023-10-26T18:01:04Z

This one is fixed here and I would like not to overwrite this prop here as well, to avoid conflicts.

allroundexperts

Looks good!

OSBotify · 2023-10-26T18:19:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2023-10-26T19:54:16Z

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start runJsBundle	803.433 ms → 859.143 ms (+55.710 ms, +6.9%) 🔴

Show details

Name	Duration
App start runJsBundle	Baseline Mean: 803.433 ms Stdev: 33.441 ms (4.2%) Runs: 713 722 751 754 759 767 769 772 773 774 775 777 777 778 778 779 780 782 785 785 785 788 789 790 791 793 795 796 798 801 802 804 804 806 808 812 815 816 817 820 821 827 828 828 829 830 832 836 838 839 840 842 846 846 848 854 858 860 861 863 Current Mean: 859.143 ms Stdev: 25.289 ms (2.9%) Runs: 811 812 815 822 822 824 826 831 832 832 837 838 841 842 843 843 845 846 846 848 849 849 852 853 855 857 857 857 858 859 860 860 862 864 865 867 867 868 872 874 875 876 877 880 882 886 888 889 889 891 891 894 900 905 909 919

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	1170.920 ms → 1215.503 ms (+44.583 ms, +3.8%)
Open Search Page TTI	709.809 ms → 732.284 ms (+22.476 ms, +3.2%)
App start regularAppStart	0.014 ms → 0.014 ms (+0.000 ms, +1.1%)
App start nativeLaunch	21.672 ms → 21.291 ms (-0.382 ms, -1.8%)

Show details

Name	Duration
App start TTI	Baseline Mean: 1170.920 ms Stdev: 32.597 ms (2.8%) Runs: 1089.4934580000117 1101.4263239998836 1108.1913779999595 1114.1385679999366 1117.0525169998873 1121.4536299998872 1125.0287939999253 1127.2439200000372 1132.0103599999566 1139.0646309999283 1141.1090559998993 1141.1930879999418 1143.44294800004 1144.5314430000726 1146.7463070000522 1147.5987050000113 1150.8555519999936 1153.269922999898 1159.0278320000507 1164.7444660000037 1167.0621690000407 1167.2251659999602 1168.2899680000264 1168.3064139999915 1168.6788820000365 1170.4789150001016 1171.3167270000558 1171.5239130000118 1173.9295880000573 1174.683015000075 1176.807691999944 1182.7048200001009 1182.905262999935 1182.9995899999049 1184.5023129999172 1185.0847869999707 1186.1094140000641 1186.3088189999107 1188.0357039999217 1188.5368129999842 1189.6556899999268 1189.6960199999157 1191.671866999939 1195.4977269999217 1195.583735999884 1198.4506550000515 1199.2674720000941 1202.10831400007 1206.4376020000782 1207.018412000034 1207.7558579999022 1208.1287680000532 1211.3711949998979 1212.113296000054 1213.8294889999088 1215.8367139999755 1225.8126640000846 1230.0106649999507 Current Mean: 1215.503 ms Stdev: 35.619 ms (2.9%) Runs: 1125.9670510001015 1134.2321399999782 1149.6664440000895 1152.2299490000587 1168.141362000024 1169.015509000048 1170.6675269999541 1174.048225000035 1182.3217579999473 1183.2479699999094 1190.115788999945 1190.1208369999658 1190.545746000018 1192.7764379999135 1192.794980000006 1192.8884550000075 1192.9491500000004 1195.692444999935 1197.25002399995 1197.5661669999827 1198.9510490000248 1200.9116909999866 1201.7765550001059 1202.6751079999376 1203.7700739998836 1207.3683629999869 1212.3898350000381 1214.9039330000523 1222.6108790000435 1222.7676369999535 1223.5809180000797 1223.6798779999372 1224.378400000045 1226.7775270000566 1228.5315650000703 1229.1450509999413 1229.9266029999126 1230.9630899999756 1235.1816769998986 1235.3334290001076 1236.1133640001062 1239.182160000084 1239.4970490001142 1240.8173579999711 1241.72665899992 1242.117935999995 1243.4148889998905 1243.712780999951 1245.0310390000232 1252.2598099999595 1254.371797000058 1254.8304010001011 1256.7084059999324 1267.4006350000855 1273.474547999911 1275.2542699999176 1282.3836199999787 1293.0378350000829
Open Search Page TTI	Baseline Mean: 709.809 ms Stdev: 45.566 ms (6.4%) Runs: 633.5416669999249 636.50077399984 638.1020110002719 638.8905440000817 644.479127000086 645.6341559998691 651.3993330001831 651.4556080000475 652.4208990000188 656.3836679998785 659.6531170001253 660.9259440000169 664.4662270001136 671.5259610000066 674.7101239999756 675.6850589998066 676.9396160002798 682.6803799998015 684.0531409997493 684.4809980001301 684.8497320003808 685.3996590003371 686.013224999886 686.7746170000173 691.188192000147 693.9936119997874 697.431641000323 697.7391360001639 699.8116450002417 708.4850669996813 709.8354090000503 710.9267990002409 717.8039959999733 717.9794519999996 718.1101079997607 722.3323160000145 724.0014250003733 725.6154379998334 728.0847579999827 729.4419760000892 731.0272220000625 732.5965990000404 733.3223069999367 733.494425999932 735.7786460001953 750.6467289999127 751.9062100001611 754.5332030002028 755.2156990002841 755.3157559996471 757.2073160000145 759.2903239999432 762.3223480000161 762.3493659999222 767.8451339998282 775.1008299998939 776.9020179999061 778.6916100000963 785.8068039999343 805.3394780000672 813.8837890001014 Current Mean: 732.284 ms Stdev: 49.802 ms (6.8%) Runs: 642.9830330000259 648.5175379998982 667.2693279995583 669.3327230000868 669.4409179999493 670.5269369999878 674.7237140000798 676.0033769998699 678.5139979999512 678.8761800001375 681.9525969999377 682.0343829998747 682.5839439998381 689.2845049998723 690.3492439999245 691.7396649997681 691.9542239999864 692.3855389999226 697.994589000009 700.9816089998931 706.8102219998837 707.0879720002413 710.6059979998972 710.694987999741 713.2772619999014 713.5435390002094 713.7930099999066 717.9764809999615 718.0115160001442 721.4985349997878 727.2535810000263 729.2520749999676 732.1587730001193 736.1572270002216 737.0690520000644 742.4876309998799 743.0296229999512 743.500163000077 755.3583579999395 755.7780349999666 759.2575679998845 760.4146740003489 760.8770749997348 764.0082199997269 764.593913000077 768.6081949998625 768.8383380000014 776.778239000123 777.0984700000845 778.8900960003957 780.8567710001953 784.2353109996766 791.0479340003803 791.0627450000029 794.006510999985 796.9050710001029 799.747315000277 799.8352459999733 799.9318439997733 867.2645270000212 872.3027349999174
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (4.8%) Runs: 0.012491999892517924 0.012653999961912632 0.012695000041276217 0.01297999988310039 0.013020999962463975 0.013183999806642532 0.013264999957755208 0.013306000037118793 0.01334599987603724 0.013346000108867884 0.013386999955400825 0.013386999955400825 0.013508999953046441 0.013508999953046441 0.013550000032410026 0.01359100011177361 0.013712999876588583 0.013794000027701259 0.013794000027701259 0.013833999866619706 0.013835000107064843 0.013916000025346875 0.013956000097095966 0.013956999871879816 0.01395700010471046 0.01395700010471046 0.014038000022992492 0.014038000022992492 0.014078000094741583 0.014078999869525433 0.014079000102356076 0.014160000020638108 0.014160000020638108 0.014161000028252602 0.014282000018283725 0.014283000025898218 0.014404000015929341 0.014404000015929341 0.014404000015929341 0.014405000023543835 0.01448600017465651 0.014526000013574958 0.014527000021189451 0.014527000021189451 0.01460699993185699 0.014607999939471483 0.014608000172302127 0.014649000018835068 0.014688999857753515 0.0147299999371171 0.014810999855399132 0.014811000088229775 0.015015000011771917 0.015096000162884593 0.015462000155821443 0.01566599984653294 Current Mean: 0.014 ms Stdev: 0.001 ms (4.8%) Runs: 0.012858000118285418 0.01306200004182756 0.013101999880746007 0.013184000039473176 0.013223999878391623 0.013224999886006117 0.013467999873682857 0.013508999953046441 0.013509000185877085 0.013548999791964889 0.013549999799579382 0.013550000032410026 0.013631999958306551 0.013631999958306551 0.013672000030055642 0.013712000101804733 0.013752999948337674 0.013752999948337674 0.013794000027701259 0.013833999866619706 0.01387499994598329 0.013875000178813934 0.013956000097095966 0.013996999943628907 0.013996999943628907 0.013998000184074044 0.013998000184074044 0.014078000094741583 0.014119000174105167 0.014160000020638108 0.014160000020638108 0.014160999795421958 0.014200999867171049 0.014282000018283725 0.01432300009764731 0.014445000095292926 0.014485999941825867 0.014526000013574958 0.014526000013574958 0.014526000013574958 0.014567000092938542 0.014567000092938542 0.014607000164687634 0.014607999939471483 0.014648000011220574 0.014770000008866191 0.014771000016480684 0.014851000159978867 0.014851999934762716 0.014974000165238976 0.015177000081166625 0.01525900000706315 0.015299999853596091 0.015381000004708767 0.015503000002354383 0.015503000002354383 0.015949999913573265
App start nativeLaunch	Baseline Mean: 21.672 ms Stdev: 3.042 ms (14.0%) Runs: 18 19 19 19 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 23 23 24 24 24 24 26 26 26 26 29 29 29 29 30 Current Mean: 21.291 ms Stdev: 1.913 ms (9.0%) Runs: 18 18 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 23 23 23 23 23 23 23 23 24 24 24 25 26 26 26

github-actions · 2023-10-26T19:54:18Z

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

OSBotify · 2023-10-26T22:59:17Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.92-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins · 2023-10-27T18:57:40Z

@cdOut @kowczarz we had to revert this PR since it caused the 3 blockers below:

[HOLD for payment 2023-11-07] [HOLD for payment 2023-11-06] Room - When entering a "Space" while writing Room name "-" is not added #30500
[HOLD for payment 2023-11-07] [HOLD for payment 2023-11-06] [$500] Room - Room name field is not populated with existing room name in room name editor #30504
[HOLD for payment 2023-11-07] [HOLD for payment 2023-11-06] [$500] Android - Room - Unable to refocus on the room name field after defocusing it #30507

Could you please work on a new PR and fix the above issues?

OSBotify · 2023-10-30T07:42:35Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.92-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-30T08:03:32Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.93-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T21:36:41Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kowczarz added 14 commits October 12, 2023 10:36

Form validation fixes

5248bc6

Form docs improvements

5b4a419

Fix prop types

bd87379

Remove console log

10ea700

Refactor roomNameInput

eab18e6

Refactor RoomNamePage

40a6da2

Refactor WorkspaceNewRoomPage

e35bddc

Merge remote-tracking branch 'expensify/main' into from-migration/roo…

2e12b63

…m-name-page # Conflicts: # src/components/Form/FormWrapper.js # src/pages/workspace/WorkspaceNewRoomPage.js

Post-merge fixes

1fd92cc

Prettier fixes

ba1a78d

Add value parser to the new form

fefdb2b

Remove native room name input

e05b537

Update room name input

eff3e88

Merge remote-tracking branch 'expensify/main' into from-migration/roo…

187fa7d

…m-name-page

Prettier

398b842

mczernek approved these changes Oct 18, 2023

View reviewed changes

src/components/Form/FormProvider.js Outdated Show resolved Hide resolved

kowczarz added 2 commits October 18, 2023 11:35

Merge remote-tracking branch 'expensify/main' into from-migration/roo…

edd40b9

…m-name-page

Code review changes

bd686b2

kowczarz marked this pull request as ready for review October 18, 2023 13:46

kowczarz requested a review from a team as a code owner October 18, 2023 13:46

melvin-bot bot requested review from allroundexperts and removed request for a team October 18, 2023 13:46

luacmartins self-requested a review October 18, 2023 16:00

luacmartins reviewed Oct 18, 2023

View reviewed changes

luacmartins previously approved these changes Oct 19, 2023

View reviewed changes

Fix propType

ccf0b9f

allroundexperts approved these changes Oct 26, 2023

View reviewed changes

melvin-bot bot requested a review from luacmartins October 26, 2023 18:02

luacmartins approved these changes Oct 26, 2023

View reviewed changes

luacmartins merged commit 99f4fe6 into Expensify:main Oct 26, 2023
13 checks passed

github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Oct 26, 2023

OSBotify mentioned this pull request Oct 26, 2023

Deploy Checklist: New Expensify 2023-10-26 #30469

Closed

64 tasks

BhuvaneshPatil mentioned this pull request Oct 27, 2023

[HOLD for payment 2023-11-07] [HOLD for payment 2023-11-06] Room - When entering a "Space" while writing Room name "-" is not added #30500

Closed

6 tasks

aimane-chnaif mentioned this pull request Oct 27, 2023

[HOLD for payment 2023-12-12] [HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] RoomNamePage and WorkspaceNewRoomPage #28877

Closed

luacmartins mentioned this pull request Oct 27, 2023

Revert "[Form Provider Refactor] RoomNameInput" #30532

Merged

57 tasks

luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Oct 27, 2023

luacmartins assigned kowczarz Oct 27, 2023

OSBotify mentioned this pull request Oct 30, 2023

Deploy Checklist: New Expensify 2023-10-30 #30560

Closed

kowczarz mentioned this pull request Nov 8, 2023

[Form Provider Refactor] RoomNameInput fixes #30996

Merged

58 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Form Provider Refactor] RoomNameInput #29771

[Form Provider Refactor] RoomNameInput #29771

kowczarz commented Oct 17, 2023 •

edited

Loading

melvin-bot bot commented Oct 17, 2023

melvin-bot bot commented Oct 18, 2023

allroundexperts commented Oct 18, 2023 •

edited

Loading

kowczarz commented Oct 18, 2023

luacmartins Oct 18, 2023

kowczarz Oct 19, 2023

luacmartins left a comment

kowczarz commented Oct 20, 2023

allroundexperts commented Oct 26, 2023

kowczarz commented Oct 26, 2023

allroundexperts commented Oct 26, 2023

kowczarz commented Oct 26, 2023

allroundexperts commented Oct 26, 2023

kowczarz commented Oct 26, 2023

allroundexperts left a comment

OSBotify commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

OSBotify commented Oct 26, 2023

luacmartins commented Oct 27, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

[Form Provider Refactor] RoomNameInput #29771

[Form Provider Refactor] RoomNameInput #29771

Conversation

kowczarz commented Oct 17, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 17, 2023

melvin-bot bot commented Oct 18, 2023

allroundexperts commented Oct 18, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

kowczarz commented Oct 18, 2023

luacmartins Oct 18, 2023

Choose a reason for hiding this comment

kowczarz Oct 19, 2023

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

kowczarz commented Oct 20, 2023

allroundexperts commented Oct 26, 2023

kowczarz commented Oct 26, 2023

allroundexperts commented Oct 26, 2023

kowczarz commented Oct 26, 2023

allroundexperts commented Oct 26, 2023

kowczarz commented Oct 26, 2023

allroundexperts left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

Performance Comparison Report 📊

Significant Changes To Duration

Meaningless Changes To Duration

github-actions bot commented Oct 26, 2023

OSBotify commented Oct 26, 2023

luacmartins commented Oct 27, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 30, 2023

OSBotify commented Oct 31, 2023

kowczarz commented Oct 17, 2023 •

edited

Loading

allroundexperts commented Oct 18, 2023 •

edited

Loading