[HOLD for payment 2024-01-17] [$500] Android - Request money - Currency list flashes briefly when opening currency list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.85-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to + > Request money > Manual
3. Tap on the currency

Expected Result:

The currency list will not flash

Actual Result:

The currency list flashes briefly

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6240571_1697551012172.Screen_Recording_20231017_191736_New_Expensify__1_.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01937182f6afc52c43
• Upwork Job ID: 1714287345950720000
• Last Price Increase: 2023-10-31
• Automatic offers:
• fedirjh | Reviewer | 27488223

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01937182f6afc52c43

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[abekkala]

I'll give this another day-2 for proposals and I'll bring to CS or SWM

[fedirjh]

No proposals yet.

[vladimir-8]

I cannot reproduce it on the latest build from main on Android 13. @lanitochka17 Which phone/android version did you test it with?
https://github.com/Expensify/App/assets/70273239/6fedb940-b3eb-4b1c-8dcd-d927c5d4951b

[melvin-bot]

📣 @vladimir-8! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[vladimir-8]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~013f725105078cfc87

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@abekkala, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fedirjh]

@lanitochka17 Can you please retest this one?

[lanitochka17]

Issue reproducible on build 1.3.91-6
Samsung Galaxy A50/Android11

0-02-01-9d3f20c79df869f9c305fbe407ea67641b932a3730688146f1f490922ce4cda9_f6d0d7831fa71e96.mp4

[melvin-bot]

@abekkala, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fedirjh]

@abekkala Let's raise the price to attract proposals?

[abekkala]

@conorpendergrast

STATUS:

I'm going ooo

PR was merged to prod 5 days ago (Dec 14)
Payment date will be Dec 21

• Issue reported by: Applause - Internal Team
• Fix: @barttom [$500, if no regressions] callstack, no payment
• PR Review: @fedirjh [$500, if no regressions]

[conorpendergrast]

Love the write-up April, merry Christmas and happy new year

[situchan]

Coming from #22508 (comment):

The issue with the skeleton loader not showing is the recent regression from #29780.

@bernhardoj is this correct?

[bernhardoj]

@situchan yes, that's correct.

[situchan]

I think we should handle this regression here as it's still within regression period.
cc: @barttom

[barttom]

Sorry, didn't notice messages before. I'll try to investigate it tomorrow.

[fedirjh]

@barttom I think the style should’ve been applied to this line

App/src/components/SelectionList/BaseSelectionList.js

Line 482 in 6797636

style={!maxToRenderPerBatch && styles.opacity0}

So it should be :

 style={!maxToRenderPerBatch || isInitialRender && styles.opacity0}

[barttom]

So the problem is that isInitialRender will be changed after SectionList will be rendered. When we don't have date - we stick with opacity set to zero.

Screen.Recording.2023-12-21.at.15.00.56.mp4

Because of That, I propose wrapping only SectionList in the view and passing prepared styles there. In the
current wrapper we have another conditional rendered components that weren't a part of the issue.

@fedirjh what do you think?

[fedirjh]

I propose wrapping only SectionList in the view and passing prepared styles there

@barttom That's already my suggestion in #29780 (comment) , there is no need to wrap the whole section list in a new view we can just pass the styles to the section list.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: move hiding only to the SectionList #33833

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @barttom does not require payment (Contractor)
• @fedirjh requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abekkala]

Issue reported by: Applause - Internal Team
Fix: @barttom does not require payment (Callstack)
PR Review: @fedirjh offer

@fedirjh can you complete the checklist above, I can then process payment in Upwork

[fedirjh]

BugZero Checklist:

• Link to the PR: I don't believe this is related to any recent PR. It doesn't appear to be a regression. There is no evidence of a PR that could have caused this issue.
• Link to comment: N/A
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: N/A This is not worth a regression test, it's a little UI improvement, the bug doesn’t affect the user experience.

[abekkala]

@fedirjh payment sent and contract ended - thank you! 🎉