[HOLD for payment 2023-10-30] DRY up the logic for the backTo param in ROUTES.ts

[tgolen]

Problem

There is repeated code in ROUTES.ts that adds an optional backTo parameter to URLs.

Why is this important?

If it is not DRY, then is more difficult to maintain and keep consistent

Solution

Move the code into a method called addBackToParam() that is used in the routes that need it

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c7e63f69a8031ac1
• Upwork Job ID: 1714329935530221568
• Last Price Increase: 2023-10-17

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c7e63f69a8031ac1

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• DRY up the code for the backTo param in routes #29813

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[tgolen]

@kevinksullivan Can you please facilitate the payment for @Ollyws reviewing the PR?

[Ollyws]

There was a regression on this PR, happy to take the hit for it because I really should have spotted it.

[tgolen]

Ah phooey, I missed that regression :(

…

On Mon, Oct 30, 2023 at 7:56 AM Olly ***@***.***> wrote: There was a regression on this PR, happy to take the hit for it because I really should have spotted it. — Reply to this email directly, view it on GitHub <#29799 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB2CKBAL3ICRGD46J4TYB6WW7AVCNFSM6AAAAAA6EGIR5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVGI2TKNZZGM> . You are receiving this because you were assigned.Message ID: ***@***.***>

[tgolen]

I think I'll just close this out then without payment.

[Ollyws]

@tgolen Should the C+ not be paid 50% of the original compensation, or did you mean for that to be handled in the regression issue?

[tgolen]

I am so sorry about that! I needed to read up on the payment rules for regressions. I'm reopening this and @kevinksullivan can you please pay @Ollyws 50% of the original compensation.

[tgolen]

bump @kevinksullivan Can you please help with payment here?

[tgolen]

Pinged Kevin 1:1

[kevinksullivan]

offer sent @Ollyws , let me know when you accept!

[Ollyws]

@kevinksullivan Accepted, thanks!

[kevinksullivan]

all set!