Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "webfix/27090 In Header Workspace, members are not shown." #29833

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Oct 17, 2023

Reverts #29420

We need to revert this PR because the issue that it fixes isn't actually a bug. We don't share workspace rooms by default with everyone in the workspace on creation, so it's expected that workspace rooms only have a single participant by default.

@jasperhuangg jasperhuangg requested a review from deetergp October 17, 2023 21:28
@jasperhuangg jasperhuangg requested a review from a team as a code owner October 17, 2023 21:28
@melvin-bot melvin-bot bot removed the request for review from a team October 17, 2023 21:28
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jasperhuangg jasperhuangg self-assigned this Oct 17, 2023
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 351c98a
Status: ✅  Deploy successful!
Preview URL: https://b5aa31b5.helpdot.pages.dev
Branch Preview URL: https://revert-29420-webfix-27090-io.helpdot.pages.dev

View logs

@deetergp deetergp merged commit d0ab966 into main Oct 17, 2023
11 of 14 checks passed
@deetergp deetergp deleted the revert-29420-webfix/27090-iou-header-workspace branch October 17, 2023 21:32
@melvin-bot melvin-bot bot added the Emergency label Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

@deetergp looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.86-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants