Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payment due] Update loading screen to play animation and sound #29835

Closed
ryanschaffer opened this issue Oct 17, 2023 · 45 comments
Closed

[Payment due] Update loading screen to play animation and sound #29835

ryanschaffer opened this issue Oct 17, 2023 · 45 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design NewFeature Something to build that is a new item. Not a priority

Comments

@ryanschaffer
Copy link

We are updating our loading animation for NewDot. The loading animation has a sound that plays during it. We are testing out these different sounds. We have 4 different sounds we want to test, so we will need to update this animation with a new sound every week for 4 weeks and then we are going to vote on which one we like best.

The animation should replace our loading screen we have currently. So it will show on start up, refresh, re-auth, etc...

@ryanschaffer
Copy link
Author

ryanschaffer commented Oct 17, 2023

Expensify_Sonic_Minimal_Nonvocal.mp4
Expensify_Sonic_Minimal_Vocal.mp4
Expensify_Sonic_Full_Nonvocal.mp4
Expensify_Sonic_Full_Vocal.mp4

Here it is zipped up.
Expensify_SonicBranding.zip

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Current assignee @shawnborton is eligible for the Design assigner, not assigning anyone new.

@quinthar
Copy link
Contributor

quinthar commented Oct 17, 2023

Can we keep the 5th variation at what we currently have (the static E), as a control? This way we can compare to having no animation at all.

@melvin-bot melvin-bot bot added the Overdue label Oct 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

@shawnborton, @ryanschaffer Huh... This is 4 days overdue. Who can take care of this?

@ryanschaffer
Copy link
Author

No progress yet. Margelo will start working on this next week.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

@shawnborton, @ryanschaffer Eep! 4 days overdue now. Issues have feelings too...

@ryanschaffer
Copy link
Author

Waiting for implementation

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2023
@hannojg
Copy link
Contributor

hannojg commented Nov 2, 2023

Hey, can you please assign @lauridskern to this task? He will work on that issue 😊

Reference to slack: https://expensify.slack.com/archives/C05LX9D6E07/p1697346119511919

@lauridskern
Copy link
Contributor

👋

@melvin-bot melvin-bot bot added the Overdue label Nov 3, 2023
Copy link

melvin-bot bot commented Nov 3, 2023

📣 @lauridskern! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Copy link

melvin-bot bot commented Nov 6, 2023

@shawnborton, @ryanschaffer Huh... This is 4 days overdue. Who can take care of this?

@lauridskern
Copy link
Contributor

lauridskern commented Nov 7, 2023

can you assign me to the issue? @ryanschaffer

@lauridskern
Copy link
Contributor

Hi, do we have lottie files of those animations?

@lauridskern lauridskern mentioned this issue Nov 8, 2023
50 tasks
@lauridskern
Copy link
Contributor

I implemented this now and there is an open question regarding the correlation between app load and animation. The first video has an artificial delay of 2000ms which is the perfect length for the video but if the app loads faster like the second video (500ms, and in reality loading could/should be even faster), the video fades out before finishing which looks quite odd

Simulator.Screen.Recording.-.iPhone.15.-.2023-11-08.at.10.43.39.mp4
Simulator.Screen.Recording.-.iPhone.15.-.2023-11-08.at.10.45.10.mp4

Copy link

melvin-bot bot commented Nov 8, 2023

@shawnborton, @ryanschaffer Still overdue 6 days?! Let's take care of this!

@ryanschaffer
Copy link
Author

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 8, 2023
@shawnborton
Copy link
Contributor

Still waiting for a testable version to be built by our contributors.

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
Copy link

melvin-bot bot commented Feb 6, 2024

Triggered auto assignment to @cristipaval, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Copy link

melvin-bot bot commented Feb 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Mar 8, 2024

@shawnborton, @ryanschaffer, @lauridskern, @cristipaval, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@aimane-chnaif
Copy link
Contributor

@cristipaval can you please re-open, add New feature, remove Reviewing and bump to Daily?

@cristipaval cristipaval added Daily KSv2 and removed Monthly KSv2 Reviewing Has a PR in review labels Mar 8, 2024
@cristipaval cristipaval reopened this Mar 8, 2024
@cristipaval cristipaval added the NewFeature Something to build that is a new item. label Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 8, 2024
Copy link

melvin-bot bot commented Mar 8, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@melvin-bot melvin-bot bot added the Overdue label Mar 18, 2024
@cristipaval cristipaval added Daily KSv2 and removed Weekly KSv2 labels Mar 18, 2024
@melvin-bot melvin-bot bot removed the Overdue label Mar 18, 2024
@cristipaval cristipaval added the Awaiting Payment Auto-added when associated PR is deployed to production label Mar 18, 2024
@cristipaval cristipaval changed the title Update loading screen to play animation and sound [Payment due] Update loading screen to play animation and sound Mar 18, 2024
@cristipaval
Copy link
Contributor

@MitchExpensify, could you please help with the payment for the C+ review? @aimane-chnaif is the payee.

@MitchExpensify
Copy link
Contributor

@funny2code
Copy link
Contributor

funny2code commented Mar 18, 2024

I am highly interested in this task so I submitted to a proposal on Upwork. I look forward to hearing from Expensify team there, thanks in advance.

@MitchExpensify
Copy link
Contributor

Paid and contract ended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Design NewFeature Something to build that is a new item. Not a priority
Projects
None yet
Development

No branches or pull requests

10 participants