[HOLD for payment 2023-10-27] [HOLD for payment 2023-10-25] [$250] Chat - Deleting message in chat causes black screen

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.86-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: @ayazhussain79 /Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697570868725089

Action Performed:

1. Login in to New Expensify App
2. Go to any chat
3. Send any message
4. Hold comment and select delete message

Expected Result:

Message is deleted and user and continue to chat

Actual Result:

Black screen appears and user can not use app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Bug6241236_1697592197471.RPReplay_Final1697590972.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0141195528274e1c9e
• Upwork Job ID: 1714467113988296704
• Last Price Increase: 2023-10-18
• Automatic offers:
• tienifr | Contributor | 27251966

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sophiepintoraetz]

Yup, I'm able to reproduce this

RPReplay_Final1697594178.MP4

[youssef-lr]

Investigating

[youssef-lr]

I'm seeing this error in the console, still investigating what's causing this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0141195528274e1c9e

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Black screen appears and user can not use app

What is the root cause of that problem?

It comes from this PR, it removed the withNavigationFallback assuming that Buttons are not used outside of navigation container, but it is (in the delete confirm modal), hence the crash.

withNavigationFallback was added with the exact purpose of letting the Button be used outside the navigation container.

What changes do you think we should make in order to solve the problem?

We need to restore the withNavigationFallback implementation in that PR

What alternative solutions did you explore? (Optional)

NA

[tienifr]

@youssef-lr I can quickly raise a PR for this deploy blocker if assigned 👍

[youssef-lr]

Thanks @tienifr! Agreed, we need to bring back that HOC. I'll be adjusting the price if you don't mind since this is a straight revert.

[melvin-bot]

Upwork job price has been updated to $125

[melvin-bot]

Upwork job price has been updated to $250

[melvin-bot]

🎯 ⚡️ Woah @thesahindia / @tienifr, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @tienifr got assigned: 2023-10-18 03:05:28 Z
• when the PR got merged: 2023-10-18 19:17:17 UTC

On to the next one 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Remove withNavigationFallback.js HOC" #29844

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @thesahindia does not require payment (Eligible for Manual Requests)
• @tienifr requires payment offer (Contributor)
• @ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[thesahindia]

The PR was reviewed by @situchan.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Remove withNavigationFallback.js HOC" #29844

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @tienifr requires payment offer (Contributor)
• @ayazhussain79 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@youssef-lr] The PR that introduced the bug has been identified. Link to the PR:
• [@youssef-lr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@youssef-lr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@tienifr] Determine if we should create a regression test for this bug.
• [@tienifr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sophiepintoraetz]

Okay @youssef-lr - can you confirm the payment summaries here:

• Reporter @ayazhussain79 $50
• Contributor @tienifr $250
• Reviewer/C+ @situchan $250

[youssef-lr]

I think the C+ payment is usually the same as the contributor's? Otherwise looks good!

[sophiepintoraetz]

@situchan - would you mind completing the checklist as well, please?

[situchan]

Bonus might apply for low price issues as well.
ref: #29639 (comment)

[sophiepintoraetz]

That's a misunderstanding - no urgency bonus applies here!