[HOLD for payment 2023-10-27] [HOLD for payment 2023-10-25] [$500] IOU-Tapping on distance receipt, the receipt thumbnail is missing in the receipt page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.86-1

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

1. Launch app
2. Tap fab
3. Tap request money-- Distance
4. Enter start and finish waypoints
5. Tap next
6. Select a Workspace
7. Tap Request
8. Tap on the distance IOU created
9. Tap on the receipt

Expected Result:

When user taps on receipt, the receipt thumbnail must be shown in the receipt page.

Actual Result:

When user taps on receipt, the receipt thumbnail is missing in the receipt page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6241408_1697612465827.distance_receipt.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

20231018_111907.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014d1b9028b2d4c9f2
• Upwork Job ID: 1714584537318621184
• Last Price Increase: 2023-10-18
• Automatic offers:
• ntdiary | Reviewer | 27259293
• tienifr | Contributor | 27259295

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014d1b9028b2d4c9f2

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[izarutskaya]

Not reproducible in production

20231018_112125.mp4

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU-Tapping on distance receipt, the receipt thumbnail is missing in the receipt page

What is the root cause of that problem?

getThumbnailAndImageURIs get the transaction as parameter

App/src/libs/ReceiptUtils.ts

Line 28 in e8cb124

function getThumbnailAndImageURIs(transaction: Transaction): ThumbnailAndImageURI {

but we pass the wrong params here

App/src/components/DistanceEReceipt.js

Line 34 in e8cb124

const {thumbnail} = TransactionUtils.hasReceipt(transaction) ? ReceiptUtils.getThumbnailAndImageURIs(transaction.receipt.source, transaction.filename) : {};

What changes do you think we should make in order to solve the problem?

change this line

App/src/components/DistanceEReceipt.js

Line 34 in e8cb124

const {thumbnail} = TransactionUtils.hasReceipt(transaction) ? ReceiptUtils.getThumbnailAndImageURIs(transaction.receipt.source, transaction.filename) : {};

to

    const {thumbnail} = TransactionUtils.hasReceipt(transaction) ? ReceiptUtils.getThumbnailAndImageURIs(transaction) : {};

Result

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[AliYar-Khan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping on distance receipt, the receipt thumbnail is missing in the receipt page

What is the root cause of that problem?

getThumbnailAndImageURIs function gets the transaction as parameter

App/src/libs/ReceiptUtils.ts

Line 28 in e8cb124

function getThumbnailAndImageURIs(transaction: Transaction): ThumbnailAndImageURI {

but we pass the wrong params here

App/src/components/DistanceEReceipt.js

Line 34 in e8cb124

const {thumbnail} = TransactionUtils.hasReceipt(transaction) ? ReceiptUtils.getThumbnailAndImageURIs(transaction.receipt.source, transaction.filename) : {};

What changes do you think we should make in order to solve the problem?

change this line

App/src/components/DistanceEReceipt.js

Line 34 in e8cb124

const {thumbnail} = TransactionUtils.hasReceipt(transaction) ? ReceiptUtils.getThumbnailAndImageURIs(transaction.receipt.source, transaction.filename) : {};

to

const {thumbnail} = TransactionUtils.hasReceipt(transaction) ? ReceiptUtils.getThumbnailAndImageURIs(transaction) : {};

[MariaHCD]

Oh, it looks like we missed updating the usage of ReceiptUtils.getThumbnailAndImageURIs.

@tienifr's proposal looks good. @tienifr will you be able to prioritize a fix for this one since it's a deploy blocker? 🙏🏼

[ntdiary]

Oh, it looks like we missed updating the usage of ReceiptUtils.getThumbnailAndImageURIs.

@tienifr's proposal looks good. @tienifr will you be able to prioritize a fix for this one since it's a deploy blocker? 🙏🏼

Totally agree, @tienifr, can you please raise a PR soon?

[tienifr]

@ntdiary @MariaHCD yes i can

[tienifr]

will raise the PR in few mins

[melvin-bot]

📣 @ntdiary 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tienifr]

The PR #29863 is up

[melvin-bot]

🎯 ⚡️ Woah @ntdiary / @tienifr, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @tienifr got assigned: 2023-10-18 13:30:04 Z
• when the PR got merged: 2023-10-18 14:57:13 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 29850 IOU-Tapping on distance receipt, the receipt thumbnail is missing in the receipt page #29863

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment offer (Reviewer)
• @tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 29850 IOU-Tapping on distance receipt, the receipt thumbnail is missing in the receipt page #29863

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ntdiary requires payment offer (Reviewer)
• @tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR:
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ntdiary] Determine if we should create a regression test for this bug.
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ntdiary]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ntdiary] The PR that introduced the bug has been identified. Link to the PR: [Wave 8 - ECard Transactions] Show EReceipts in ReportPreviews and Attachment View #29474
• [@ntdiary] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: aa07b9c#r130409202
• [@ntdiary] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• [@ntdiary] Determine if we should create a regression test for this bug. No need
• [@ntdiary] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No need
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Just a minor fix. No regression test is required, and this conflictless merge case has already been discussed in that PR. : )

[isabelastisser]

Thanks @ntdiary!

Holding for payment on Oct 27.

[isabelastisser]

I processed the payments in Upwork. All set!