[HOLD for payment 2023-10-27][$500] Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt #29855

izarutskaya · 2023-10-18T11:32:16Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Issue found when executing PR: #29474

Version Number: v1.3.86-1

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

Go to staging.new.expensify.com
Go to chat > + > Request money > Manual.
Enter amount and proceed to confirmation page.
Click 3-dot menu > Add receipt.
Select a receipt.

Expected Result:

The receipt will appear in the preview in the confirmation page.

Actual Result:

The preview in the confirmation page shows the attachment placeholder instead of the receipt.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6241508_1697620648971.20231018_101020.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c60a9f52756a7c9e
Upwork Job ID: 1714605323478552576
Last Price Increase: 2023-10-18
Automatic offers:

fedirjh | Reviewer | 27261363
c3024 | Contributor | 27261368

melvin-bot · 2023-10-18T11:32:21Z

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-18T11:32:22Z

Job added to Upwork: https://www.upwork.com/jobs/~01c60a9f52756a7c9e

melvin-bot · 2023-10-18T11:32:23Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-18T11:32:28Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

izarutskaya · 2023-10-18T11:34:12Z

Not repro in production

bandicam.2023-10-18.15-36-18-490.mp4

OSBotify · 2023-10-18T11:40:54Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-10-18T11:40:58Z

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

c3024 · 2023-10-18T13:39:52Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Image is not shown in confirm page when creating a scan money request

What is the root cause of that problem?

We get the image and thumbnail from here

App/src/components/MoneyRequestConfirmationList.js

Line 539 in 39d2a84

    
           const {image: receiptImage, thumbnail: receiptThumbnail} = props.receiptPath && props.receiptFilename ? ReceiptUtils.getThumbnailAndImageURIs(transaction) : {};

but when we have not created the transaction yet there is no source or file name for the transaction and this returns this

App/src/libs/ReceiptUtils.ts

Line 64 in 39d2a84

return {thumbnail: null, image};

and the image is generic image here

App/src/libs/ReceiptUtils.ts

Line 51 in 39d2a84

let image = ReceiptGeneric;

What changes do you think we should make in order to solve the problem?

We should check if the transaction does not have a source and we should get the image and thumbnail with iou receiptPath and filename
So we change this code

App/src/components/MoneyRequestConfirmationList.js

Line 539 in 39d2a84

    
           const {image: receiptImage, thumbnail: receiptThumbnail} = props.receiptPath && props.receiptFilename ? ReceiptUtils.getThumbnailAndImageURIs(transaction) : {};

to something like this

if (!transaction.source) {
    const uris = props.receiptPath && props.receiptFilename 
        ? ReceiptUtils.getThumbnailAndImageURIsFromIOU(props.receiptPath, props.receiptFilename)
        : {};

    receiptImage = uris.image;
    receiptThumbnail = uris.thumbnail;
} else {
    const uris = props.receiptPath && props.receiptFilename 
        ? ReceiptUtils.getThumbnailAndImageURIs(transaction)
        : {};

    receiptImage = uris.image;

and add the function which we were using earlier in ReceiptUtils like this

function getThumbnailAndImageURIsFromIOU(path: string, filename: string): ThumbnailAndImageURI {
    const isReceiptImage = Str.isImage(filename);

    // For local files, we won't have a thumbnail yet
    if (isReceiptImage && (path.startsWith('blob:') || path.startsWith('file:'))) {
        return {thumbnail: null, image: path};
    }

    if (isReceiptImage) {
        return {thumbnail: `${path}.1024.jpg`, image: path};
    }

    const {fileExtension} = FileUtils.splitExtensionFromFileName(filename) as FileNameAndExtension;
    let image = ReceiptGeneric;
    if (fileExtension === CONST.IOU.FILE_TYPES.HTML) {
        image = ReceiptHTML;
    }

    if (fileExtension === CONST.IOU.FILE_TYPES.DOC || fileExtension === CONST.IOU.FILE_TYPES.DOCX) {
        image = ReceiptDoc;
    }

    if (fileExtension === CONST.IOU.FILE_TYPES.SVG) {
        image = ReceiptSVG;
    }

    return {thumbnail: null, image};
}

We can move all this common code into a helper function

    if (isReceiptImage && (path.startsWith('blob:') || path.startsWith('file:'))) {
        return {thumbnail: null, image: path};
    }

    if (isReceiptImage) {
        return {thumbnail: `${path}.1024.jpg`, image: path};
    }

    const {fileExtension} = FileUtils.splitExtensionFromFileName(filename) as FileNameAndExtension;
    let image = ReceiptGeneric;
    if (fileExtension === CONST.IOU.FILE_TYPES.HTML) {
        image = ReceiptHTML;
    }

    if (fileExtension === CONST.IOU.FILE_TYPES.DOC || fileExtension === CONST.IOU.FILE_TYPES.DOCX) {
        image = ReceiptDoc;
    }

    if (fileExtension === CONST.IOU.FILE_TYPES.SVG) {
        image = ReceiptSVG;
    }

    return {thumbnail: null, image};

and use it both for getting image and thumbnail from transaction or iou

What alternative solutions did you explore? (Optional)

We can pass props.receiptPath, props.receiptFilename to
ReceiptUtils.getThumbnailAndImageURIs(transaction) here

App/src/components/MoneyRequestConfirmationList.js

Line 539 in 1c051fe

    
           const {image: receiptImage, thumbnail: receiptThumbnail} = props.receiptPath && props.receiptFilename ? ReceiptUtils.getThumbnailAndImageURIs(transaction) : {};

as
ReceiptUtils.getThumbnailAndImageURIs(transaction, props.receiptPath, props.receiptFilename) and change params of getThumbnailAndImageURIs in ReceiptUtils to (transaction, receiptPath, receiptFileName) and these lines in getThumbnailAndImageURIs to

const path = transaction?.receipt?.source || receiptPath || '' ;
    // filename of uploaded image or last part of remote URI
    const filename = transaction?.filename || receiptFilename || '';

fedirjh · 2023-10-18T13:45:30Z

@c3024 Can you please link which PR has introduced this bug?

melvin-bot · 2023-10-18T13:49:06Z

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

cristipaval · 2023-10-18T13:51:45Z

@fedirjh I think this PR introduced this regression, and @youssef-lr reported it already here

cristipaval · 2023-10-18T13:53:19Z

#29794 which changed the passing of receipt file and name to the getThumbnailAndImageURIs to passing transaction as parameter

@c3024 I think you copy-pasted the wrong PR, didn't you?

c3024 · 2023-10-18T13:54:54Z

Yes. Sorry #29474 it is.

melvin-bot · 2023-10-18T23:49:29Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-18T23:49:32Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

get image from IOU when there is no source in transaction #29873

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@fedirjh requires payment offer (Reviewer)
@c3024 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-18T23:49:34Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-20T20:58:31Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

get image from IOU when there is no source in transaction #29873

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@fedirjh requires payment offer (Reviewer)
@c3024 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-20T20:58:33Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

fedirjh · 2023-10-26T22:52:52Z

BugZero Checklist:

Link to the PR: [Wave 8 - ECard Transactions] Show EReceipts in ReportPreviews and Attachment View #29474
Link to comment: [Wave 8 - ECard Transactions] Show EReceipts in ReportPreviews and Attachment View #29474 (comment)
Link to discussion: N/A should be caught during testing.
Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

Click on FAB > Request Money > Manual
Input an amount and click Next
Enter/select an option for the request
Click on the three-dot menu at the top right
Click on "Add Receipt"
Click on "Choose File" and Select an image
Verify that the image is shown as a receipt

Do we agree 👍 or 👎

melvin-bot · 2023-10-30T12:54:18Z

@garrettmknight, @cristipaval, @fedirjh, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

cristipaval · 2023-10-30T17:13:43Z

[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@garrettmknight , could you please create a GH issue with the regression steps suggested by @fedirjh in the previous comment?

garrettmknight · 2023-10-30T19:14:16Z

Done!

Summary of payments:

Urgency bonus: Yes
Contributor: @c3024 750 paid via Upwork
Reviewer: @fedirjh $750 paid via Upwork

mallenexpensify · 2024-01-15T23:21:45Z

Is this the same issue?
https://expensify.slack.com/archives/C049HHMV9SM/p1705360701588059

garrettmknight · 2024-01-16T19:25:20Z

Planned here: #31432

izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 18, 2023

melvin-bot bot assigned garrettmknight Oct 18, 2023

melvin-bot bot changed the title ~~Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt~~ [$500] Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt Oct 18, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 18, 2023

melvin-bot bot assigned fedirjh Oct 18, 2023

github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 18, 2023

OSBotify mentioned this issue Oct 18, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

melvin-bot bot assigned cristipaval Oct 18, 2023

cristipaval mentioned this issue Oct 18, 2023

The receipt image is not displaying on the confirmation modal #29864

Closed

6 tasks

This comment was marked as outdated.

Sign in to view

This was referenced Oct 18, 2023

[HOLD for payment 2023-10-25] [ECARD] CRITICAL: Transactions - Link eReceipt Page to Receipt Preview #28829

Closed

[HOLD for payment 2023-10-25] [ECard Transactions] Update Report Preview Logic to support rendering JSX #28830

Closed

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 18, 2023

melvin-bot bot changed the title ~~[$500] Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt~~ [HOLD for payment 2023-10-25] [$500] Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt Oct 18, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 18, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 20, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 25, 2023

fedirjh mentioned this issue Oct 26, 2023

[Wave 8 - ECard Transactions] Show EReceipts in ReportPreviews and Attachment View #29474

Merged

70 tasks

melvin-bot bot added the Overdue label Oct 30, 2023

melvin-bot bot removed the Overdue label Oct 30, 2023

garrettmknight closed this as completed Oct 30, 2023

mallenexpensify reopened this Jan 15, 2024

melvin-bot bot added the Overdue label Jan 15, 2024

garrettmknight closed this as completed Jan 16, 2024

melvin-bot bot removed the Overdue label Jan 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-27][$500] Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt #29855

[HOLD for payment 2023-10-27][$500] Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt #29855

izarutskaya commented Oct 18, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

izarutskaya commented Oct 18, 2023

OSBotify commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

c3024 commented Oct 18, 2023 •

edited

Loading

fedirjh commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

This comment was marked as outdated.

cristipaval commented Oct 18, 2023 •

edited

Loading

cristipaval commented Oct 18, 2023

c3024 commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 20, 2023

melvin-bot bot commented Oct 20, 2023

fedirjh commented Oct 26, 2023

melvin-bot bot commented Oct 30, 2023

cristipaval commented Oct 30, 2023

garrettmknight commented Oct 30, 2023

mallenexpensify commented Jan 15, 2024

garrettmknight commented Jan 16, 2024

[HOLD for payment 2023-10-27][$500] Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt #29855

[HOLD for payment 2023-10-27][$500] Manual - Attachment placeholder is shown in preview instead of receipt after adding a receipt #29855

Comments

izarutskaya commented Oct 18, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 18, 2023

izarutskaya commented Oct 18, 2023

OSBotify commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

c3024 commented Oct 18, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

fedirjh commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

This comment was marked as outdated.

cristipaval commented Oct 18, 2023 • edited Loading

cristipaval commented Oct 18, 2023

c3024 commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 18, 2023

melvin-bot bot commented Oct 20, 2023

melvin-bot bot commented Oct 20, 2023

fedirjh commented Oct 26, 2023

BugZero Checklist:

melvin-bot bot commented Oct 30, 2023

cristipaval commented Oct 30, 2023

garrettmknight commented Oct 30, 2023

mallenexpensify commented Jan 15, 2024

garrettmknight commented Jan 16, 2024

izarutskaya commented Oct 18, 2023 •

edited by melvin-bot bot

Loading

c3024 commented Oct 18, 2023 •

edited

Loading

cristipaval commented Oct 18, 2023 •

edited

Loading