[Wave 6: Workspace Chats] Ensure we set notification preference to always when non owner comments on expense/ iou report

[mountiny]

Coming from here https://github.com/Expensify/Auth/pull/8930#discussion_r1362848109

During writing a new tests for the notification preference set to Hidden for expense/ iou report, it shows that if requestor request money from a payer and payer comments on the expense report, we do not change the notification settings to always for the requestor hence the report does not show up in their LHN.

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

Sorry for the ping

[puneetlath]

Yeah I think this would be the same for threads. If I type a comment in a room and then you respond to it in thread, I should get notified. Similarly, if I create an expense report/IOU/transaction and you comment on it, I should get notified.

[mountiny]

Stil holding for post conference here

[mountiny]

Soon will be resumed

[melvin-bot]

@mountiny this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mountiny]

Still not the main priority

[puneetlath]

This is being handled in https://github.com/Expensify/Auth/pull/9145

[melvin-bot]

@mountiny this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[mountiny]

Soon should be merged

[melvin-bot]

@mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

same same

[melvin-bot]

@mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

We are close to getting the PR from Jasper merged then we will follow with this one shortly after

[melvin-bot]

@mountiny Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mountiny]

Jasper's Pr is merged so we can continue with this one now

[puneetlath]

This is done too right @mountiny?

[mountiny]

yes that was added, I think its not happening in case of transaction thread still though

[puneetlath]

Ah ok, so we need to leave this open to handle transaction threads. Got it.

[puneetlath]

Created an issue for transaction threads here: https://github.com/Expensify/Expensify/issues/344458

[mountiny]

Thanks!