[TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript #29988

MaciejSWM · 2023-10-19T15:03:36Z

Details

Fixed Issues

$ #25010
PROPOSAL:

Tests

In DisplayNamePage.js add an early return:

    return (
        <FullScreenLoadingIndicator style={styles.flex1} />
    )

Then visit http://localhost:8082/settings/profile/display-name
You should see FullScreenLoadingIndicatorrendering a fullscreen spinner

Offline tests

Same as Tests

QA Steps

Visit http://localhost:8082/settings/profile/display-name - it will briefly show loading spinner before showing the content

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-20.at.14.01.31.mov

Android: mWeb Chrome

Screen.Recording.2023-10-20.at.11.31.49.mov

iOS: Native

Screen.Recording.2023-10-20.at.11.27.27.mov

iOS: mWeb Safari

Screen.Recording.2023-10-20.at.11.30.43.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-20.at.11.30.15.mov

MacOS: Desktop

Screen.Recording.2023-10-20.at.11.24.08.mov

blazejkustra · 2023-10-23T16:28:15Z

src/components/FullscreenLoadingIndicator.tsx

+        </View>
+    );
+}
+


We should always define displayName:

Suggested change

FullScreenLoadingIndicator.displayName = 'FullScreenLoadingIndicator';

blazejkustra · 2023-10-23T16:31:46Z

src/components/FullscreenLoadingIndicator.tsx

+import themeColors from '../styles/themes/default';
+
+type FullScreenLoadingIndicatorProps = {
+    style: Record<string, unknown> | Array<Record<string, unknown>>;


I would consider more accurate type here:

Suggested change

style: Record<string, unknown> | Array<Record<string, unknown>>;

style: StyleProp<ViewStyle>

fabioh8010

@MaciejSWM Please update the PR title to [TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript, we should have this one tested by QA.

src/components/FullscreenLoadingIndicator.tsx

Co-authored-by: Fábio Henriques <[email protected]>

melvin-bot · 2023-10-26T13:26:53Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cubuspl42 · 2023-10-26T13:44:09Z

src/components/FullscreenLoadingIndicator.tsx

+
+function FullScreenLoadingIndicator({style}: FullScreenLoadingIndicatorProps) {
+    return (
+        <View style={[StyleSheet.absoluteFillObject, styles.fullScreenLoading, style]}>


Hm, so passing a style array here just works? Was the old logic unnecessary?

const additionalStyles = _.isArray(props.style) ? props.style : [props.style];

@MaciejSWM Let's ensure this change was intended

Turns out it works just fine. It's not only correct Typescript, but it also works when I test it with all the combinations of style:
http://localhost:8082/settings/profile/display-name
In DisplayNamePage.js (I renamed it to .tsx to highlight any errors, but none showed up):

{!props.isLoadingApp ? ( <> <View style={{ height: '20%' }}> {/* No style */} <FullScreenLoadingIndicator /> </View> <View style={{ height: '20%' }}> {/* Empty array style */} <FullScreenLoadingIndicator style={[]} /> </View> <View style={{ height: '20%' }}> {/* Just one style */} <FullScreenLoadingIndicator style={styles.backgroundPurple} /> </View> <View style={{ height: '20%' }}> {/* Array of styles */} <FullScreenLoadingIndicator style={[styles.backgroundPurple, styles.backgroundGold]} /> </View> </> ) : (

Thanks for verifying this!

cubuspl42 · 2023-10-26T13:47:07Z

We are over 1000 commits behind main; please merge it.

Even if there are no Git conflicts on the textual level, such diversion can:

create lint issues on main
result in bugs

In the case of this specific PR, we would probably get only a textual conflict (as it deletes a file), but 1000 commits is still a lot.

cubuspl42 · 2023-10-26T13:56:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

FullscreenLoadingIndicator-ts-web.mp4

Mobile Web - Chrome

FullscreenLoadingIndicator-ts-android-web-compressed.mp4

Mobile Web - Safari

FullscreenLoadingIndicator-ts-ios-web.mp4

Desktop

iOS

FullscreenLoadingIndicator-ts-ios.mp4

Android

FullscreenLoadingIndicator-ts-android-compressed.mp4

MaciejSWM · 2023-10-27T13:13:14Z

@cubuspl42 thanks for pointing out valid concerns. Branch is up to date now + I addressed your question about getting rid of const additionalStyles = _.isArray(props.style) ? props.style : [props.style];

melvin-bot · 2023-10-30T08:07:50Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25010 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

AndrewGable

Please write QA steps

MaciejSWM · 2023-11-02T15:37:39Z

@AndrewGable updated

OSBotify · 2023-11-02T16:10:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:33:58Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:51:31Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:48:27Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

MaciejSWM added 3 commits October 19, 2023 16:20

WIP

bd2274c

Drop func from possible types

8d4678f

Merge branch 'main' into ts-migration/FullscreenLoadingIndicator

f0c4e89

blazejkustra suggested changes Oct 23, 2023

View reviewed changes

blazejkustra mentioned this pull request Oct 23, 2023

[TS migration] Migrate 'SelectCircle.js' component to TypeScript #30077

Merged

63 tasks

MaciejSWM added 3 commits October 23, 2023 19:49

Restore displayName

512c4d5

Use ViewStyle

7044bbb

Drop not needed casting

1088ada

blazejkustra approved these changes Oct 24, 2023

View reviewed changes

fabioh8010 reviewed Oct 25, 2023

View reviewed changes

src/components/FullscreenLoadingIndicator.tsx Outdated Show resolved Hide resolved

MaciejSWM changed the title ~~[No QA][TS migration] Migrate FullscreenLoadingIndicator~~ [TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript Oct 25, 2023

Make style prop optional

653f4d4

Co-authored-by: Fábio Henriques <[email protected]>

MaciejSWM requested a review from fabioh8010 October 25, 2023 19:29

fabioh8010 approved these changes Oct 26, 2023

View reviewed changes

Drop default value - undefined works too

0a8911c

MaciejSWM marked this pull request as ready for review October 26, 2023 13:26

MaciejSWM requested a review from a team as a code owner October 26, 2023 13:26

melvin-bot bot requested review from cubuspl42 and removed request for a team October 26, 2023 13:26

cubuspl42 reviewed Oct 26, 2023

View reviewed changes

Merge branch 'main' into ts-migration/FullscreenLoadingIndicator

64ae232

MaciejSWM requested a review from cubuspl42 October 27, 2023 13:13

cubuspl42 approved these changes Oct 30, 2023

View reviewed changes

melvin-bot bot requested a review from AndrewGable October 30, 2023 08:07

Merge branch 'main' into ts-migration/FullscreenLoadingIndicator

0fd6982

AndrewGable requested changes Oct 31, 2023

View reviewed changes

MaciejSWM requested a review from AndrewGable November 2, 2023 15:37

AndrewGable approved these changes Nov 2, 2023

View reviewed changes

AndrewGable merged commit a2bd366 into Expensify:main Nov 2, 2023
14 checks passed

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

cubuspl42 mentioned this pull request Nov 27, 2023

[$250] [TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript #25010

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript #29988

[TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript #29988

MaciejSWM commented Oct 19, 2023 •

edited

Loading

blazejkustra Oct 23, 2023

blazejkustra Oct 23, 2023

fabioh8010 left a comment

melvin-bot bot commented Oct 26, 2023

cubuspl42 Oct 26, 2023

cubuspl42 Oct 27, 2023

MaciejSWM Oct 27, 2023 •

edited

Loading

cubuspl42 Oct 30, 2023

cubuspl42 commented Oct 26, 2023

cubuspl42 commented Oct 26, 2023

MaciejSWM commented Oct 27, 2023

melvin-bot bot commented Oct 30, 2023

AndrewGable left a comment

MaciejSWM commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023


	FullScreenLoadingIndicator.displayName = 'FullScreenLoadingIndicator';

	style: Record<string, unknown> \| Array<Record<string, unknown>>;
	style: StyleProp<ViewStyle>

[TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript #29988

[TS migration] Migrate 'FullscreenLoadingIndicator.js' component to TypeScript #29988

Conversation

MaciejSWM commented Oct 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

blazejkustra Oct 23, 2023

Choose a reason for hiding this comment

blazejkustra Oct 23, 2023

Choose a reason for hiding this comment

fabioh8010 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 26, 2023

cubuspl42 Oct 26, 2023

Choose a reason for hiding this comment

cubuspl42 Oct 27, 2023

Choose a reason for hiding this comment

MaciejSWM Oct 27, 2023 • edited Loading

Choose a reason for hiding this comment

cubuspl42 Oct 30, 2023

Choose a reason for hiding this comment

cubuspl42 commented Oct 26, 2023

cubuspl42 commented Oct 26, 2023

Reviewer Checklist

Screenshots/Videos

MaciejSWM commented Oct 27, 2023

melvin-bot bot commented Oct 30, 2023

AndrewGable left a comment

Choose a reason for hiding this comment

MaciejSWM commented Nov 2, 2023

OSBotify commented Nov 2, 2023

OSBotify commented Nov 6, 2023

OSBotify commented Nov 9, 2023

OSBotify commented Nov 10, 2023

MaciejSWM commented Oct 19, 2023 •

edited

Loading

MaciejSWM Oct 27, 2023 •

edited

Loading