Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Task- Assignee selected is not updated in real time in user A task detail page for sub task #30015

Closed
3 of 6 tasks
lanitochka17 opened this issue Oct 19, 2023 · 25 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.87-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch app as User A
  2. Tap fab
  3. Tap Assign task
  4. Enter a title
  5. Tap next
  6. Share task to User B
  7. Confirm task (stay in task detail page in one device)
  8. Open User B account in other device
  9. From LHN, tap the task displayed in bold
  10. Tap on task to open task detail page
  11. Tap plus icon near compose
  12. Tap assign task
  13. Create a sub task by entering a title
  14. Tap next
  15. Tap confirm task and note the sub task created is shown in user A task page
  16. Tap assignee and select assign task to me and note the User A task detail page

Expected Result:

The assignee selected must be updated in real time in user A task detail page

Actual Result:

The assignee selected is not updated in real time in user A task detail page. When user taps on task and tap header and revisit the page only assignee is updated and shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Bug6243418_1697740718079.Android_user.mp4

Uploading Bug6243418_1697740947925!android_user.mp4…

Android: mWeb Chrome
Bug6243418_1697740718062.video1_redmi.mp4
Bug6243418_1697740791106.video2.mp4
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015c5e0dff9ee32231
  • Upwork Job ID: 1715086100564701184
  • Last Price Increase: 2023-11-03
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 19, 2023
@melvin-bot melvin-bot bot changed the title Tas k- Assignee selected is not updated in real time in user A task detail page for sub task [$500] Tas k- Assignee selected is not updated in real time in user A task detail page for sub task Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~015c5e0dff9ee32231

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

@kevinksullivan, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

@kevinksullivan, @rushatgabhane Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@kevinksullivan kevinksullivan changed the title [$500] Tas k- Assignee selected is not updated in real time in user A task detail page for sub task [$1000] Tas k- Assignee selected is not updated in real time in user A task detail page for sub task Oct 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

Upwork job price has been updated to $1000

@kevinksullivan
Copy link
Contributor

Doubling price

@melvin-bot melvin-bot bot removed the Overdue label Oct 27, 2023
@barros001
Copy link
Contributor

barros001 commented Oct 27, 2023

@kevinksullivan This issue seems to be a BE issue rather than a front-end issue. See attached screen recording (iOS is User A, Web is User B). When adding a new sub-task, it does show up on User A immediately, as expected. But once you assign the task to yourself, note that the log screen is empty, meaning we received nothing from the pusher. No pusher data means no UI updates on User A. Once we finally assign the task to account A, we see pusher activity in the logs and the UI reflects the new assignment.

It appears that the BE will look at the sub-task and think it has nothing todo with User A. In fact, looking at it in isolation, it doesn't really. The link between the sub-task and User A is through the parent task. Maybe the BE is not taking that into account? It looks at the sub-task in isolation and ignore the parent relationship and therefore never pushes data to User A?

There's also another problem, at the end of the video. After assigning the sub-task to User A, if you later assign it to a 3rd user, User A UI will update, but it will clear the assignment instead of showing the 3rd user.

Either way, doesn't look like this can be fixed on the FE.

screen-recording.mov

@kbecciv kbecciv changed the title [$1000] Tas k- Assignee selected is not updated in real time in user A task detail page for sub task [$1000] Task- Assignee selected is not updated in real time in user A task detail page for sub task Oct 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 30, 2023

@kevinksullivan, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Oct 31, 2023

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2023
@kevinksullivan
Copy link
Contributor

Looping in engineering to confirm ^

Copy link

melvin-bot bot commented Nov 2, 2023

@madmax330 @kevinksullivan @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Nov 3, 2023
Copy link

melvin-bot bot commented Nov 3, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@madmax330
Copy link
Contributor

cc @thienlnam penny for your thoughts? Since you worked on the tasks implementation

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023
@thienlnam
Copy link
Contributor

thienlnam commented Nov 7, 2023

Ah yeah, this looks like we're not sending a pusher update to update the reportAction of the task parent on the assignee update - I can spin up a PR for this

EDIT: Wait, does this also happen for the task name? It seems like it would from looking at the code if User B has not opened the task yet

@melvin-bot melvin-bot bot added the Overdue label Nov 8, 2023
@madmax330
Copy link
Contributor

@thienlnam made the fix for this.

@melvin-bot melvin-bot bot removed the Overdue label Nov 8, 2023
@madmax330 madmax330 assigned thienlnam and unassigned madmax330 Nov 8, 2023
@madmax330 madmax330 added the Reviewing Has a PR in review label Nov 8, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

@kevinksullivan, @rushatgabhane, @thienlnam Still overdue 6 days?! Let's take care of this!

@thienlnam
Copy link
Contributor

Let's verify if this is still happening from the BE fix and if not we can close

Copy link

melvin-bot bot commented Nov 29, 2023

@kevinksullivan, @rushatgabhane, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Nov 30, 2023

@kevinksullivan, @rushatgabhane, @thienlnam Huh... This is 4 days overdue. Who can take care of this?

@kevinksullivan
Copy link
Contributor

Any update @thienlnam ?

@thienlnam
Copy link
Contributor

@lanitochka17 Could we please get this one retested?

Copy link

melvin-bot bot commented Dec 11, 2023

@kevinksullivan, @rushatgabhane, @thienlnam Eep! 4 days overdue now. Issues have feelings too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants