-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [$500] Concierge not highlights on login #30080
Comments
Triggered auto assignment to @dylanexpensify ( |
Job added to Upwork: https://www.upwork.com/jobs/~01a2ea61367ef9c991 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Concierge should be highlighted/selected after login What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?if What alternative solutions did you explore? (Optional) |
📣 @spectreintegrated! 📣
|
Contributor details |
|
Regression from #29268 We should return an empty string if none of the App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.js Lines 17 to 36 in 115974e
or the state is empty. App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.js Lines 18 to 20 in 115974e
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @hayata-suenaga ( |
@bernhardoj's solution looks good. I went ahead and created a PR since we might CP it this weekend to fix it before Money2020 on Monday. We should compensate @bernhardoj accordingly. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-30. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-31. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
payment upcoming! |
tomorrow, tomorrow, and tomorrow |
@luacmartins, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
just pending payment |
@bernhardoj mind applying: https://www.upwork.com/jobs/~01a2ea61367ef9c991 🙇♂️ |
Applied |
offer sent! |
done! |
@dylanexpensify reporting bonus is pending |
Payment done for this issue, thanks! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: Dev 1.3.87.0
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697780051399049
Action Performed:
Expected Result:
Concierge should be highlights in LHN and should show chats
Actual Result:
Concierge not highlights
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Screen_Recording_20231020_112258_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20231020_111801_Chrome.mp4
iOS: Native
RPReplay_Final1697781288.MP4
iOS: mWeb Safari
RPReplay_Final1697780959.MP4
MacOS: Chrome / Safari
Screen.Recording.2023-10-20.at.11.04.30.AM.mov
MacOS: Desktop
Screen.Recording.2023-10-20.at.11.08.13.AM.mov
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: