Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Currency - Dot (.) cannot be added into amount field if MRO currency selected #30136

Closed
6 tasks done
lanitochka17 opened this issue Oct 21, 2023 · 14 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 21, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.88-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Click on FAB> Request money> Manual
  3. Click Currency
  4. Select MRO
  5. Type any number and dot in amount field

Expected Result:

Dot (.) should be entered and seen into amount field

Actual Result:

Dot (.) cannot be added into amount field if MRO currency selected

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6245699_1697910316055.Recording__1291.mp4
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013d5909ed29d6d625
  • Upwork Job ID: 1715845386362593280
  • Last Price Increase: 2023-10-28
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 21, 2023
@melvin-bot melvin-bot bot changed the title Currency - Dot (.) cannot be added into amount field if MRO currency selected [$500] Currency - Dot (.) cannot be added into amount field if MRO currency selected Oct 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013d5909ed29d6d625

@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2023

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

@abdel-h66
Copy link
Contributor

Seems like this currency does not have decimals allowed. "decimals": 0,

{
    "symbol": "UM",
    "name": "Mauritania Ougulya",
    "decimals": 0,
    "retired": true,
    "retirementDate": "2018-07-11",
    "ISO4217": "478"
}

@peymancyb
Copy link

I do also confirm and agree with @abdel-h66, based on the current config, the currency does not accept decimals which is the reason of not being able to use (.).

=> View currencyList.json

fix.mov

@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2023

📣 @peymancyb! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@peymancyb
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~015502e3fbe636dad6

@melvin-bot
Copy link

melvin-bot bot commented Oct 21, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@shubham1206agra
Copy link
Contributor

This is what I got

The Mauritanian Ouguiya (MRO) is the official currency of Mauritania. In the context of currency, you typically cannot have less than 1 unit of the currency in a monetary transaction. The Ouguiya is subdivided into smaller units, with the most common denominations being the ouguiya and the khoums. One ouguiya is equivalent to 5 khoums.

So, for practical purposes, in monetary transactions, you would typically deal with whole numbers of ouguiyas or khoums, and amounts are not expressed as fractions of an ouguiya. For example, you might have 10 ouguiyas or 50 khoums, but you wouldn't typically have something like "0.5 MRO" in a standard transaction.

@burczu
Copy link
Contributor

burczu commented Oct 24, 2023

@dylanexpensify I've just checked what @shubham1206agra wrote in their comment and it seems to be kinda correct - in Mauritania there is only one coin that is less than 1 Ouguiya called Khoum which is 1/5 of Ouguiya. That's why, I guess, we have decimals disabled in the App for MRO currency, because it would hard to deal with it.

So I think this may not be a bug, actually.

@melvin-bot melvin-bot bot added the Overdue label Oct 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

@burczu, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@dylanexpensify
Copy link
Contributor

agree! thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

6 participants