[$1000] IOU - Preview IOU disappears at the end of the conversation after requesting it

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.88.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open New Expensify app
2. Log in with an expensifail account
3. Navigate to or create a conversation with any participant
4. In the conversation, send an IOU to the user
5. Send multiple messages of any kind to the same user
6. Re-send an IOU to the same user in a conversation.

Expected Result:

The IOU preview should not disappear from its place. There should be an item in the correct place in the chat history for each IOU. The last such item should have a more expanded IOU preview component with a pay button, showing the total debt from all IOU requests on the report.

Actual Result:

The IOU preview disappears at the end of the conversation after a request and reappears in its old place in the conversation history

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6245891_1697924495755.Recording__573.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ee8a739c4993763c
• Upwork Job ID: 1716105961384960000
• Last Price Increase: 2023-12-04

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ee8a739c4993763c

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[cooldev900]

I am not reproducible on staging. Is it in production?

[c3024]

Is this a bug? All IOUs are merged and made into a single IOU preview. Looks like expected behaviour.

[goldendragon430]

Hi, I checked this bug but I didn't find issues like video.
I think this is no problem,

[melvin-bot]

📣 @goldendragon430! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[goldendragon430]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01598019cf72f02b90

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[goldendragon430]

Hi, I checked this bug but I didn't find issues like video.
I think this is no problem,

[andriishupta]

Hello

I also couldn't reproduce it. Even tried with "Slow 3G" / "Offline mode" - it works without issues

[melvin-bot]

📣 @andriishupta! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[andriishupta]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~019cf579f0a0b7082a

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[paultsimura]

May be related to (or a dupe of) #29607 (comment)

[Christinadobrzyn]

asking in #29607 if this will be fixed with that job

[roryabraham]

Is this a bug? All IOUs are merged and made into a single IOU preview. Looks like expected behaviour.

I think we should have only a single IOU preview with a pay button but I think there should be an IOU message in the correct place in the chat history when the original amount was requested. So the video looks not quite right

[Christinadobrzyn]

May be related to (or a dupe of) #29607 (comment)

@roryabraham confirmed this is different. It is reproducible.

So basically it sounds like we want the IOUs to always be anchored at the bottom of the chat thread, is that correct @roryabraham?

[roryabraham]

So basically it sounds like we want the IOUs to always be anchored at the bottom of the chat thread

not exactly. There should be an item in the correct place in the chat history for each IOU. The last such item should have a more expanded IOU preview component with a pay button, showing the total debt from all IOU requests on the report

[Christinadobrzyn]

Thanks @roryabraham! We'll keep this open and are looking for proposals!

[roryabraham]

@Christinadobrzyn agreed for IOU payment actions. For previous requests I think it should be "You requested $20" or "Rory requested $20 (paid)"

[allroundexperts]

@cooldev900 Thanks for your proposal. Your proposal seems correct but I think @paultsimura's proposal is more simpler than yours and does not rely on storing / creating new IOU keys. As such, I think we should go with there proposal.

I would also agree with both of you that backend changes are needed for this so we add the plaintext version of the previous requests inside the chat report. @roryabraham Could you make those changes?

In the meantime, we can fix this for the optimistic case from the frontend. If any discrepancies come up after backend changes are in, we can deal with those in a followup issue.

@roryabraham Again, let us know if you agree with above.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[grgia]

@roryabraham bump on #30147 (comment)

@allroundexperts That said, I think if a solution requires backend changes at all, the issue should be made internal

[melvin-bot]

Current assignee @allroundexperts is eligible for the Internal assigner, not assigning anyone new.

[Christinadobrzyn]

ah sorry - I made this internal @allroundexperts let me know if you think it can remain External

[allroundexperts]

I'm not sure to be honest. I've seen a lot of issues that are external but require backend changes as well.

[Christinadobrzyn]

I think this could maybe be folded into our VIP - Split P2P Chat Groups so maybe we should keep this internal and then see if this could be resolved as part of that VIP.

@GabiHExpensify could you review this GH and see if it's something that could be tied into the Split P2P VIP?

This could also maybe be part of Wave 7 since Split is involved there too. cc @RachCHopkins

[melvin-bot]

@allroundexperts, @MitchExpensify, @grgia, @Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@allroundexperts, @MitchExpensify, @grgia, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

Asking if this fits into Wave 7 - https://expensify.slack.com/archives/C02NZ2HGJAZ/p1702937923040459

[grgia]

@allroundexperts What BE changes would be required for this in the case we went with your suggested proposal?

[allroundexperts]

@grgia currently, in a chat report, we have a single action of type REPORTPREVIEW. This action has a summary of all the IOU actions included in that IOU report. With the above proposals, we will need to store each individual item of the IOU report inside the chat report instead of just having a single item with a summary of the IOU report.

[youssef-lr]

This is not reproducible anymore. Also, note that in the recording of the issue the total number of requests goes from 7 to 6, that's when the REPORTPREVIEW moves up, then gets back to 7 and it moves down to the correct position.

Screen.Recording.2023-12-20.at.19.46.26.mov

Can we try reproducing this again please?

[roryabraham]

Sorry for the delay in responding. I know I recently fixed and issue where the IOU preview jumps to the wrong place in the chat history.

It might be the case that a plaintext record of the original request is actually a new feature not a bug / scope creep, but it definitely makes sense to me and I think I recall seeing it in mockups way back when.

Maybe need to ask for clarification in slack

[roryabraham]

Slack discussion: https://expensify.slack.com/archives/C03U7DCU4/p1703104272565009

[roryabraham]

Ok, it sounds like the plaintext record of the IOU actions in the chat report is not currently expected / would be a new feature. Currently that stuff is tracked in the money request report (IOU/Expense report), but not in the chat report. The chat report only ever has 0 or 1 report preview actions, which move around in the history.

The original bug has been fixed here, and this is not a feature request to include more records in the chat report, so I'm going to close this.

[roryabraham]

For future context – we're eventually planning to have a record of IOU actions in the parent report (i.e: the chat report), but it's blocked on comment linking. When we have comment linking implemented, then we'll be able to post a link to IOU actions as a plaintext comment in the parent action (codename "post to parent" or "push to parent"). I think that's planned somewhere

[brunovjk]

Is this the same issue?