-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] [HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] Web - Drag and drop feature works on Scan and Distance request money #30148
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @amyevans ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Drag and drop available for distance request as well What is the root cause of that problem?We are subscribing to incorrect key here withOnyx({
selectedTab: {
key: `${ONYXKEYS.SELECTED_TAB}_${CONST.TAB.RECEIPT_TAB_ID}`,
},
}), What changes do you think we should make in order to solve the problem?We should subscribe to selectedTab: {
key: `${ONYXKEYS.COLLECTION.SELECTED_TAB}${CONST.TAB.RECEIPT_TAB_ID}`,
}, What alternative solutions did you explore? (Optional) |
regression from #26149 |
@dukenv0307 are you able to raise quick PR? |
We merged a fix already |
Triggered auto assignment to @alexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Gonna have to pay 25% to @c3024 so $125 for their help! Thanks @alexpensify |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-30. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
(Oops, posted in wrong issue, sorry) |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-31. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Gonna have to pay 25% to @c3024 so $125 for their help! Thanks @alexpensify |
Cool, the payment date is 10-31! I'll prepare for that date. |
Job added to Upwork: https://www.upwork.com/jobs/~011ae828d7f55c050d |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 ( |
@narefyev91 - disregard this one. I needed to create an Upwork job. |
@c3024 - to prepare for the payment date, can you please apply to this Upwork job: https://www.upwork.com/jobs/~011ae828d7f55c050d Thanks! |
Applied. Thanks @alexpensify |
@c3024 - thanks, I sent an offer in Upwork. |
Accepted. |
Done! I've finished the payment process in Upwork. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.3.88.3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Drag and drop feature works on Scan and Distance request money
Actual Result:
Drag and drop feature works on Scan and Distance request money
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Recording.575.mp4
Recording.5104.mp4
MacOS: Desktop
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: