[HOLD] [ECARD] HIGH: Create "Mark as Done" button for non-refundable Expense reports in NewDot

[Gonals]

Coming from this issue.

In the "Mark as Done" case, we'll need more than just a copy change, as we'll need to update the behavior to set the report to "Closed" (Not "Reimbursed") and will need to update NewDot to handle these closed reports correctly (it currently doesn't load them).

Full slack convo here, but the plan is to:

• Change copy to Mark as done following the design
• When that’s the case, change behavior to call a new ’MarkAsDone” command. Basically Pay elsewhere, but setting the State and Status to 2
• Update Newdot in general to not explode with “Closed” Expense reports

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016e6a3dc0eb317b11
• Upwork Job ID: 1716828437684563968
• Last Price Increase: 2023-10-24

Issue Owner

Current Issue Owner: @Gonals

[melvin-bot]

Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016e6a3dc0eb317b11

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @shubham1206agra (Internal)

[alexpensify]

To confirm, @Gonals are you working on the update and @shubham1206agra would be the reviewer? Thanks for confirming the next steps!

[Gonals]

Yep! This goes across our stack, though, so it'll be 3 PR (plus, probably, extras to fix what I forget 😆)

[Gonals]

Update:
I'm close to done, but something is broken with Money requests (they are created for twice the amount and the behavior is wonky).
I'l re-tackle this after I come back from OOO

[alexpensify]

I think @Gonals is still OOO

[Gonals]

I think @Gonals is still OOO

Nope! I'm back!

[alexpensify]

@dylanexpensify - it looks like @Gonals has everything under control here. Flagging that I will be OOO until Tuesday. If anything is urgent on the BZ side, I maybe need to tap you in for help. Thanks!

[dylanexpensify]

You got it @alexpensify! 👀 on it!

[alexpensify]

Thank you @dylanexpensify!

[alexpensify]

@Gonals any update here?

[alexpensify]

@Gonals should we put this one on hold since the PR is on hold?

[melvin-bot]

This issue has not been updated in over 15 days. @alexpensify, @Gonals, @shubham1206agra eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[dylanexpensify]

bump @Gonals

[Gonals]

Yep, moving to HOLD. This functionality is likely going to be removed for free plans

[alexpensify]

Thanks for the update!

[kevinksullivan]

closing in favor of https://github.com/Expensify/Expensify/issues/340874