[$500] IOU- In distance request, user unable to edit amount

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.90-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

1. Launch app
2. Tap on a Workspace chat
3. Tap plus icon and select request money
4. Tap distance
5. Enter start and finish waypoints
6. Tap next
7. Tap on Amount

Expected Result:

When user taps on amount, he must be able to edit amount.

Actual Result:

When user taps on amount, it does not trigger any action and user unable to edit amount.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Bug6249551_1698192941447.bur.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0116de5be45e362471
• Upwork Job ID: 1717112900168441856
• Last Price Increase: 2023-10-25

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0116de5be45e362471

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In distance request, user unable to edit amount

What is the root cause of that problem?

We do nothing when clicking on amount item if the request is a distance request

App/src/components/MoneyRequestConfirmationList.js

Lines 593 to 595 in 6c87286

	if (props.isDistanceRequest) {
	return;
	}

App/src/components/MoneyRequestConfirmationList.js

Line 588 in 6c87286

shouldShowRightIcon={!props.isReadOnly && !props.isDistanceRequest}

What changes do you think we should make in order to solve the problem?

1. We can remove the distance request check for amount item here

App/src/components/MoneyRequestConfirmationList.js

Lines 593 to 595 in 6c87286

	if (props.isDistanceRequest) {
	return;
	}

2. And here

shouldShowRightIcon={!props.isReadOnly}

App/src/components/MoneyRequestConfirmationList.js

Line 588 in 6c87286

shouldShowRightIcon={!props.isReadOnly && !props.isDistanceRequest}

3. And if we are offline, we will display iou.amount if the amount is not empty instead of display common.tbd
   

   App/src/components/MoneyRequestConfirmationList.js

   Line 254 in 6c87286

   const formattedAmount = isDistanceRequestWithoutRoute

4. BE also should allow passing amount param in CreateDistanceRequest API and return the edit amount in transaction data.

What alternative solutions did you explore? (Optional)

If the expected is not able to edit the amount for distance request. We should disable navigate to edit mount page in MoneyRequestView and display not found page or dismiss the modal in EditRequestAmountPage if the request is distance request.

[brunovjk]

@izarutskaya, @dukenv0307 Should the user be able to change the value manually or just using distance?

I believe that this value is automatically calculated according to the ratio and distance entered.
The issue here is that the value is calculated once, and then when changing the starting or ending points, the value is not recalculated. There is already an issue about this, but it was closed as a dupe of #26946

Do you know anything about @cubuspl42?

[puneetlath]

I agree that this isn't a bug. It's intended that you can't change the amount of a distance expense directly.