[$500] Distance - Distance rate shows $TBD instead of TBD in offline mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.91-1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Precondition:

• There is at least a workspace
• Log out and log in again and do not open workspace and request money page

1. Navigate to staging.new.expensify.com
2. Go offline
3. Go to + > Request money > Distance
4. Enter any start and finish point
5. Proceed to the confirmation page
6. Go to the distance request (preview, details page)

Expected Result:

The distance rate shows TBD

Actual Result:

The distance rate shows $TBD instead of TBD

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6250523_1698251124492.20231025_125454.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ffaa57ea238f4625
• Upwork Job ID: 1717251966495088640
• Last Price Increase: 2023-10-25

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ffaa57ea238f4625

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate shows $TBD instead of TBD in offline mode

What is the root cause of that problem?

The distance rate is determined here where the currency symbol is attached to the ratePerUnit. However, the currency symbol is applied even when rate is not available. This is the root cause

What changes do you think we should make in order to solve the problem?

To solve the problem, we need to set the currencySymbol to empty string if rate is invalid like this:

const currencySymbol = rate ? CurrencyUtils.getCurrencySymbol(currency) || ${currency} : ‘’;

What alternative solutions did you explore? (Optional)

[GItGudRatio]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate shows $TBD instead of TBD in offline mode

What is the root cause of that problem?

To display the string present in the menu item, we use the getDistanceMerchant function.

App/src/libs/DistanceRequestUtils.js

Line 86 in 7393ec5

const getDistanceMerchant = (hasRoute, distanceInMeters, unit, rate, currency, translate, toLocaleDigit) => {

We always show the currency symbol, regardless of the rate, thus causing this bug.

What changes do you think we should make in order to solve the problem?

We need to consider if the rate is present an use the symbol only then. We can add a simple conditional to currencySymbol such that:

1. If the rate is present, show the currency symbol.
2. Else, do not show anything and use an empty string for symbol.
   

   App/src/libs/DistanceRequestUtils.js

   Line 94 in 7393ec5

   const currencySymbol = CurrencyUtils.getCurrencySymbol(currency) || `${currency} `;

What alternative solutions did you explore? (Optional)

[GItGudRatio]

Would just like to mention, isn't adding code diffs to the proposal against the proposal guidelines? I got delayed by a few seconds just because I was trying to word it out properly and adding the references instead of just pasting the code. Please do consider this when judging the proposals!

Thanks!

[Santhosh-Sellavel]

This is a simple and straightforward issue

@rojiphil's proposal looks good to me!

C+ Reviewed
🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Santhosh-Sellavel]

@GItGudRatio

I got delayed by a few seconds

These are bound to happen on simple issues, better luck next time.

Isn't adding code diffs to the proposal against the proposal guidelines

Yeah, large diffs without explaining the root cause. But I'm good with this as it's a relatively simpler one!

cc: @luacmartins

[rojiphil]

@Santhosh-Sellavel
PR is ready for review

[puneetlath]

According to QA this is still happening on iOS, so let's make sure it also gets fixed there.

[rojiphil]

According to QA this is still happening on iOS, so let's make sure it also gets fixed there.

@puneetlath

I am not able to reproduce the problem on the latest main (v1.3.97-1) with both iOS native and iOS mweb. Also, attaching the test videos for reference below. Maybe I am missing something simple here.

Not sure whom to approach in QA for reproducing the problem.
Can we get the QA to send a test video to demonstrate the problem on iOS?

30376-ios-native-2.mp4

30376-mweb-safari-2.mp4

[kavimuru]

@rojiphil I am not able to reproduce $TBD but I see the mileage rate in offline mode in the latest build.

MNFM7884.1.MP4

[rojiphil]

I am not able to reproduce $TBD but I see the mileage rate in offline mode in the latest build.

@kavimuru

Ok. Got it. I think the test description along with the precondition may help here. And sorry for the lack of clarity in the test steps.
I have updated that in the PR Test Section here.
Can you please try again along with the precondition?
Let me know if you still face problems.

[kavimuru]

@rojiphil Thanks will validate and update you.

[kavimuru]

@rojiphil It's a pass following the precondition and revised steps

RPReplay_Final1699544846.MP4

[rojiphil]

@adelekennedy
Now that the fix has been in production since Nov 10 according to this comment here,
can we not go ahead with the payments?

[adelekennedy]

yes! Sorry about that it looks like this didn't update automatically

Payouts due:

Contributor: $500 @rojiphil (Upwork)
Contributor+: $500 @Santhosh-Sellavel (NewDot)

Upwork job is here @rojiphil will you apply?

[rojiphil]

Upwork job is here @rojiphil will you apply?

@adelekennedy
Just applied using the link. Thanks for taking this forward.

[Santhosh-Sellavel]

@adelekennedy I'm C+ here can you update payment summary please, thanks!

[JmillsExpensify]

@adelekennedy re-opening for payment summary.

[JmillsExpensify]

Apologies, I missed this payment summary. $500 payment approved for @Santhosh-Sellavel.