[HOLD for payment 2023-12-11] [$500] Workspace - When going to "Announcement" room on Specific account, app crashes

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.91-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Open the New expensify app or access staging.new.expensify.com

2. Sign into this specific account [email protected]

3. Click on Profile > Workspace > Click any workspace

4. Click on the 3 dot menu in the top right > Go to #announce room

Expected Result:

User expects to go to the Announce room with no issues (The admin room redirect works fine)

Actual Result:

The app crashes every time

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Bug6250610_1698254497181.Crash.mp4

logs.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ca71bfccfd7e64d4
• Upwork Job ID: 1717256298451300352
• Last Price Increase: 2023-10-25
• Automatic offers:
• sourcecodedeveloper | Contributor | 27547013

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ca71bfccfd7e64d4

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[alitoshmatov]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

Based on the logs I am assuming #announce room is not found in the following lines:

App/src/pages/workspace/WorkspaceInitialPage.js

Lines 118 to 119 in 8fdbc4e

	const room = _.find(props.reports, (report) => report && report.policyID === policy.id && report.chatType === type && !ReportUtils.isThread(report));
	Navigation.dismissModal(room.reportID);

Since I cannot access this account I don't know why exactly #announce room is not found

What changes do you think we should make in order to solve the problem?

Considering this is an edge case, I would suggest applying some checks so that we will navigate to the room only if it exists:

            if(room){
                Navigation.dismissModal(room.reportID);
            }

What alternative solutions did you explore? (Optional)

We can also try to identify why the announce room is absent, but it requires access to the exact account

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - When going to "Announcement" room on Specific account, app crashes

What is the root cause of that problem?

https://user-images.githubusercontent.com/59907218/278139566-09094d66-fb29-4e58-a820-79fdff29b1ad.png
Based on the logs I am assuming #announce room is not found in the following lines:

App/src/pages/workspace/WorkspaceInitialPage.js

Lines 120 to 126 in 6c220e6

	const goToRoom = useCallback(
	(type) => {
	const room = _.find(props.reports, (report) => report && report.policyID === policy.id && report.chatType === type && !ReportUtils.isThread(report));
	Navigation.dismissModal(room.reportID);
	},
	[props.reports, policy],
	);

What changes do you think we should make in order to solve the problem?

Change the function like this

    const goToRoom = useCallback(
        (type) => {
            const room = _.find(props.reports, (report) => report && report.policyID === policy.id && report.chatType === type && !ReportUtils.isThread(report));
            if(room) Navigation.dismissModal(room.reportID)
            else Navigation.dismissModal()
        },
        [props.reports, policy, room],
    );

What alternative solutions did you explore? (Optional)

N/A

[pradeepmdk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When going to "Announcement" room on Specific account, app crashes

What is the root cause of that problem?

logs.txt

i am not able to reproduce in my account so problem is room is undefined.

App/src/pages/workspace/WorkspaceInitialPage.js

Lines 120 to 126 in 6c220e6

	const goToRoom = useCallback(
	(type) => {
	const room = _.find(props.reports, (report) => report && report.policyID === policy.id && report.chatType === type && !ReportUtils.isThread(report));
	Navigation.dismissModal(room.reportID);
	},
	[props.reports, policy],
	);

What changes do you think we should make in order to solve the problem?

we should update like this

const room = _.find(props.reports, (report) => report && report.policyID === policy.id && report.chatType === type && !ReportUtils.isThread(report)) || {};

[allroundexperts]

@Sourcecodedeveloper's proposal looks good to me. I think instead of just dismissing the modal (and not navigating anywhere), its better to not show the option at all.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[allroundexperts]

@Sourcecodedeveloper You're not supposed to create a PR until the internal engineer assigns an issue to you. Please wait for @marcochavezf to select your proposal before going ahead.

[melvin-bot]

@marcochavezf, @anmurali, @allroundexperts Huh... This is 4 days overdue. Who can take care of this?

[marcochavezf]

Hi guys, thanks for the patience here, I agree with @allroundexperts, assigning @Sourcecodedeveloper 🚀

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @Sourcecodedeveloper 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @marcochavezf, @anmurali, @allroundexperts, @Sourcecodedeveloper eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[anmurali]

The offer to you says it's been paid. I am closing this. Pls reopen if you're not seeing the payment.

Payment Summary

• Contributor $500 @Sourcecodedeveloper
• Contributor+ $500 @allroundexperts (to be paid on ND)

[allroundexperts]

Checklist

1. Added go to room menu items to workspace #19295
2. https://github.com/Expensify/App/pull/19295/files#r1431268485
3. A Slack discussion is not needed here since there isn't anything missing in the checklist which could have prevented this.
4. A regression test would be helpful here.

Regression test

1. Throttle the network requests to 'Slow 3G'.
2. Login to any account
3. Click on Profile > Workspace > Click any workspace.

While the chats are being loaded:
Click the three dot menu in the top and verify that the option to go to announce and admin do not appear.

After the chats are loaded:
Click the three dot menu in the top and verify that the option to go to announce and admin do appear and work fine.

Do we 👍 or 👎 ?

[JmillsExpensify]

$500 payment to @allroundexperts based on comment above.