[$500] IOU - When user deletes distance request, Inconsistent behaviour is shown

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.90-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

1. Launch app
2. Tap on a Workspace chat
3. Tap plus icon near compose box to select Request money
4. Tap Distance
5. Select start and Finish waypoints
6. Tap next
7. Tap Request
8. Tap on distance request to open distance request detail page
9. Tap on 3 dots on top right and select delete receipt
10. Note it shows TBD for a second and disappears.
11. Navigate back to Workspace
12. Repeat steps from 3-Step 8
13. Tap on the receipt
14. Tap on 3 dots on top right and delete receipt
15. In distance request detail page, tap 3 dots on top right and select delete request
16. Note the distance request disappears for a second and then shown as TBD.

Expected Result:

When user deletes distance request, it shows TBD for a second and disappears. Same distance request, if we delete receipt and then delete request, the distance request disappears for a second and then shown as TBD. There should not be Inconsistent behavior

Actual Result:

When user deletes distance request, it shows TBD for a second and disappears. Same distance request, if we delete receipt and then delete request, the distance request disappears for a second and then shown as TBD. Inconsistent behaviour is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Bug6250857_1698265839785.tbd.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ec1bd78667e0f93b
• Upwork Job ID: 1720412882637504512
• Last Price Increase: 2023-11-03

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[paultsimura]

There is some BE issue happening on the removal of a request with a detached receipt:
When a regular money request is deleted, the BE response contains (among others) the following Onyx operation that removes the REPORTPREVIEW action from the expense chat:

{
    "onyxMethod": "merge",
    "key": "reportActions_6604242241623001",
    "value": {
        "6002129300854202153": null
    }
}

However, when a request with a detached receipt is removed, this is what comes in the BE response, meaning the action was not removed on the server:

{
    "onyxMethod": "merge",
    "key": "reportActions_6604242241623001",
    "value": {
        "6002129300854202153": {
            "created": "2023-10-25 22:02:26.533"
        }
    }
}

First, the report preview disappears because we still have the "6002129300854202153": null in the optimistic data, but it's shortly replaced by the BE response for OpenReport operation.

[sonialiap]

I cannot reproduce this behavior on staging. @lanitochka17 are you still running into this?

Screen.Recording.2023-10-31.at.12.40.18.PM.mov

[lanitochka17]

Issue reproducible on latest build 1.3.93-1 ( mWeb/Chrome)

6.mp4

[sonialiap]

Thanks! Moving this to external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ec1bd78667e0f93b

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

📣 @voidash! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[voidash]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01e7b4ad5ddca74cb8

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[voidash]

Hey,
I am not able to create a Map based receipt on Chrome on Mac
Version 119.0.6045.105 (Official Build) (arm64)

output.mov

[paultsimura]

@sonialiap you may want to make this internal, please check: #30393 (comment)

[fedirjh]

I agree with @paultsimura. The issue is originating from the backend. It appears that the parent report action is not being deleted when a request with a detached receipt is removed.

[fedirjh]

cc @sonialiap friendly bump for #30393 (comment)

[melvin-bot]

@sonialiap @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[sonialiap]

:salutes: adding internal label

[melvin-bot]

Current assignee @fedirjh is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

@joelbettner, @sonialiap, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@joelbettner, @sonialiap, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[joelbettner]

@neil-marcellini any ideas with this?

edit: spoke to Neil 1:1 and said he could take this over.

[neil-marcellini]

I remember that we decided somewhere that users shouldn't be allowed to delete receipts on distance requests. I'll see if I can find where we made that decision and if we took action on it yet.

[neil-marcellini]

Aha yes we decided that we should not allow deleting the receipt for distance requests, here in Slack (internally), in relation to this issue Distance - Unable to save distance edit after deleting receipt. They have implemented backend changes to prevent that and are still working on the front end changes.

Once that issue is completed we should no longer be able to reproduce this bug, therefore we can close it now.