[HOLD for payment 2024-02-01] [$500] Chat - Attachment view is not closed when opening notification and cannot reopen attachment

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.91-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. [User B] Open an image attachment from any chat except User A
2. [User B] Background the app
3. [User A] Send a message to User B
4. [User B] Click on the notification
5. [User B] Close the attachment modal
6. [User B] Navigate to the same chat in Step 1 and open the attachment again

Expected Result:

In Step 4, the attachment full screen view will be closed
In Step 6, user can open the attachment in full screen view

Actual Result:

In Step 4, the attachment modal is not closed and the chat from the notification is opened in the background
In Step 6, user cannot open the attachment at all. It reopens on its own after the app is refreshed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6251857_1698329365190.20231026_165723.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b55cf9761f95eb16
• Upwork Job ID: 1717554157530738688
• Last Price Increase: 2023-10-26
• Automatic offers:
• tienifr | Contributor | 27507413

Issue Owner

Current Issue Owner: @laurenreidexpensify

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b55cf9761f95eb16

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 4, the attachment modal is not closed and the chat from the notification is opened in the background
In Step 6, user cannot open the attachment at all. It reopens on its own after the app is refreshed

What is the root cause of that problem?

We're not dismissing all modals when navigating to the report upon notification click

What changes do you think we should make in order to solve the problem?

Call Modal.close to close all modals before navigating to report in notification. This is the same approach used to close the modals before opening route via shortcut in here.

We need to add Modal.close where notifications (especially Local/Foreground notifications) are handled, like here and here (need to check for all applicable places for all platforms)

What alternative solutions did you explore? (Optional)

There's a known issue where calling Modal.close sometimes might not close all the modals, but that's being handled in a separate issue.

We can consider adding Modal.close inside Navigation.navigate (and other navigation params which change pages) so when navigating, we'll always close those modals.

[mananjadhav]

@tienifr's proposal looks good to me.

We'll have to check if this needs to be handled any other place. I am also not sure what happens on the notification if the message itself is an attachment. Does it open the attachment, we'll have to check this test case too.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @joelbettner, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[laurenreidexpensify]

Not overdue, Joel will review later today

[laurenreidexpensify]

@joelbettner bump for review pls

[joelbettner]

@mananjadhav I agree that @tienifr's proposal looks good. Will assign.

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[laurenreidexpensify]

@tienifr is there a draft PR yet? Thanks

[tienifr]

PR ready for review #30968.

[melvin-bot]

This issue has not been updated in over 15 days. @mananjadhav, @joelbettner, @laurenreidexpensify, @tienifr eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[laurenreidexpensify]

PR looks like we're close to merging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.31-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Attachment modal is not closed when click notification #30968

If no regressions arise, payment will be issued on 2024-02-01. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

@laurenreidexpensify This is ready for payout. I couldn't find any offending PR for this. But I do feel we should a regression test for this one. wdyt @joelbettner?

Adding test steps from the PR as regression test.

1. Login with 2 accounts (A & B) on different browsers/apps
2. [A] Open an image attachment in any chat EXCEPT the one with B
3. Put the app in background
4. [B] Send a message to A
5. [A] Press the message notification
6. Verify that the attachment modal closes and A gets navigated to the chat with B
7. Open the chat from Step 2 >> Open an image attachment
8. Verify that the attachment modal opens

[laurenreidexpensify]

Payment Summary:

Contributor: @tienifr $500 payment issued in Upwork
C+ review: @mananjadhav $500 please request payment in Newdot

[mananjadhav]

Thanks @laurenreidexpensify. Was the regression test added as per the comment here?

[JmillsExpensify]

$500 approved for @mananjadhav based on summary above.