-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Disable logs from staging and production native apps #30571
Comments
Triggered auto assignment to @trjExpensify ( |
@mountiny mind confirming what you want to do with this issue? Who should it get assigned to? |
This will be worked on externally so we might need to pay out later, waiting for @kidroca to confirm if he wants to work on this or if we should make this external |
Cool, sounds good! |
Thanks! I'd like to take this one |
Job added to Upwork: https://www.upwork.com/jobs/~0196038043ae5d7c60 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik ( |
@kidroca could you please post a proposal before starting a PR, thanks! |
ProposalPlease re-state the problem that we are trying to solve in this issue.The app's UI experiences sluggish performance at times. Preliminary investigation points to console logging as a significant contributor to this issue. What is the root cause of that problem?Console logging is a known performance bottleneck in React Native apps. It was initially disabled in production but was later re-enabled for debugging purposes. The problem lies in the excessive amount of logging, which impacts performance. For example, simple actions like switching chats generate around 400 lines of logs within a few seconds. What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)We could implement a feature to allow users to manually send the current log buffer to technical support for debugging. However, this would require additional development time and does not immediately address the performance issue. Expected Outcomes: Improved app performance and a better user experience. References: The official React Native documentation advises minimizing the use of console logging in production builds for better performance. |
@kidroca since you are already assigned, just go ahead and create the PR, thank you! |
This issue has not been updated in over 15 days. @kidroca, @trjExpensify, @mountiny, @robertKozik eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@kidroca will handle payments elsewhere, I think we can close this issue now. Thank you! |
Removed the invoice for @kidroca's work and I approve payment. |
cc @perunt @kidroca
Coming from here, we would like to disable the logs in native devices when the ENV is staging or production as we can see they can have certain effect on the performance.
We will keep the logs for web as there the performance effect is not so significant
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: