Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed
97 tasks done
OSBotify opened this issue Oct 31, 2023 · 20 comments
Closed
97 tasks done

Deploy Checklist: New Expensify 2023-10-31 #30662

OSBotify opened this issue Oct 31, 2023 · 20 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 31, 2023

Release Version: 1.3.94-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@kavimuru kavimuru added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 31, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.94-0 🚀

@kavimuru
Copy link

Checking off the following PRs from the past builds.

#23702
#27994
#28587
#29014
#29338
#29434
#29765
#29848
#29927
#29936
#30186
#30287
#30357
#30369
#30462
#30481
#30486
#30497
#30512
#30521
#30532
#30534
#30536

@Beamanator
Copy link
Contributor

Beamanator commented Nov 1, 2023

Ran this script again to de-dupe, got this output:

Output:
- [x] https://github.com/Expensify/App/pull/23702
- [x] https://github.com/Expensify/App/pull/26605
- [ ] https://github.com/Expensify/App/pull/27796
- [x] https://github.com/Expensify/App/pull/27994
- [x] https://github.com/Expensify/App/pull/28381
- [ ] https://github.com/Expensify/App/pull/28422
- [ ] https://github.com/Expensify/App/pull/28573
- [x] https://github.com/Expensify/App/pull/28587
- [x] https://github.com/Expensify/App/pull/28600
- [ ] https://github.com/Expensify/App/pull/28640
- [x] https://github.com/Expensify/App/pull/29014
- [ ] https://github.com/Expensify/App/pull/29045
- [x] https://github.com/Expensify/App/pull/29315
- [x] https://github.com/Expensify/App/pull/29328
- [x] https://github.com/Expensify/App/pull/29338
- [x] https://github.com/Expensify/App/pull/29434
- [ ] https://github.com/Expensify/App/pull/29554
- [ ] https://github.com/Expensify/App/pull/29754
- [x] https://github.com/Expensify/App/pull/29756
- [x] https://github.com/Expensify/App/pull/29765
- [x] https://github.com/Expensify/App/pull/29848
- [ ] https://github.com/Expensify/App/pull/29860
- [ ] https://github.com/Expensify/App/pull/29887
- [x] https://github.com/Expensify/App/pull/29927
- [x] https://github.com/Expensify/App/pull/29936
- [x] https://github.com/Expensify/App/pull/29955
- [x] https://github.com/Expensify/App/pull/29970
- [ ] https://github.com/Expensify/App/pull/29983
- [ ] https://github.com/Expensify/App/pull/30061
- [ ] https://github.com/Expensify/App/pull/30085
- [ ] https://github.com/Expensify/App/pull/30115
- [ ] https://github.com/Expensify/App/pull/30167
- [ ] https://github.com/Expensify/App/pull/30173
- [x] https://github.com/Expensify/App/pull/30186
- [ ] https://github.com/Expensify/App/pull/30238
- [ ] https://github.com/Expensify/App/pull/30264
- [x] https://github.com/Expensify/App/pull/30287
- [ ] https://github.com/Expensify/App/pull/30300
- [x] https://github.com/Expensify/App/pull/30315
- [ ] https://github.com/Expensify/App/pull/30325
- [x] https://github.com/Expensify/App/pull/30357
- [x] https://github.com/Expensify/App/pull/30369
- [ ] https://github.com/Expensify/App/pull/30382
- [ ] https://github.com/Expensify/App/pull/30410
- [ ] https://github.com/Expensify/App/pull/30419
- [ ] https://github.com/Expensify/App/pull/30429
- [ ] https://github.com/Expensify/App/pull/30433
- [ ] https://github.com/Expensify/App/pull/30438
- [ ] https://github.com/Expensify/App/pull/30439
- [ ] https://github.com/Expensify/App/pull/30444
- [ ] https://github.com/Expensify/App/pull/30452
- [ ] https://github.com/Expensify/App/pull/30458
- [x] https://github.com/Expensify/App/pull/30462
- [ ] https://github.com/Expensify/App/pull/30471
- [ ] https://github.com/Expensify/App/pull/30473
- [ ] https://github.com/Expensify/App/pull/30475
- [ ] https://github.com/Expensify/App/pull/30476
- [ ] https://github.com/Expensify/App/pull/30477
- [ ] https://github.com/Expensify/App/pull/30479
- [ ] https://github.com/Expensify/App/pull/30481
- [ ] https://github.com/Expensify/App/pull/30483
- [x] https://github.com/Expensify/App/pull/30484
- [ ] https://github.com/Expensify/App/pull/30485
- [x] https://github.com/Expensify/App/pull/30486
- [ ] https://github.com/Expensify/App/pull/30491
- [x] https://github.com/Expensify/App/pull/30497
- [ ] https://github.com/Expensify/App/pull/30512
- [x] https://github.com/Expensify/App/pull/30519
- [x] https://github.com/Expensify/App/pull/30521
- [x] https://github.com/Expensify/App/pull/30522
- [ ] https://github.com/Expensify/App/pull/30526
- [ ] https://github.com/Expensify/App/pull/30530
- [ ] https://github.com/Expensify/App/pull/30532
- [x] https://github.com/Expensify/App/pull/30534
- [ ] https://github.com/Expensify/App/pull/30536
- [ ] https://github.com/Expensify/App/pull/30542
- [x] https://github.com/Expensify/App/pull/30566
- [ ] https://github.com/Expensify/App/pull/30572
- [ ] https://github.com/Expensify/App/pull/30573
- [ ] https://github.com/Expensify/App/pull/30589
- [ ] https://github.com/Expensify/App/pull/30599
- [ ] https://github.com/Expensify/App/pull/30602
- [x] https://github.com/Expensify/App/pull/30604
- [ ] https://github.com/Expensify/App/pull/30612
- [x] https://github.com/Expensify/App/pull/30614
- [ ] https://github.com/Expensify/App/pull/30647
- [x] https://github.com/Expensify/App/pull/30651

@Beamanator
Copy link
Contributor

Beamanator commented Nov 1, 2023

Another weird point to mention: All of the PRs in this list marked CP Staging were already in prod a few days ago 🤷 so I checked them off the above list (also #30532 which was CP'd)

@Beamanator
Copy link
Contributor

Currently no blockers 👍

@Beamanator
Copy link
Contributor

Testflight still shows the old version (1.3.93.1) - i'll try to update to 1.3.94.0 now

@Beamanator
Copy link
Contributor

Discussed a bit in this thread - it seems 1.3.94.0 is available to some users via testflight already, just not everyone (ex: me) 🤷 👍

@kavimuru
Copy link

kavimuru commented Nov 1, 2023

Regression 78% progress.
#30264 failing with #30222 in Desktop and Web, This is a KI checking off
#30476 failing with #30681 repro in PROD checking off
#30479 failing with #30222 ( not fixed)
#30485 failing with #30684

@kavimuru
Copy link

kavimuru commented Nov 1, 2023

@Beamanator This PR seems to be internal #30573 (comment)

@Beamanator
Copy link
Contributor

@kavimuru I agree, I checked off #30573 👍

@Beamanator
Copy link
Contributor

Checking off #29983 b/c we reverted it in #30708 (& checking off that one too)

@kavimuru
Copy link

kavimuru commented Nov 1, 2023

Regression we are down to 4%. Validating cps

@kavimuru
Copy link

kavimuru commented Nov 1, 2023

Regression is left with 10 steps.
#30712 failing with #30696 (Not fixed in Android)
#30479 failing with #30222 ( not fixed)
#30485 failing with #30684

@mvtglobally
Copy link

Regression is completed

@Beamanator
Copy link
Contributor

Checking off #30729 as it was confirmed this happens in prod here

@Beamanator
Copy link
Contributor

Checked off #30703 b/c it was fixed via #30708 & tested 👍

@Beamanator
Copy link
Contributor

#30222 reproducible in prod, so checking off #30479

@Beamanator
Copy link
Contributor

Checking off #30485 and #30684 b/c it is fixed in staging, via #30712

@Beamanator
Copy link
Contributor

Checking off #30696 b/c it's a super small bug & it's better than before, and should be fixed via #25935

@Beamanator
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants