[HOLD for payment 2023-12-07] [$500] IOU - Inconsistency in Scan split bill IOU preview for creator&Participant

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.94.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab-Request Money
3. Tap Scan
4. Upload a picture by taking photo
5. Split with any 2 users
6. Tap add to Split
7. Tap split
8. Tap scan request created
9. Enter amount, description and merchant field
10. Tap split
    Note: The description in OIU is displayed
11. Log in with any user with whom you've split the bill
12. Open IOU
    Note: The Merchant in OIU is displayed

Expected Result:

There should not be inconsistency in IOU preview displayed for scan request creator and participant.

Actual Result:

For user who made scan request and split bill with 2 users, description details entered is shown in IOU preview. But for participant of split bill, merchant details entered is shown in IOU preview. There is inconsistency in IOU preview displayed for scan request creator and participant.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen_Recording_20231107_120329_Chrome.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01890520fc54e620e1
• Upwork Job ID: 1719686303480401920
• Last Price Increase: 2023-11-01
• Automatic offers:
• cubuspl42 | Reviewer | 27750967
• dukenv0307 | Contributor | 27750969

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01890520fc54e620e1

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill preview display description while IOU Preview display merchant

What is the root cause of that problem?

We only show merchant if the request preview is not split bill

App/src/components/ReportActionItem/MoneyRequestPreview.js

Lines 172 to 175 in c8e7ee5

	const shouldShowMerchant =
	!_.isEmpty(requestMerchant) && !props.isBillSplit && requestMerchant !== CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT && requestMerchant !== CONST.TRANSACTION.DEFAULT_MERCHANT;
	const shouldShowDescription = !_.isEmpty(description) && !shouldShowMerchant;

What changes do you think we should make in order to solve the problem?

I think we should also show merchant for split bill by removing the condition !props.isBillSplit and and change the marigin style of merchant text if it's split bill

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 173 in c8e7ee5

!_.isEmpty(requestMerchant) && !props.isBillSplit && requestMerchant !== CONST.TRANSACTION.PARTIAL_TRANSACTION_MERCHANT && requestMerchant !== CONST.TRANSACTION.DEFAULT_MERCHANT;

Or Update the condition here to

{shouldShowDescription || (shouldShowMerchant && props.isBillSplit) && <Text style={[styles.colorMuted]}>{description || requestMerchant}</Text>}

And here to

shouldShowMerchant && !props.isBillSplit

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 318 in c8e7ee5

{shouldShowMerchant && (

App/src/components/ReportActionItem/MoneyRequestPreview.js

Line 328 in c8e7ee5

{shouldShowDescription && <Text style={[styles.colorMuted]}>{description}</Text>}

What alternative solutions did you explore? (Optional)

We can prioritize description over merchant

[miljakljajic]

@cubuspl42 any thoughts on the above proposal?

[cubuspl42]

@dukenv0307 I will not review any of your proposals as long as the "Please re-state the problem that we are trying to solve in this issue" section is a copy-pasted issue name.

[dukenv0307]

@cubuspl42 Thanks for your review, will improve this in the further. I updated.

[cubuspl42]

@kbecciv
I re-watched the provided video multiple times and still cannot understand the issue's essence. Maybe it has something to do with the second attachment not loading correctly.

@dukenv0307 While your new updated issue re-statement is now acceptable in the formal sense, it didn't help me understand the actual problem here.

[dukenv0307]

Seem like the image in the screenshot of this issue is unavailable now. The problem here is when we create a split bill with description and merchant. The Split bill preview displays description field while the iou preview in iou report of each participant displays merchant field. That is the current bug which this issue mentioned.

[cubuspl42]

@kbecciv Would you re-record the videos?

Two reasons:

• One of them is not available
• It's suggested that there is an issue with reproducibility

[kbecciv]

@cubuspl42 I apologize for any inconvenience. I've reviewed the issue again, corrected the reproduction steps, and added a new video and screenshot. Please let me know if the reported issue is still difficult to understand, and I'll be happy to assist further.

[cubuspl42]

@kbecciv Thank you! <3

[cubuspl42]

The proposal by @dukenv0307 makes sense. I personally would prefer the "alternative solution", i.e. preferring the description over the merchant. In my opinion, the description is the most personal element of the form filled by the user and is the one that deserves to be presented with the highest priority.

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[cubuspl42]

@nkuoch Would you share your opinion about which field should be consistently presented in the Split/IOU preview: should it be the "merchant" or "description"?

[nkuoch]

cc @vitHoracek as you originally did https://github.com/Expensify/App/pull/26603/files#diff-d8e6b69ad4461bebf91e940a67ddc07adf36a3f7c156d6066363c3bde06a0f8aR162

[nkuoch]

friendly bump @vitHoracek

[cubuspl42]

@nkuoch In such a case, I think we're ready to assign @dukenv0307 and start working on a PR 🙂

[melvin-bot]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[aimane-chnaif]

Let's hold this for #30721
cc: @youssef-lr

[dukenv0307]

@cubuspl42 The PR is ready for review.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show merchant for split bill #31604

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment offer (Reviewer)
• @dukenv0307 requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] The PR that introduced the bug has been identified. Link to the PR:
• [@cubuspl42] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@cubuspl42] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@cubuspl42] Determine if we should create a regression test for this bug.
• [@cubuspl42] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[miljakljajic]

Both contracts paid and ended. Thank you for your work!

[pecanoro]

@miljakljajic Did we reduce the pay? Since it caused a deploy blocker and PR had to be reverted.

[miljakljajic]

Ah, I had no idea we needed to reduce the pay. I'll request a partial refund from @dukenv0307 and @cubuspl42

[cubuspl42]

@miljakljajic Is it possible on Upwork?