[HOLD for payment 2023-12-08] Incorrect month is opening when tapping Oct2023 statement in OldDot app

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction (don't have statement)
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @cead22
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1698869124487529

Action Performed:

1. Go to OldDot and login
2. Tap on Oct 2023 statement

Expected Result:

Statement should open in NewDot with correct header and translation. Link shou

Actual Result:

• Tapping on the link to the Oct 2023 statement in old app opens new dot, but with a header Noviembre 2023 Statement
• The translation is wrong, it should be Estado de cuenta de Octubre 2023
• Opening the statement in NewDot opens a new safari window and lands in sign in page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f250a418a4564fbf
• Upwork Job ID: 1720223933365579776
• Last Price Increase: 2023-11-02

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Christinadobrzyn]

I'm not sure if this can be external so going to apply internal for now.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f250a418a4564fbf

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[melvin-bot]

@mananjadhav, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

hey @mananjadhav can this be external? Let me know your thoughts!

[mananjadhav]

@Christinadobrzyn Catching up, I'll test this by tomorrow.

[Christinadobrzyn]

Sounds good, thanks @mananjadhav!

[mananjadhav]

I just checked this. Due to the lack of context from OldDot, I am not sure how do I reproduce this. @Christinadobrzyn are you able to reproduce this?

@m-natarajan Can you please elaborate the steps to reproduce and also post a video instead of screenshot?

Tap on Oct 2023 statement

I don't know what we mean by this.

and do I need to open Expensify in the iOS Native? to test this? I also followed through the slack conversation but no info there.

[Christinadobrzyn]

No, I was not able to reproduce this, sorry I pushed it forward because it was reported by internal engineers. I'll reach out to QA in Slack to see if they can test again and update the OP steps so I can get a better idea of what is happening. Asking QA for some help - https://expensify.slack.com/archives/C9YU7BX5M/p1699384867315839

[mvtglobally]

@cead22 can you pls help us out on this issue? we do not have access to statements to verify reproduction again.

[cead22]

How can I help?

This only applies to accounts that have expensify cards. If you have one and have received a statement, you should be able to navigate to https://new.expensify.com/statements/202310 to see the October statement (hence the 202310 in the URL), and you'll see November shows on the header

[Christinadobrzyn]

So it sounds like this should be internal since it relates to OldDot and Expensify Cards. I'll add an engineering label to see if we can get someone internal to work on this.

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Christinadobrzyn]

Oh no, @cead22 it assigned to you 😞 Let me know if you want me to try and find another engineer to work on this.

[cead22]

If you can, please do

[hayata-suenaga]

gonna go back to the Slack convo and see what I need to do

[hayata-suenaga]

PR is up and under review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix month in the ECard statement header title #31843

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[cead22]

🎉

[Christinadobrzyn]

prepping for payment!

Payouts due:

Issue Reporter: NA
Contributor: NA
Contributor+: $500 @mananjadhav (paid through NewExpensify)

Eligible for 50% #urgency bonus? N

Upwork job is NA

@mananjadhav do we need a regression test for this?

[mananjadhav]

I don't think we do, but I would still want to confirm with @hayata-suenaga. This was fixed internally and I reviewed the code.

[hayata-suenaga]

I also don't think we need a regression test

[Christinadobrzyn]

Awesome! I think this can be closed out but @mananjadhav please make sure to request payment through NewExpensify.

[JmillsExpensify]

$500 payment approved for @mananjadhav based on this summary.