[HOLD for payment 2023-11-21] [$500] Remove Global Nav and Sub Nav

[hayata-suenaga]

This is not an issue for a new feature. Instead, this issue is for removing a recently-added UI component and bring the App to a previous state.

Revert the changes made in these PRs and remove the Global Nav (the new, left-most navigation panel). We need to bring NewDot to the previous version where the Global Nav didn't exist.

#28277

#29428

#29133

Remove the part highlighted in red in the screenshot below:
Note that you have to bring the Avatar and the Floating Action Button back to its original position.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fbdba52a9a3e39e3
• Upwork Job ID: 1720215594050605056
• Last Price Increase: 2023-11-02
• Automatic offers:
• cubuspl42 | Reviewer | 27540886

[melvin-bot]

Triggered auto assignment to @miljakljajic (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fbdba52a9a3e39e3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[abzokhattab]

I can work on this ... i will remove all new files created in the 3 PRs and revert these new changes ...

[yh-0218]

I'd like to work on this.

[zukilover]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove global navigation and revert the app UI state to the previous design that has the avatar in the top right of LHN, and FAB in the bottom right of LHN.

What is the root cause of that problem?

N/A. This is a reversal.

What changes do you think we should make in order to solve the problem?

git revert -m 1 389d7b0c4b96c6f2a2295055c685791d35b65252

Remove GlobalNavigation from here:

App/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.js

Lines 36 to 38 in d53a03e

	<View style={[styles.flex1, styles.flexRow, styles.globalAndSubNavigationContainer]}>
	<GlobalNavigation />
	<SubNavigation

Put back SignInOrAvatarWithOptionalStatus here:

App/src/pages/home/sidebar/SidebarLinks.js

Lines 163 to 164 in d53a03e

	</Tooltip>
	</View>

What alternative solutions did you explore? (Optional)

N/A

Result:

[cubuspl42]

The reverting plan sketched by @zukilover sounds fine to me. I'll double-ensure that all requirements are met on the PR level.

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Current assignee @hayata-suenaga is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

@cubuspl42, @miljakljajic, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @zukilover You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[hayata-suenaga]

Thank you @miljakljajic for assigning @zukilover 🙇

[zukilover]

PR is ready #30946

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove Global Nav and Sub Nav #30946

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @zukilover requires payment
• @cubuspl42 requires payment offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[cubuspl42]

• Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • No need for a regression test

[miljakljajic]

@cubuspl42 has been paid. @zukilover - please accept the Upwork offer and I'll send payment promptly :)

[zukilover]

Thanks @miljakljajic , offer accepted.

[miljakljajic]

Payment issued and contracts ended. Thank you both!