[$500] Web - Search – Secondary log doesn’t add immediately in NewDot account.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.3.95-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Log into NewDot with any account.
2. Log into OldDot with the same account and add a Secondary Login from Account Settings.
3. Verify the Secondary login has been validated.
4. Log in to NewDot with the same account that already has a validated secondary login.
5. Navigate – Settings/ Profile/ Contact methods.

Expected Result:

Account has a secondary login in NewDot.

Actual Result:

Secondary log doesn’t add immediately in NewDot account. It shows up only after relogin.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6262038_1699009001654.secondary_log.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c1bfd5f6d6337d88
• Upwork Job ID: 1720404994271817728
• Last Price Increase: 2023-11-03

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c1bfd5f6d6337d88

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[abdel-h66]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login list is not updated after refresh and only gets updated after a logout/login

What is the root cause of that problem?

After the user login, the updated logins list is received in the OpenApp response. And it's only updated when an action like Add Contact method is manually done by the user.

What changes do you think we should make in order to solve the problem?

There should be an extra API endpoint for fetching the User logins list. That we would call when mounting ContactMethodsPage

We would add the API call to src/libs/actions/User.js

function openContactMethodsPage() {
    API.read('OpenContactMethodsPage');
}

And use it as such

    useEffect(() => {
        openContactMethodsPage()
    }, [])

What alternative solutions did you explore? (Optional)

N/A

[trjExpensify]

@twisterdotcom @zanyrenney @Beamanator @cristipaval since the introduction of this feature has this worked immediately? I feel like it might have the same root cause as we've discussed in this issue where a member's private personal details aren't returned in OpenApp? CC: @grgia

[cristipaval]

I don't think this worked immediately. It seems that the backend doesn't send Pusher updates to NewDot in this case, when the secondary login is added in OldDot. By fixing this issue, we will get the login list updated always when we resume the session in NewDot. But there's still a corner case which I'm not sure it's worth a lot to get fixed: if the NewDot App is foregrounded and the user adds a secondary login in OldDot, the secondary login won't be instantly added in NewDot, it will appear when the user moves out of the App and comes back.

[trjExpensify]

But there's still a corner case which I'm not sure it's worth a lot to get fixed: if the NewDot App is foregrounded and the user adds a secondary login in OldDot, the secondary login won't be instantly added in NewDot, it will appear when the user moves out of the App and comes back.

What do we do with other personal settings like updating your name, avatar and timezone?

[cristipaval]

But there's still a corner case which I'm not sure it's worth a lot to get fixed: if the NewDot App is foregrounded and the user adds a secondary login in OldDot, the secondary login won't be instantly added in NewDot, it will appear when the user moves out of the App and comes back.

What do we do with other personal settings like updating your name, avatar and timezone?

Everything is instantly updated to other NewDot clients/devices when they change in NewDot, I don't know if they are also instantly updated in NewDot when they are changed in OldDot, we need to test this.

[trjExpensify]

Okay cool, what I'm thinking is:

1. The oldDot to newDot "instant" update is likely not isolated to a secondary login. If it's something we're going to address, it should be done holistically.
2. The linked issue to return private personal details in OpenApp will fix the current bug with not updating when opening/returning to the app.

So with that, we likely don't have anything specific to work on in this issue? #2 above will take care of updating when opening the app.

[cristipaval]

I totally agree with the above 👍

[trjExpensify]

Cool, so I'm going to close this out then. Thanks!