[HOLD for Payment][$500] Inconsistency of redirection after creating IOU and task #30883

m-natarajan · 2023-11-04T12:59:27Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.3.95.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1699054252287299

Action Performed:

Log in to ND
Create a Request money
Redirected to the DM
Create a task
Observe

Expected Result:

After creating IOU or task should be redirected to DM

Actual Result:

After creating task redirected to task itself

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Recording.197.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016c50b7a867fe5efd
Upwork Job ID: 1720787853214482432
Last Price Increase: 2023-11-11
Automatic offers:

s-alves10 | Contributor | 27643579

Issue Owner

Current Issue Owner: @kevinksullivan

melvin-bot · 2023-11-04T12:59:31Z

Job added to Upwork: https://www.upwork.com/jobs/~016c50b7a867fe5efd

melvin-bot · 2023-11-04T12:59:33Z

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-11-04T12:59:35Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-11-04T12:59:36Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

s-alves10 · 2023-11-04T13:30:23Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task creation redirects to the task report. Should redirect to the DM chat

What is the root cause of that problem?

We're redirecting to the task report after creating a task as you can see

App/src/libs/actions/Task.js

Line 216 in 7bd51eb

Navigation.dismissModal(optimisticTaskReport.reportID);

This is the root cause

What changes do you think we should make in order to solve the problem?

When creating a task, we have shareDestination and assignee.
I think it's reasonable to redirect to the shareDestination, not to DM chat

Updating

App/src/libs/actions/Task.js

Line 216 in 7bd51eb

Navigation.dismissModal(optimisticTaskReport.reportID);

to

    Navigation.dismissModal(parentReportID);

would redirect user to share destination

Result

30883.mp4

What alternative solutions did you explore? (Optional)

In the case we still want to redirect to the DM, we can update the above code to

    Navigation.dismissModal(assigneeChatReportID || parentReportID);

PiyushChandra17 · 2023-11-04T15:33:26Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency of redirection after creating IOU and task

What is the root cause of that problem?

We are using optimisticTaskReport.reportID here,

App/src/libs/actions/Task.js

Line 216 in 7bd51eb

Navigation.dismissModal(optimisticTaskReport.reportID);

This is resulting to redirection to Task report instead of chat, perhaps this is the root cause.

What changes do you think we should make in order to solve the problem?

We should use assigneeChatReportID instead of optimisticTaskReport.reportID.

We should update this,

App/src/libs/actions/Task.js

Line 216 in 7bd51eb

Navigation.dismissModal(optimisticTaskReport.reportID);

with this,

Navigation.dismissModal(assigneeChatReportID);

This will Navigate to the chat after IOU and creating a task.

What alternative solutions did you explore? (Optional)

NA

Result:

PiyushChandra17 · 2023-11-04T15:51:53Z

@s-alves10 I think assigneeChatReportID should be the way to go as it redirects to DM. You can get the reference from here,

App/src/libs/actions/Task.js

Lines 43 to 47 in 7bd51eb

    
            * A task needs two things to be created - a title and a parent report 
        
            * When you create a task report, there are a few things that happen: 
        
            * A task report is created, along with a CreatedReportAction for that new task report 
        
            * A reportAction indicating that a task was created is added to the parent report (share destination) 
        
            * If you assign the task to someone, a reportAction is created in the chat between you and the assignee to inform them of the task

eh2077 · 2023-11-05T01:36:16Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency of redirection after creating IOU and task

What is the root cause of that problem?

The root cause of this issue is that after creating task, we open the task report, see

App/src/libs/actions/Task.js

Line 216 in 846a4b7

Navigation.dismissModal(optimisticTaskReport.reportID);

What changes do you think we should make in order to solve the problem?

To redirect to chat room after creating task, we can change

App/src/libs/actions/Task.js

Line 216 in 846a4b7

Navigation.dismissModal(optimisticTaskReport.reportID);

to

    const parentReport = ReportUtils.getReport(parentReportID);
    if (ReportUtils.isChatRoom(parentReport)) { // We can also consider group chat as chat room if necessary
        // We want to redirect to the parent report if this task is going to be shared to a chat room.
        Navigation.dismissModal(parentReportID);
    } else {
        Navigation.dismissModal(optimisticTaskReport.reportID);
    }

See demo

0-web.mp4

What alternative solutions did you explore? (Optional)

N/A

dukenv0307 · 2023-11-06T07:06:51Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistency of redirection after creating IOU and task

What is the root cause of that problem?

When we create a task, we redirect to task report

App/src/libs/actions/Task.js

Line 216 in 925ff67

Navigation.dismissModal(optimisticTaskReport.reportID);

When we create an IOU, we redirect to chat report or expense report

App/src/libs/actions/IOU.js

Lines 879 to 880 in 925ff67

    
           Navigation.dismissModal(isMoneyRequestReport ? report.reportID : chatReport.reportID); 
        
           Report.notifyNewAction(chatReport.reportID, payeeAccountID);

What changes do you think we should make in order to solve the problem?

Because both shareDestination and assignee reports have the task preview, it doesn't make sense to go to the chat report after creating a task.

Instead, when we create a money request we should build optimistic data for the transaction thread which is the detail report of the request, and redirect to this report after creating a request to be consistent with the task behavior.

App/src/libs/actions/IOU.js

Lines 879 to 880 in 925ff67

    
           Navigation.dismissModal(isMoneyRequestReport ? report.reportID : chatReport.reportID); 
        
           Report.notifyNewAction(chatReport.reportID, payeeAccountID);

What alternative solutions did you explore? (Optional)

quinthar · 2023-11-06T08:33:55Z

The decision to redirect to the parent report (eg, the DM or the workspace chat) when creating a money request is intentional and not up for consideration here. Accordingly, please model task creation on this, and also redirect to the parent chat room when creating the task. (If the task is being created from within the chat itself, simply show the task preview and redirect nowhere.

melvin-bot · 2023-11-07T13:53:54Z

@kevinksullivan, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

eh2077 · 2023-11-07T14:51:22Z

Proposal

Updated to redirect to the parent chat room after task creation.

melvin-bot · 2023-11-09T13:51:27Z

@kevinksullivan, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

melvin-bot · 2023-11-11T18:15:57Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

allroundexperts · 2023-11-12T22:15:26Z

@s-alves10 were the first to propose the use of parentReportId. As such, it makes sense to go with @s-alves10's proposal.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-11-12T22:15:33Z

Triggered auto assignment to @danieldoglas, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

melvin-bot · 2023-11-13T11:25:08Z

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

melvin-bot · 2023-11-13T11:25:12Z

📣 @s-alves10 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

s-alves10 · 2023-11-14T13:50:58Z

@allroundexperts

PR is ready for review #31307

s-alves10 · 2023-12-03T19:25:37Z

@danieldoglas

Could you please check on the payment status? The PR was merged into production 2 weeks ago

danieldoglas · 2023-12-04T11:13:17Z

Hmm, I think we had an issue with the payment summary during the last 2 weeks, which is why this was not notified.

@kevinksullivan can you please take care of the payment here? We're all good.

kevinksullivan · 2023-12-12T01:31:34Z

Payment summary

Contributor: @s-alves10 $500
C+: @allroundexperts $500 (NewDot)

Paid out @s-alves10 . @allroundexperts am I good to close this, assuming you'll request in newdot? Let me know if not and I can reopen!

JmillsExpensify · 2024-01-24T23:57:23Z

$500 payment to @allroundexperts based on comment above.

m-natarajan added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 4, 2023

melvin-bot bot changed the title ~~Inconsistency of redirection after creating IOU and task~~ [$500] Inconsistency of redirection after creating IOU and task Nov 4, 2023

melvin-bot bot assigned kevinksullivan Nov 4, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 4, 2023

melvin-bot bot assigned allroundexperts Nov 4, 2023

melvin-bot bot added the Overdue label Nov 6, 2023

melvin-bot bot removed the Overdue label Nov 12, 2023

melvin-bot bot assigned danieldoglas Nov 12, 2023

danieldoglas assigned s-alves10 Nov 13, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 13, 2023

This comment was marked as resolved.

Sign in to view

s-alves10 mentioned this issue Nov 14, 2023

fix: redirect to parent chat when creating a task #31307

Merged

47 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 14, 2023

danieldoglas changed the title ~~[$500] Inconsistency of redirection after creating IOU and task~~ [Waiting for Payment][$500] Inconsistency of redirection after creating IOU and task Dec 4, 2023

danieldoglas changed the title ~~[Waiting for Payment][$500] Inconsistency of redirection after creating IOU and task~~ [HOLD for Payment][$500] Inconsistency of redirection after creating IOU and task Dec 4, 2023

danieldoglas added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Dec 4, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 11, 2023

kevinksullivan closed this as completed Dec 12, 2023

huult mentioned this issue Oct 17, 2024

Compose Box - After create a group task user is not redirected to task conversation #51047

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for Payment][$500] Inconsistency of redirection after creating IOU and task #30883

[HOLD for Payment][$500] Inconsistency of redirection after creating IOU and task #30883

m-natarajan commented Nov 4, 2023 •

edited by danieldoglas

Loading

melvin-bot bot commented Nov 4, 2023

melvin-bot bot commented Nov 4, 2023

melvin-bot bot commented Nov 4, 2023

melvin-bot bot commented Nov 4, 2023

s-alves10 commented Nov 4, 2023 •

edited

Loading

PiyushChandra17 commented Nov 4, 2023

PiyushChandra17 commented Nov 4, 2023

eh2077 commented Nov 5, 2023 •

edited

Loading

dukenv0307 commented Nov 6, 2023

quinthar commented Nov 6, 2023 via email •

edited

Loading

melvin-bot bot commented Nov 7, 2023

eh2077 commented Nov 7, 2023

melvin-bot bot commented Nov 9, 2023

melvin-bot bot commented Nov 11, 2023

allroundexperts commented Nov 12, 2023

melvin-bot bot commented Nov 12, 2023

melvin-bot bot commented Nov 13, 2023

melvin-bot bot commented Nov 13, 2023

This comment was marked as resolved.

s-alves10 commented Nov 14, 2023

s-alves10 commented Dec 3, 2023

danieldoglas commented Dec 4, 2023

kevinksullivan commented Dec 12, 2023

JmillsExpensify commented Jan 24, 2024

[HOLD for Payment][$500] Inconsistency of redirection after creating IOU and task #30883

[HOLD for Payment][$500] Inconsistency of redirection after creating IOU and task #30883

Comments

m-natarajan commented Nov 4, 2023 • edited by danieldoglas Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Nov 4, 2023

melvin-bot bot commented Nov 4, 2023

melvin-bot bot commented Nov 4, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Nov 4, 2023

s-alves10 commented Nov 4, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

PiyushChandra17 commented Nov 4, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result:

PiyushChandra17 commented Nov 4, 2023

eh2077 commented Nov 5, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dukenv0307 commented Nov 6, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

quinthar commented Nov 6, 2023 via email • edited Loading

melvin-bot bot commented Nov 7, 2023

eh2077 commented Nov 7, 2023

Proposal

melvin-bot bot commented Nov 9, 2023

melvin-bot bot commented Nov 11, 2023

allroundexperts commented Nov 12, 2023

melvin-bot bot commented Nov 12, 2023

melvin-bot bot commented Nov 13, 2023

melvin-bot bot commented Nov 13, 2023

This comment was marked as resolved.

s-alves10 commented Nov 14, 2023

s-alves10 commented Dec 3, 2023

danieldoglas commented Dec 4, 2023

kevinksullivan commented Dec 12, 2023

JmillsExpensify commented Jan 24, 2024

m-natarajan commented Nov 4, 2023 •

edited by danieldoglas

Loading

s-alves10 commented Nov 4, 2023 •

edited

Loading

eh2077 commented Nov 5, 2023 •

edited

Loading

quinthar commented Nov 6, 2023 via email •

edited

Loading