Chat - Default avatars are shown in LHN instead of custom ones

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com or open Expensify App
2. Login with any account
3. Check user avatars in LHN

Expected Result:

Custom avatars are shown in LHN for users who have them

Actual Result:

Default avatars are shown in LHN for all users, even if custom ones are loaded

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6266648_1699313780903.Chat-default-avatars-instead-custom.mp4

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[roryabraham]

Discussed in slack, but I think we can fix this by removing the call to _.values here

[cead22]

I pushed a draft PR with another potential solution, in case we wanna go that route

[TMisiukiewicz]

Hi, I'm Tomasz from Callstack, seems like a regression from #30242 I've been working on together with @adhorodyski. I think solution proposed by @roryabraham is correct - I'll take care of creating the PR

[mountiny]

gonna push this forwards now

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

Fixed, we will have to pay @rushatgabhane for review

[rushatgabhane]

@mountiny what amount should I request on new dot?

[mountiny]

I guess this would be $500 based on the classic rules

[rushatgabhane]

request here- https://staging.new.expensify.com/r/8616790277990951

[mountiny]

I believe we can close this one now and the payer will come back here to confirm once request has been paid.