-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-11-17] [$500] The app crashes when taping on link https://staging.new.expensify.com/request/new/participants #30933
Comments
Issue is not reproducible in production RPReplay_Final1699314789.MP4 |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @robertjchen ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The app crashes when taping on link https://staging.new.expensify.com/request/new/participants What is the root cause of that problem?When we go to the participant page directly by deep-link, the iou field on ONYX will be undefined App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js Line 170 in da2c79e
So that App crash because we are reading transactionID of underfined What changes do you think we should make in order to solve the problem?App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js Line 170 in da2c79e
we should update like this
And then App will auto redirect to the step 1 of request flow What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~01b97b835cfc1fe6d6 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
@dukenv0307 that makes sense! Let's go with that proposal 👍 |
📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
accelerating this due to deploy blocker status |
Not able to reproduce on latest main |
Regression from #28308 |
Ah was this issue addressed already? 🤔 |
@dukenv0307 are you able to reproduce on main? |
@situchan I still can reproduce on the latest main. Could you log out and try again? |
@robertjchen I reproduced on main after logout and re-login. Bug is still valid. So happens when
@dukenv0307 we should not return empty string. It will pull all transactions. |
📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@dukenv0307 It would be good if we can fix that as well but if not sooner, maybe you can just pinpoint the offending PR which caused that 2nd crash so that author can work on that. |
Thanks! Let me know if you're able to test this now 🙏 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-17. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
Looks like this feel through the cracks, let me find someone here to handle the next steps. Thanks for your patience! |
Triggered auto assignment to @peterdbarkerUK ( |
This comment was marked as off-topic.
This comment was marked as off-topic.
@peterdbarkerUK this wasn't labelled with |
Payment summary: $500 to @dukenv0307 (contributor) Job closed on UpWork. Thanks guys! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
App is not crashed
Actual Result:
The app crashes when taping on link https://staging.new.expensify.com/request/new/participants
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Screen_Recording_20231106_183139_New.Expensify.1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: