Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-17] [$500] The app crashes when taping on link https://staging.new.expensify.com/request/new/participants #30933

Closed
2 of 6 tasks
kbecciv opened this issue Nov 7, 2023 · 31 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Nov 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Tap on https://staging.new.expensify.com/request/new/participants

Expected Result:

App is not crashed

Actual Result:

The app crashes when taping on link https://staging.new.expensify.com/request/new/participants

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screen_Recording_20231106_183139_New.Expensify.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b97b835cfc1fe6d6
  • Upwork Job ID: 1721768998901219328
  • Last Price Increase: 2023-11-07
  • Automatic offers:
    • fedirjh | Reviewer | 27552830
    • dukenv0307 | Contributor | 27552832
    • situchan | Contributor | 27553607
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 7, 2023
@kbecciv
Copy link
Author

kbecciv commented Nov 7, 2023

Issue is not reproducible in production

RPReplay_Final1699314789.MP4

@OSBotify
Copy link
Contributor

OSBotify commented Nov 7, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@dukenv0307
Copy link
Contributor

dukenv0307 commented Nov 7, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes when taping on link https://staging.new.expensify.com/request/new/participants

What is the root cause of that problem?

When we go to the participant page directly by deep-link, the iou field on ONYX will be undefined

key: ({iou}) => `${ONYXKEYS.COLLECTION.TRANSACTION}${iou.transactionID}`,

So that App crash because we are reading transactionID of underfined

What changes do you think we should make in order to solve the problem?

key: ({iou}) => `${ONYXKEYS.COLLECTION.TRANSACTION}${iou.transactionID}`,

we should update like this

            key: ({iou}) => `${ONYXKEYS.COLLECTION.TRANSACTION}${iou?.transactionID || ''}`,

And then App will auto redirect to the step 1 of request flow

What alternative solutions did you explore? (Optional)

@robertjchen robertjchen added the External Added to denote the issue can be worked on by a contributor label Nov 7, 2023
@melvin-bot melvin-bot bot changed the title The app crashes when taping on link https://staging.new.expensify.com/request/new/participants [$500] The app crashes when taping on link https://staging.new.expensify.com/request/new/participants Nov 7, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01b97b835cfc1fe6d6

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 7, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@robertjchen
Copy link
Contributor

@dukenv0307 that makes sense! Let's go with that proposal 👍

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 7, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Nov 7, 2023

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@robertjchen
Copy link
Contributor

accelerating this due to deploy blocker status

@situchan
Copy link
Contributor

situchan commented Nov 7, 2023

Not able to reproduce on latest main

@situchan
Copy link
Contributor

situchan commented Nov 7, 2023

Regression from #28308

@robertjchen
Copy link
Contributor

Ah was this issue addressed already? 🤔

@situchan
Copy link
Contributor

situchan commented Nov 7, 2023

@dukenv0307 are you able to reproduce on main?
I definitely reproduced on staging but not on main

@dukenv0307
Copy link
Contributor

@situchan I still can reproduce on the latest main. Could you log out and try again?

@situchan
Copy link
Contributor

situchan commented Nov 7, 2023

@robertjchen I reproduced on main after logout and re-login. Bug is still valid. So happens when iou data doesn't exist in Onyx.

iou?.transactionID || ''

@dukenv0307 we should not return empty string. It will pull all transactions.
Please use this as solution

Copy link

melvin-bot bot commented Nov 7, 2023

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@dukenv0307
Copy link
Contributor

dukenv0307 commented Nov 7, 2023

The PR will be ready to review a little later because on the later main I can't access to Participant Page by deep link. It seems It is another bug. I am investigating

Screenshot 2023-11-07 at 20 01 14

@situchan
Copy link
Contributor

situchan commented Nov 7, 2023

@dukenv0307 It would be good if we can fix that as well but if not sooner, maybe you can just pinpoint the offending PR which caused that 2nd crash so that author can work on that.
Seems related to navigation.

@robertjchen
Copy link
Contributor

Thanks! Let me know if you're able to test this now 🙏

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Nov 8, 2023
@dukenv0307
Copy link
Contributor

@situchan The PR is ready for review: #30961

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Nov 8, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 10, 2023
@melvin-bot melvin-bot bot changed the title [$500] The app crashes when taping on link https://staging.new.expensify.com/request/new/participants [HOLD for payment 2023-11-17] [$500] The app crashes when taping on link https://staging.new.expensify.com/request/new/participants Nov 10, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 10, 2023
Copy link

melvin-bot bot commented Nov 10, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 10, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@robertjchen
Copy link
Contributor

Looks like this feel through the cracks, let me find someone here to handle the next steps. Thanks for your patience!

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2023
@conorpendergrast conorpendergrast added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 21, 2023
Copy link

melvin-bot bot commented Nov 21, 2023

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 21, 2023

This comment was marked as off-topic.

@conorpendergrast
Copy link
Contributor

conorpendergrast commented Nov 21, 2023

@peterdbarkerUK this wasn't labelled with Bug when it was created, and is due payment now (Bobby mentioned it via Slack)!

@peterdbarkerUK
Copy link
Contributor

Payment summary:

$500 to @dukenv0307 (contributor)
$500 to @situchan (C+ / reviewer)

Job closed on UpWork. Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

9 participants