Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Participants screen briefly shown and distance page opens few times after opening link #30936

Closed
2 of 6 tasks
kbecciv opened this issue Nov 7, 2023 · 10 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Nov 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #28308

Action Performed:

  1. Open the app
  2. Tap FAB > Request money > Distance
  3. Navigate to https://staging.new.expensify.com/request/new/participants

Expected Result:

User is navigated to the distance request page

Actual Result:

Participants screen briefly shown and distance page opens few times after opening link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1

Bug6266675_1699316358218.video_2023-11-06_18-09-36.mp4

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Nov 7, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Nov 7, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcaaron
Copy link
Contributor

This is the only PR that obviously looks related to deep linking:

https://github.com/Expensify/App/pull/29636/files

@marcaaron
Copy link
Contributor

It doesn't really seem like it would be touching this distance request code flow though.

@marcaaron
Copy link
Contributor

I'm gonna demote this one for the following reasons:

  1. The problem is only affecting native apps
  2. The bug is only reproducible if you do something "weird"
  3. Deep linking to the participants page is kind of "holding it wrong". I can't think of a clear reason why someone would actually do that.

@marcaaron marcaaron removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 7, 2023
@marcaaron marcaaron removed their assignment Nov 7, 2023
@marcaaron marcaaron added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 7, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@marcaaron marcaaron added the Daily KSv2 label Nov 7, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Nov 9, 2023
Copy link

melvin-bot bot commented Nov 13, 2023

@muttmuure Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Nov 13, 2023

@muttmuure Huh... This is 4 days overdue. Who can take care of this?

@muttmuure
Copy link
Contributor

Going to close and we can reopen if a real user hits this

@melvin-bot melvin-bot bot removed the Overdue label Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants