Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Held on 28618] [$500] IOU - User navigates to Money Request page when refresh Category page and go Back #30984

Closed
2 of 6 tasks
kbecciv opened this issue Nov 7, 2023 · 30 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented Nov 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.96.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Navigate to any conversation
  3. Click + button > Request Money> Scan
  4. Upload a receipt
  5. Click on Category field
  6. Refresh the page
  7. Click Back button on IOU screen

Expected Result:

User should be navigated back to the Final confirmation screen

Actual Result:

User navigates to Money Request page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6267235_1699357585440.Recording__1337.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018d1dbb7f19dde814
  • Upwork Job ID: 1721860229053939712
  • Last Price Increase: 2023-12-05
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 7, 2023
@melvin-bot melvin-bot bot changed the title IOU - User navigates to Money Request page when refresh Category page and go Back [$500] IOU - User navigates to Money Request page when refresh Category page and go Back Nov 7, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018d1dbb7f19dde814

Copy link

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 7, 2023
Copy link

melvin-bot bot commented Nov 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 7, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@kbecciv
Copy link
Author

kbecciv commented Nov 7, 2023

Similar issue reported here

@dukenv0307
Copy link
Contributor

dukenv0307 commented Nov 7, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

User navigates to Money Request page when refresh Category page and go Back

What is the root cause of that problem?

Note that, when reloading the receipt file is removed from the browser. When clicking back button, the App redirect to the confirmation page.

if (!file) {
Navigation.goBack(ROUTES.MONEY_REQUEST.getRoute(iouType, reportID));

And Because the file is lost. The App will redirect to the scan screen

What changes do you think we should make in order to solve the problem?

When the file is lost we only should remove the thumbnail receipt in the confirmation page instead of navigating back to scan screen like this

if (!file) {
Navigation.goBack(ROUTES.MONEY_REQUEST.getRoute(iouType, reportID));

IOU.setMoneyRequestReceipt('', '');

What alternative solutions did you explore? (Optional)

@FitseTLT
Copy link
Contributor

FitseTLT commented Nov 7, 2023

Similar issue reported here

Nope. That is not the same issue.

@erquhart
Copy link
Contributor

erquhart commented Nov 7, 2023

This should be solved by #30884, same solution proposed: #30884 (comment)

@melvin-bot melvin-bot bot added the Overdue label Nov 9, 2023
Copy link

melvin-bot bot commented Nov 10, 2023

@Ollyws, @anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

1 similar comment
Copy link

melvin-bot bot commented Nov 10, 2023

@Ollyws, @anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Nov 14, 2023

@Ollyws, @anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@Ollyws
Copy link
Contributor

Ollyws commented Nov 14, 2023

Might want to hold this one on #28618 as this entire flow is being re-factored.

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2023
Copy link

melvin-bot bot commented Nov 14, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

@Ollyws, @anmurali Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Nov 21, 2023

@Ollyws @anmurali this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Nov 21, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Nov 22, 2023

@Ollyws, @anmurali Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Nov 24, 2023

@Ollyws, @anmurali 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Nov 28, 2023

@Ollyws @anmurali this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

Copy link

melvin-bot bot commented Nov 28, 2023

@Ollyws, @anmurali 12 days overdue. Walking. Toward. The. Light...

Copy link

melvin-bot bot commented Nov 28, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@anmurali anmurali changed the title [$500] IOU - User navigates to Money Request page when refresh Category page and go Back [Held on 28618] [$500] IOU - User navigates to Money Request page when refresh Category page and go Back Nov 29, 2023
@anmurali
Copy link

Held on #28618

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 29, 2023
Copy link

melvin-bot bot commented Dec 4, 2023

@Ollyws, @anmurali Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 5, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Dec 5, 2023

@Ollyws @anmurali this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is today
  • If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Dec 5, 2023
Copy link

melvin-bot bot commented Dec 5, 2023

Current assignee @Ollyws is eligible for the Internal assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Dec 6, 2023

@Ollyws, @anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Copy link

melvin-bot bot commented Dec 8, 2023

@Ollyws, @anmurali 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Dec 12, 2023

@Ollyws, @anmurali 12 days overdue now... This issue's end is nigh!

@anmurali
Copy link

Closing this as it is a dupe of #30884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

6 participants