[$500] Android - Chat - Keyboard does not pull up when editing the message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Found when executing PR : #30669

Version Number: v1.3.96-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to staging.new.expensify.com
2. Open any chat.
3. Send a message.
4. Long press on the message.
5. Tap Edit message.

Expected Result:

The keyboard will pull up.

Actual Result:

The edit composer is focused but the keyboard does not pull up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6267190_1699355804164.Screen_Recording_20231107_121932_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011928df9e6f1e55ee
• Upwork Job ID: 1721869358457446400
• Last Price Increase: 2023-11-07

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011928df9e6f1e55ee

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[izarutskaya]

Not reproducible in production

Screen_Recording_20231107_112754_New.Expensify.mp4

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The edit composer is focused but the keyboard does not pull up.

What is the root cause of that problem?

In here, we're having the focusing logic after the delay, which works well for all platforms. However, recently this focus logic is added to fix a bug. But we didn't use the correct focus function above, so it causes the flickering and keyboard not open issue before triggering .focus directly does not work for Android

What changes do you think we should make in order to solve the problem?

Use this correct focus function in here rather than triggering the .focus() manually on the component.

We might need to move this scroll logic to inside focusComposerWithDelay as well

What alternative solutions did you explore? (Optional)

Calling these focus and scrollTop only on iOS and mWeb (the platforms where that code is supposed to fix)

[cristipaval]

Thanks, @dukenv0307 for the proposal. What happens if the user taps again on the input field? Does the keyboard show up? I would like to know if removing the deploy blocker label and fixing it without rushing makes sense.

[dukenv0307]

What happens if the user taps again on the input field? Does the keyboard show up?

@cristipaval if the user taps again, the keyboard does show up. It's very inconvenient though, when the user edit any message, they have to tap like that.

[cristipaval]

Alright, thanks @dukenv0307!

Given that the keyboard shows up if the user explicitly taps on the input field, I'll consider this a minor issue that shouldn't block the deployment. I just removed DeployBlockerCash label.

[cristipaval]

@mananjadhav could you please check if the proposed solution works?

[melvin-bot]

@mananjadhav, @alexpensify, @cristipaval Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mananjadhav]

I think @dukenv0307's proposal will work. Will have to make sure scrollTop shouldn't impact the composer.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Current assignee @cristipaval is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[aimane-chnaif]

This was deploy blocker. What's offending PR?

[tsa321]

The follow up PR #31041 is already merged to fix the keyboard issue in android...

[cristipaval]

The follow up PR #31041 is already merged to fix the keyboard issue in android...

Thanks @tsa321 , I'll close the issue then.

[alexpensify]

Thanks for your help @cristipaval!