[HOLD for payment 2023-12-08] [$500] Chat - Page scrolls to the middle conversation when collapse expended compose box

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.96-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Navigate to any chat
3. Enter 10 or more lines of text so the scroller is visible
4. Click on double-arrow button to expand the text
5. Click on double-arrow button to collapse the text

Expected Result:

Last bottom lines should be visible and vertical scroller should be down to the latest message

Actual Result:

Page scrolls to the middle conversation when collapse expended compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6267412_1699365938087.Recording__1332.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018067138b68673af0
• Upwork Job ID: 1721908499530989568
• Last Price Increase: 2023-11-07
• Automatic offers:
• tienifr | Contributor | 27651162

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018067138b68673af0

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[NisargDeveloper]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Page scrolls in the middle of a conversation. It scroll should be in the end and shows the latest messages.

What is the root cause of that problem?

It seems we don't have the css property.

.your-text-box {
  overflow-y: scroll;
  scroll-behavior: smooth;
}

Once we have overflow-y: scroll. It will stay in the end no matter how big the text-box is.

What changes do you think we should make in order to solve the problem?

We have to add

 .your-text-box {
  overflow-y: scroll;
  scroll-behavior: smooth;
}

in the css property.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Page scrolls to the middle conversation when collapse expended compose box

What is the root cause of that problem?

In

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.js

Line 595 in 9b53463

style={[styles.textInputCompose, isComposerFullSize ? styles.textInputFullCompose : styles.flex4, styles.verticalAlignTop]}

We change the style of input based on isComposerFullSize (is expanded or not). It's the inconsistency because we just set maxHeight:100% when the input is expanded -> That make input scroll works unexpectedly

What changes do you think we should make in order to solve the problem?

we should add maxHeight:100% along with styles.flex4 when isComposerFullSize is false

 style={[styles.textInputCompose, isComposerFullSize ? styles.textInputFullCompose : {
                        ...styles.flex4,
                        maxHeight:'100%'
                    }]}

Result

Screen.Recording.2023-11-07.at.23.24.53.mov

[Christinadobrzyn]

I can reproduce - I think this can be external. I swear I've seen this issue reported already but I can't find it.

[Christinadobrzyn]

@rushatgabhane we have a few proposals, would you be able to give a review?

[Christinadobrzyn]

DMing @rushatgabhane for a review of the proposals

[rushatgabhane]

I like @tienifr's proposal
It fixes the root cause, so it tests well even when cursor is at start / middle

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @chiragsalian, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[chiragsalian]

Proposal LGTM, feel free to create the PR @tienifr.

[melvin-bot]

📣 @rushatgabhane Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Christinadobrzyn]

I'm going ooo until Monday Nov 27th so going to assign another BZ teammate to monitor this until I'm back. Thanks!

status: reviewing PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Page scrolls to the middle conversation when collapse expended compose box #31298

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @tienifr requires payment offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/352202

[Christinadobrzyn]

prepping for payment!

Payouts due:

Issue Reporter: NA
Contributor: $500 @tienifr (Paid in Upwork)
Contributor+: $500 @rushatgabhane (in NewExpensify)

Eligible for 50% #urgency bonus? N

Upwork job is here

@rushatgabhane do we need a regression test for this?

[Christinadobrzyn]

No regressions so paying this out @tienifr I paid you based on this payment summary.

@rushatgabhane can you let us know about any regression tests? Thanks!

[Christinadobrzyn]

nudge - @rushatgabhane can you let us know about any regression tests?

[Christinadobrzyn]

nudge @rushatgabhane - do we need a regression test?

[melvin-bot]

@chiragsalian, @rushatgabhane, @Christinadobrzyn, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@chiragsalian, @rushatgabhane, @Christinadobrzyn, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rushatgabhane]

on this

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: It seems that this bug was always present. I can't point a specific PR that caused this

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A.

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

4. Determine if we should create a regression test for this bug. Sure!

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

   1. On web, go to any chat
   2. In the composer, write at least 20 lines of comment.
   3. Place the cursor at the end
   4. Expand the composer
   5. Verify that the cursor is at end of composer

[rushatgabhane]

manual request here - https://staging.new.expensify.com/r/5195421093804697

[Christinadobrzyn]

Awesome! thanks @rushatgabhane! I created the regression test GH - https://github.com/Expensify/Expensify/issues/352202

Closing this!

[JmillsExpensify]

$500 payment approved for @rushatgabhane based on this comment.