Update MoneyRequestView.js

[cead22]

• Design Doc
• Let's update MoneyRequestView.js
  • The following should only apply to users in the violations beta
  • Let's add a connection to the transactionViolations and policyCategories Onyx collections as shown in the code snippet below, which will go in the withOnyx section of the code at the bottom
  • Let's add the new onyx key for the transaction violation collection
  • Add a new transactionViolation prop
  • Pass the transactionViolation to the MoneyRequestView function
  • For each field that can have a violation, Inside OfflineWithFeedback and below MenuItemWithTopDescription let's add a View that wraps a Text component to show the violation text, as shown in the snippet below
    • The fields are merchant, amount, category, date, tag, comment, billable, receipt, and tax
  • Fields with violations that go into a new page, like a list page for the cate of category and description for instance, should show a RBR circle to the right, in front of the caret >. Screenshots below

withOnyx({
    …
    policyCategories: {
        key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY_CATEGORIES}${report.policyID}`,
    },
    transactionViolation: {
        key: ({report}) => {
            const parentReportAction = ReportActionsUtils.getParentReportAction(report);
            const transactionID = lodashGet(parentReportAction, ['originalMessage', 'IOUTransactionID'], 0);
            return `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`;
        },
    },
...

{Boolean(ViolationUtils.getViolationForField(transactionViolation, 'amount')) && (
    <View>
        <Text style={[styles.ph5, styles.textLabelError]}>{ViolationUtils.getViolationForField(transactionViolation, 'amount')}</Text>
    </View>
)}

[cead22]

@lindboe @cdanwards can you please comment here so I can assign you?

(@NicMendonca sorry about that ping, that was a mistake)

[cdanwards]

Commenting for assignment

[cdanwards]

@cead22 I'm unable to see the 2 images listed at the end of the ticket description, do you mind providing screenshots?

[cead22]

Can you try refreshing the page? GH adds a token to the image URLs and if you had this tab open before or you opened a cached version of this page, the token may not work. Let me know if that still doesn't work

[lindboe]

@cead22 Refreshing doesn't seem to work.

I'm not familiar with this token idea? The URL that I see that it is opening in my browser is https://github.com/Expensify/Expensify/assets/165133/557c3ea2-a268-4415-8331-0e5963b20a2c, if it helps. I know we don't have access to that particular repo.

[trevor-coleman]

@cead22 -- In you description you list:

For each field that can have a violation, Inside OfflineWithFeedback and below MenuItemWithTopDescription let's add a View that wraps a Text component to show the violation text, as shown in the snippet below

• The fields are merchant, amount, category, date, tag, comment, billable, receipt, and tax

There doesn't appear to be a tax field in this view. Should the tax warning go on the amount?

[melvin-bot]

📣 @trevor-coleman! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[cead22]

There doesn't appear to be a tax field in this view. Should the tax warning go on the amount?

No, the tax ones will go into the tax field once we have it. You can ignore that field for now

[trevor-coleman]

As we discussed here it's possible to have multiple violations per field.

How should we handle that.

I can see two ways to do it:

(for examples assume violations is the array of translated violation names) :

1. Iterate over the array and map to individual text components :

<View>
    {violations.map((violation) =>(<Text key={violation} ... >{violation}</Text>)}
</View>

2. Join the members of the array with a comma in the text field:

        <Text ... >{violations.join(', ')}</Text>
)}

[cead22]

Let's go with 1. Every field except for receipt will only have 1 violation, and for the receipt ones, we want to show them one below the other, not separated by commas. Does that make sense?

[trevor-coleman]

Perfect thanks.

[cead22]

Off hold

[melvin-bot]

This issue has not been updated in over 15 days. @cdanwards eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[cdanwards]

@trevor-coleman is working on this.

[trevor-coleman]

Yeah it's done just need to update to match the changes from ViolationUtils and the PR will be up today.

[trevor-coleman]

Sorry this will take a bit longer, I'm used to being able to make PRs when the code is ready, but completing the checklist will take some time -- probably the rest of today at least.

[trevor-coleman]

PR is up: #32594

[melvin-bot]

This issue has not been updated in over 15 days. @cead22, @cdanwards eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[cdanwards]

PR has been merged

[aimane-chnaif]

@cead22 C+ payment is pending here. Can you please reopen?

[melvin-bot]

Triggered auto assignment to @MitchExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[MitchExpensify]

Payment summary:

C+: $500 @aimane-chnaif (Upwork job here)

[cead22]

Can we close?

[aimane-chnaif]

Not yet

[MitchExpensify]

Paid, contract ended, sorry for the delay!