[HOLD for payment 2023-11-27] Personal details - City and Postcode fields are not populated with suggested address

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.97.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to Settings > Profile > Personal details.
3. Click Address.
4. Enter Terrance Street in Address line 1.
5. Select the result with Fort Worth as the City.

Expected Result:

City and Postcode fields will be populated.

Actual Result:

City and Postcode fields are not populated.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269381_1699489904055.20231109_081104.mp4

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

City and Postcode fields are not populated with suggested address

What is the root cause of that problem?

We always clear other fields when a field is changed

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Line 141 in dee9b31

const handleAddressChange = useCallback((value, key) => {

What changes do you think we should make in order to solve the problem?

We should add a new param like isSuggestedAddress with default value as false, we will not clear other fields if it is true. And then here we will pass this param as true. We should add an extra prop like fieldsPreventDefault that will contain a list field that we will call onValueChange instead of onInputChange

if (props.fieldsPreventDefault.includes(inputKey)) {
    props.onValueChange(value, inputKey, true);
} else {
    props.onInputChange(value, inputKey);
}

App/src/components/AddressSearch/index.js

Line 274 in dee9b31

props.onInputChange(value, inputKey);

And change defaultValue here to value prop

App/src/pages/settings/Profile/PersonalDetails/AddressPage.js

Line 233 in dee9b31

defaultValue={state}

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2023-11-09.at.10.20.37.mov

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Personal details - City and Postcode fields are not populated with suggested address

What is the root cause of that problem?

Currently in address page

• when we change the country we will reset state, city, zipcode to empty
• when we change the state we will reset city, zipcode to empty
• when we change the city we will reset zipcode to empty

When we update address line 1, all fields will be updated in order to: country, city, zipCode, state

zipcode and city fields is updated before state field, so that when state field is updated the App will reset zipcode and city

What changes do you think we should make in order to solve the problem?

When we update address line 1, all fields should be updated in order to: country, state, city, zipCode
To do that in here

App/src/components/AddressSearch/index.js

Lines 231 to 239 in dee9b31

	country: '',
	// When locality is not returned, many countries return the city as postalTown (e.g. 5 New Street
	// Square, London), otherwise as sublocality (e.g. 384 Court Street Brooklyn). If postalTown is
	// returned, the sublocality will be a city subdivision so shouldn't take precedence (e.g.
	// Salagatan, Upssala, Sweden).
	city: locality || postalTown || sublocality || cityAutocompleteFallback,
	zipCode,
	state: state || stateAutoCompleteFallback,

Should move the state field to before city field like this

            country: '',
            state: state || stateAutoCompleteFallback,
            city: locality || postalTown || sublocality || cityAutocompleteFallback,
            zipCode,

What alternative solutions did you explore? (Optional)

[bernhardoj]

Regression from #30831?

[robertKozik]

@DylanDylann please ping me if you will have the fix for this regression 🙇🏼

[DylanDylann]

@robertjchen Please help to check this one #31091 (comment). Because this issue have another RCA, I don't notice that It is regression from our PR

[lakchote]

@DylanDylann I've just tested to revert your PR and I don't have the problem anymore, so it looks like it's a regression.

You can test it doing git revert --no-commit 040c8a7

[DylanDylann]

Agree it is a regression. I mean Because this issue have another RCA, I miss to check if It is regression from our PR

[robertjchen]

Yes, it appears to be a regression from #30304 I believe the procedure here is to close this out and address it in the original issue?

[lanitochka17]

Issue reproducible on latest build 1.3.99-0

RPReplay_Final1700002195.MP4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.0-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: re-order fields in address page #31173

If no regressions arise, payment will be issued on 2023-11-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @robertKozik does not require payment (Contractor)
• @DylanDylann requires payment