[WAITING ON CHECKLIST][HOLD for payment 2023-11-21] [$500] Attachment - File name is placed on the left of the preview page if add docx and mp4.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.3.97-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any Gmail account.
3. Open 1:1 conversation, click on the + button in the compose box.
4. Click on add attachment.
5. Upload docx or mp4.

Expected Result:

The file name is placed on the center of the preview page, if you add docx and mp4 attachments.

Actual Result:

The file name is placed on the left, not in the center of the preview page, if you add docx and mp4 attachments.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269647_1699516034118.docx_mp4.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a07e3cb1d6ca87c5
• Upwork Job ID: 1722549601357987840
• Last Price Increase: 2023-11-09

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a07e3cb1d6ca87c5

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[izarutskaya]

Not reproduced in production

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ZhenjaHorbach]

The same root cause and the same fix as in this ticket )
#31080
#31080 (comment)

Proposal

Please re-state the problem that we are trying to solve in this issue.

Attachment - File name is placed on the left of the preview page if add docx and mp4

What is the root cause of that problem?

Since we are not centering the element horizontally, this results in the element taking up all the available horizontal space

What changes do you think we should make in order to solve the problem?

we can update styles and add alignItems:'center' here to center an element and limit its width

App/src/components/AttachmentModal.js

Line 449 in 01759d1

<View style={[styles.flex1, styles.attachmentCarouselContainer]}>

What alternative solutions did you explore? (Optional)

NA

Before

After

[zoosphar]

Contributor details
Your Expensify account email: [email protected] (Google Login)
Upwork Profile Link: https://www.upwork.com/freelancers/~01abab5becc21fb0d8

Hello,
I figured out why the issue is occurring and also did a temporary fix, PFB the screenshot of the same

This could be a basic conditional and styling error, where the code is not covering all the cases which includes mp4 and docx files.

[melvin-bot]

📣 @zoosphar! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Beamanator]

@zhongweizhou522 please send another email to [email protected], please don't post in GH issues for slack access 🙏

[Beamanator]

@zoosphar it doesn't look like you submitted a proposal, you just took a screenshot of your fix working? You'll need to submit a full proposal if you want to have the opportunity to work on this job

[Beamanator]

@ZhenjaHorbach the proposal you linked doesn't explain anything about why it would also fix this issue, can you please explain?

[Beamanator]

CPing fix PR

• This successfully made it to staging - https://github.com/Expensify/App/actions/runs/6815566820

[puneetlath]

Confirmed it's fixed!

[jliexpensify]

Payment Summary

• C+: @Santhosh-Sellavel $500 (New.Dot request)

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Move View wrapper to AttachmentViewPdf #31130

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Move View wrapper to AttachmentViewPdf #31130

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel does not require payment (Eligible for Manual Requests)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Oh weird, 2 payment dates! Bump @Santhosh-Sellavel to complete the checklist please.

[jliexpensify]

Payment Summary here

[zoosphar]

@zoosphar it doesn't look like you submitted a proposal, you just took a screenshot of your fix working? You'll need to submit a full proposal if you want to have the opportunity to work on this job

Hey @Beamanator
I did submit a proposal on Upwork for the same and didn't get any reply on Upwork. Can you tell me if I missed anything to take care of in future?

Here is the proposal I submitted

[jliexpensify]

@zoosphar as stated in our Contributing.MD, all proposals must use the template and be posted in the GitHub issue, not Upworks.

[jliexpensify]

Bump @Santhosh-Sellavel to complete the checklist. Thanks!

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: fix: pdf send attachment regression #30995
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: pdf send attachment regression #30995 (comment)
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. I guess N/A as it's caught by Applause should be part of basic cases
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Great, thanks Santhosh - closing.

Reference for New.Dot payments

[JmillsExpensify]

$500 payment approved for @Santhosh-Sellavel based on this comment.