[HOLD for payment 2023-11-22] [HOLD for payment 2023-11-21] Distance - Distance request creation is looped

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30920

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to + > Request money > Distance
3. Enter address for Start and Finish point
4. Click Next

Expected Result:

User is able to proceed to workspace selection page

Actual Result:

User is redirected back to the address page. The process is looped

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271543_1699637504142.20231111_011031.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @marcochavezf

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[paultsimura]

This looks like a regression from #28866

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Lines 64 to 66 in 31ec933

	const waypoints = lodashGet(transaction, 'comment.waypoints', {});
	const validatedWaypoints = TransactionUtils.getValidWaypoints(waypoints);
	const isInvalidWaypoint = lodashSize(validatedWaypoints) < 2;

An empty transaction is passed into this component now from withOnyx. Debug data:

[garrettmknight]

Reproduced

[marcochavezf]

Also reproduced the error locally on latest main, checking

[marcochavezf]

This looks like a regression from #28866

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Lines 64 to 66 in 31ec933

	const waypoints = lodashGet(transaction, 'comment.waypoints', {});
	const validatedWaypoints = TransactionUtils.getValidWaypoints(waypoints);
	const isInvalidWaypoint = lodashSize(validatedWaypoints) < 2;

An empty transaction is passed into this component now from withOnyx. Debug data:

Seems the latest withOnyx changes in the linked PR are returning the transaction object as empty

[marcochavezf]

Phew, there are quite changes in Onyx and it's a bit hard to track where exactly this was introduced. I'm leaning towards reverting the offending PR then we can figure out what introduced this regression.

[puneetlath]

Maybe we can start a slack thread and bring Tim into the discussion to see if he can help.

[marcochavezf]

Sounds good, posted here

[situchan]

The root cause was already explained here.
So this is 2nd unexpected behavior. We really need to fix this in Onyx repo.
cc: @tgolen

[marcochavezf]

Also we're sending the all the reports instead of a report in NewDistanceRequestPage:

[situchan]

Also we're sending the all the reports instead of a report in NewDistanceRequestPage:

That seems like pre-existed bug.
That will happen when lodashGet(route, 'params.reportID') is empty string

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[dylanexpensify]

bump @garrettmknight @marcochavezf this is def a bug/deploy blocker!

[situchan]

This is fixed on staging. We can close the issue

[marcochavezf]

PR was CP to staging and confirmed the distance request issue is fixed

Screen.Recording.2023-11-13.at.12.48.08.p.m.mov

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.98-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Remove duplicate withOnyx calls" #31231

If no regressions arise, payment will be issued on 2023-11-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcochavezf] The PR that introduced the bug has been identified. Link to the PR:
• [@marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@marcochavezf] Determine if we should create a regression test for this bug.
• [@marcochavezf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.99-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Remove duplicate withOnyx calls" #31231

If no regressions arise, payment will be issued on 2023-11-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcochavezf] The PR that introduced the bug has been identified. Link to the PR:
• [@marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@marcochavezf] Determine if we should create a regression test for this bug.
• [@marcochavezf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: