[HOLD for payment 2023-11-30] [$500] Web - Chat - 'Uh-oh, something went wrong!' is displayed after clicking Chat bubble

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Logout out of NewDot
2. Login to OD Expensify
3. Click the message bubble in the bottom right
4. Verify a new tab opens and you are brought to the NewDot concierge chat

Expected Result:

NewDot concierge chat is displayed without error

Actual Result:

A new tab opens and user is brought to the NewDot Expensify, but 'Uh-oh, something went wrong!' page is displayed
Uh-oh, something went wrong!
If the problem persists, reach out to [email protected]

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271744_1699646759385.2023-11-10_22-00-24.mp4

log.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017b417e0df7589f4a
• Upwork Job ID: 1723074016090570752
• Last Price Increase: 2023-11-10

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017b417e0df7589f4a

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[zukilover]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Something went wrong when transitioning from OldDot to NewDot

What is the root cause of that problem?

App is trying to execute a filter operation on array that does not exist:

App/src/libs/ReportActionsUtils.ts

Lines 463 to 465 in 4f345f8

	function getFirstVisibleReportActionID(sortedReportActions: ReportAction[], isOffline: boolean): string {
	const sortedFilterReportActions = sortedReportActions.filter((action) => !isDeletedAction(action) || (action?.childVisibleActionCount ?? 0) > 0 || isOffline);
	return sortedFilterReportActions.length > 1 ? sortedFilterReportActions[sortedFilterReportActions.length - 2].reportActionID : '';

This results in: ReportActionsUtils.ts:458 Uncaught TypeError: sortedReportActions.filter is not a function error.

What changes do you think we should make in order to solve the problem?

Add default value for the sortedReportActions argument:

function getFirstVisibleReportActionID(sortedReportActions: ReportAction[] = [], isOffline: boolean): string {

What alternative solutions did you explore? (Optional)

N/A

[Juggernaut-98]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Chat - 'Uh-oh, something went wrong!' is displayed after clicking Chat bubble

1. Logout out of NewDot
2. Login to OD Expensify
3. Click the message bubble in the bottom right
4. Verify a new tab opens and you are brought to the NewDot concierge chat

What is the root cause of that problem?

By looking at console error it is evident that problem is in following function

 function getFirstVisibleReportActionID(sortedReportActions: ReportAction[], isOffline: boolean): string { 
     const sortedFilterReportActions = sortedReportActions.filter((action) => !isDeletedAction(action) || (action?.childVisibleActionCount ?? 0) > 0 || isOffline); 
     return sortedFilterReportActions.length > 1 ? sortedFilterReportActions[sortedFilterReportActions.length - 2].reportActionID : ''; 

It seems like while calling the function some null/undefined value is being passed down for sortedReportActions param,

What changes do you think we should make in order to solve the problem?

We can paste a check inside getFirstVisibleReportActionIDfunction to verify if the value passed for sortedReportActions is a valid array and only then execute the logic.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

📣 @Juggernaut-98! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Juggernaut-98]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/tayyabathar

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[allroundexperts]

@zukilover's proposal works well!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[deetergp]

Another solid proposal, @zukilover. Thanks!

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @zukilover You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[zukilover]

PR is ready #31294

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 31208 - Fix app error on chat bubble click from OD #31294

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @zukilover requires payment
• @allroundexperts does not require payment (Eligible for Manual Requests)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment summary:

• $500 @allroundexperts C+ NewDot
• $500 @zukilover C Upwork

[allroundexperts]

Checklist

1. Fix: Two line markers appear for a second #25554
2. https://github.com/Expensify/App/pull/25554/files#r1405479473
3. I don't think a Slack discussion is needed here. Thorough testing would have prevented this.
4. A regression test would be helpful. The steps mentioned in the OP look clear enough to me!

[deetergp]

Thank you for the update @allroundexperts 👍 @lanitochka17 Can we add your reproduction steps to the regression tests?

[MitchExpensify]

Upwork offer sent for payment, @zukilover. Lemme know when you accept 👍

Added QA test update request here https://github.com/Expensify/Expensify/issues/343043

[zukilover]

@MitchExpensify accepted, thank you.

[MitchExpensify]

Paid and contract ended!

[JmillsExpensify]

$500 payment approved for @allroundexperts based on this comment.