[$500] Android-Workspace-In reimbursement page, WS name truncated in different way compared to other pages

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Launch app
2. Tap profile icon
3. Tap Workspaces--Workspace
4. Tap New Workspace
5. Tap Workspace
6. Enter name - Test Workspace testingtestingtestingtestingtestingtesting)
7. Tap Save
8. Tap card/Members/Bills/Travels/Members
9. Note Workspace name in header is truncated in same format (Test Workspac...)
10. Tap reimbursements
11. Note the truncated format of Workspace name in header is different from other pages (Test Workspace testingtesti...)

Expected Result:

In all pages, Workspace name in header must be truncated and displayed in the same manner.

Actual Result:

In card/Members/Bills/Travels/Members page, Workspace name in header is truncated in same format (Test Workspac...). But in reimbursements page, the truncated format of Workspace name in header is different from other pages (Test Workspace testingtesti...).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6276960_1700031517788.reimbursement.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015ab700b1fc46d0d1
• Upwork Job ID: 1724762358824095744
• Last Price Increase: 2023-11-15
• Automatic offers:
• dukenv0307 | Contributor | 27705715

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015ab700b1fc46d0d1

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In card/Members/Bills/Travels/Members page, Workspace name in header is truncated in same format (Test Workspac...). But in reimbursements page, the truncated format of Workspace name in header is different from other pages (Test Workspace testingtesti...).

What is the root cause of that problem?

The width of those subtitle components are different, so it truncates differently.

The width are different because in here, we only set max-width 100, so the actual width of that whole component will depend on the width of the text of title and subtitle. The Reimbursements text is longer than Cards text, so the width of the View wrapper of Reimbursements text is longer than that of Cards text.

What changes do you think we should make in order to solve the problem?

Change mw100 to w100 to the wrapper of those subtitle components here.

We've had these issues many times in the past in other components and w100 was always the way to maintain consistency across platforms.

What alternative solutions did you explore? (Optional)

If this issue happens for other places, it can be fixed similarly. We particularly need to look at all usage of mw100 to make sure this problem doesn't happen there.

Alternatively, adding styles.flex1 should also work.

[mananjadhav]

Bug is straightforward @dukenv0307's proposal looks good.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[deetergp]

Agreed! Adding @dukenv0307…

[mananjadhav]

@deetergp Accidentally closed this?

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[deetergp]

Nice catch @mananjadhav — I'm not sure how that happened 😅 I think everything looks in order now. Thanks!

[dukenv0307]

@mananjadhav The PR is ready for review

[mananjadhav]

@izarutskaya @dukenv0307 @isabelastisser Are you folks able to reproduce this in the latest version. I can't.

android-workspace-name.mov

[mananjadhav]

@isabelastisser @izarutskaya Did you folks get a chance to look at my previous comment? Are you still able to reproduce this?

And @dukenv0307 I raised a comment on the PR.

[isabelastisser]

@mananjadhav, I can no longer reproduce this! Should I close the issue since it seems to be fixed?

@deetergp, how should I handle the payments in this case?

[mananjadhav]

Waiting on @deetergp to confirm about the payouts.

[isabelastisser]

Hey @deetergp, can you please see my comment above? Thanks!

[deetergp]

Hey @isabelastisser I had to ask myself, but it sounds like the right thing to do in this situation is to pay out the contributor and C+ for the work done as the problem being fixed elsewhere is out of their control.

[isabelastisser]

Thanks, Scott! I sent the offers in Upwork now. All set!

[mananjadhav]

@isabelastisser I raise my request on NewDot. Can you please rescind the Upwork offer for me and instead post a payment summary here?

[isabelastisser]

Payment summary:

@mananjadhav $500 - C+ review (NewDot payment)
@dukenv0307 $500 - Accepted proposal (paid in Upwork)

[JmillsExpensify]

$500 payment approved for @mananjadhav based on summary above.