Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Web - When opening a receipt with a workspace from OD, a red dot appears. There is no error message if the receipt fails. #31364

Closed
1 of 6 tasks
kbecciv opened this issue Nov 15, 2023 · 46 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Nov 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.99.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1 Case:

  1. Create a WS from OD.
  2. Navigate to the workspace chat as the employee
  3. Select the option to Request money > Scan receipt
  4. Select the option to upload a receipt
  5. Upload a receipt file
  6. Click on Request
  7. Navigate to the request conversation
  8. Wait until the scan of the receipt is complete
  9. Once complete navigate to the request conversation

2 Case:

  1. Create a WS from OD.
  2. As the employee, navigate to the workspace chat
  3. Select Request money > Scan
  4. Upload a image of a blurry receipt
  5. Complete the money request
  6. After the scanned receipt shows a failure
  7. Navigate to the workspace chat
  8. Click on the preview to navigate to the report conversation

Expected Result:

1 Case:
Verify the amount is updated and displayed
Verify the merchant field is filled (this is only filled if the merchant is visible in the receipt picture)
2 Case:
Verify there's an error message indicating "receipt scanning failed. Please enter the details manually"

Actual Result:

1 Case:
Red dot appears when open a receipt if WS is from OD.
2 Case:
No error message indicating "receipt scanning failed. Please enter the details manually" if Receipt scan failed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Case 1

Bug6277400_1700051664117.Case_1_Red_dot.mp4

Case 2

Bug6277400_1700051664118.Case_2_No_error_message_indicating_receipt_scanning_failed.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014fcb884d4c1db2d5
  • Upwork Job ID: 1724773389816594432
  • Last Price Increase: 2024-01-31
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 15, 2023
@melvin-bot melvin-bot bot changed the title Web - When opening a receipt with a workspace from OD, a red dot appears. There is no error message if the receipt fails. [$500] Web - When opening a receipt with a workspace from OD, a red dot appears. There is no error message if the receipt fails. Nov 15, 2023
Copy link

melvin-bot bot commented Nov 15, 2023

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Nov 15, 2023

Job added to Upwork: https://www.upwork.com/jobs/~014fcb884d4c1db2d5

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 15, 2023
Copy link

melvin-bot bot commented Nov 15, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 15, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

@akinwale, @kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

@keisyrzk
Copy link
Contributor

keisyrzk commented Nov 20, 2023

Investigation results:

case 1 - scanned receipt values
Tried with two different PDFs and the server returns "0.00" value starting from "ReportScreen" component.
Test example: params.reportID = 3241712811412309

the red dot is appearing because the report has smart scan errors. Looks like the smart scan have problems with scanning the provided PDF receipt file.
The hasMissingSmartscanFields returns true as:

  • hasReceipt(transaction) - true
  • !isDistanceRequest(transaction) - true
  • !isReceiptBeingScanned(transaction) - true
  • areRequiredFieldsEmpty(transaction) - true

no error message
The server response in this case is as follows:
[ { "amount": 0, "billable": false, "cardID": 18340638, "category": "", "comment": "", "created": "2023-11-20", "currency": "PLN", "filename": "w_e06bbd07a65bb1c6387e915a890cdbd50fa69f9e.pdf", "hasEReceipt": false, "merchant": "(none)", "modifiedAmount": 0, "modifiedCreated": "", "modifiedCurrency": "USD", "modifiedMerchant": "", "originalAmount": 0, "originalCurrency": "", "parentTransactionID": "", "receipt": { "receiptID": 674799630, "source": "https://www.expensify.com/receipts/w_e06bbd07a65bb1c6387e915a890cdbd50fa69f9e.pdf", "state": "SCANFAILED" }, "reimbursable": true, "reportID": "7288149649442128", "status": "Posted", "tag": "", "transactionID": "2258001490579795195" } ]

worth pointing that the scan failed
"state": "SCANFAILED"


Next Steps

  • Is there any acceptable receipt forms so the algorithm is able to scan it?
  • would recommend checking backend logic and the scanning algorithm as well

Copy link

melvin-bot bot commented Nov 20, 2023

📣 @keisyrzk! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@kevinksullivan
Copy link
Contributor

@akinwale can you take a look at the above?

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2023
Copy link

melvin-bot bot commented Nov 22, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@akinwale
Copy link
Contributor

@kevinksullivan It looks like this may be a backend issue, as observed in the post.

@melvin-bot melvin-bot bot added the Overdue label Nov 27, 2023
Copy link

melvin-bot bot commented Nov 27, 2023

@akinwale, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@kevinksullivan kevinksullivan added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Nov 27, 2023
Copy link

melvin-bot bot commented Nov 27, 2023

Current assignee @akinwale is eligible for the Internal assigner, not assigning anyone new.

@kevinksullivan
Copy link
Contributor

ah apologies for missing that, updating the label.

Copy link

melvin-bot bot commented Nov 27, 2023

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Copy link

melvin-bot bot commented Nov 29, 2023

@deetergp @akinwale @kevinksullivan this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@deetergp deetergp added the External Added to denote the issue can be worked on by a contributor label Dec 27, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 27, 2023
Copy link

melvin-bot bot commented Dec 27, 2023

Current assignee @akinwale is eligible for the External assigner, not assigning anyone new.

@deetergp deetergp removed the Overdue label Dec 27, 2023
Copy link

melvin-bot bot commented Dec 27, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 29, 2023
Copy link

melvin-bot bot commented Jan 1, 2024

@deetergp, @akinwale, @kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Jan 1, 2024

@deetergp, @akinwale, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

@deetergp
Copy link
Contributor

deetergp commented Jan 3, 2024

Still waiting on a proposal.

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
Copy link

melvin-bot bot commented Jan 3, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 5, 2024
Copy link

melvin-bot bot commented Jan 8, 2024

@deetergp, @akinwale, @kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

@deetergp
Copy link
Contributor

deetergp commented Jan 9, 2024

Since we're still waiting on a proposal, I am setting it to weekly.

@melvin-bot melvin-bot bot removed the Overdue label Jan 9, 2024
@deetergp deetergp added Weekly KSv2 and removed Daily KSv2 labels Jan 9, 2024
Copy link

melvin-bot bot commented Jan 10, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

1 similar comment
Copy link

melvin-bot bot commented Jan 17, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 18, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@deetergp
Copy link
Contributor

That's hopeful. If we get a second week of it not being reproducible, let's close it.

@melvin-bot melvin-bot bot removed the Overdue label Jan 19, 2024
Copy link

melvin-bot bot commented Jan 24, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

Copy link

melvin-bot bot commented Jan 31, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@deetergp
Copy link
Contributor

Hasn't been reproducible for 2 weeks, so let's close it.

@melvin-bot melvin-bot bot removed the Overdue label Jan 31, 2024
@deetergp deetergp closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants