Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] LHN - 1:1 conversation isn't appearing until you click on a direct link to it #31384

Closed
5 of 6 tasks
izarutskaya opened this issue Nov 15, 2023 · 44 comments
Closed
5 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@izarutskaya
Copy link

izarutskaya commented Nov 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.99.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

Prerequirements: Use accounts that never interacted before

  1. Device A: Navigate to https://staging.new.expensify.com/
    and log in
  2. Device B: Navigate to https://staging.new.expensify.com/
    and log in with a different account
  3. Device B: Create a new group chat with "Device A" and a few other participants
  4. Device B: Navigate to the group chat
  5. Device B: Do a split bill with all of the members
  6. Device A: Navigate to the LHN

Expected Result:

The 1:1 conversation only appears if you navigate to it through search or a direct link.

Actual Result:

An 1:1 conversation should appear on Device A as soon as Device B requests the split.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6277831_1700065024216.bandicam_2023-11-15_16-50-03-370.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01905b0dea2ec3236f
  • Upwork Job ID: 1724826305483014144
  • Last Price Increase: 2023-12-06
@izarutskaya izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 15, 2023
@melvin-bot melvin-bot bot changed the title LHN - 1:1 conversation isn't appearing until you click on a direct link to it [$500] LHN - 1:1 conversation isn't appearing until you click on a direct link to it Nov 15, 2023
Copy link

melvin-bot bot commented Nov 15, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01905b0dea2ec3236f

Copy link

melvin-bot bot commented Nov 15, 2023

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 15, 2023
Copy link

melvin-bot bot commented Nov 15, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Nov 15, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2023
@rojiphil
Copy link
Contributor

Looks like a BE issue as the 1:1 Chat Report has not yet come to FE

@jjcoffee
Copy link
Contributor

@rojiphil is partially correct, in the pusher event there are no reportActions for the 1:1 report. When you start searching for the 1:1 user, interestingly the chat pops up in the LHN! cc @NicMendonca - let's make this one internal!

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2023
@NicMendonca NicMendonca added Internal Requires API changes or must be handled by Expensify staff Engineering labels Nov 20, 2023
Copy link

melvin-bot bot commented Nov 20, 2023

Current assignee @jjcoffee is eligible for the Internal assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Nov 20, 2023

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Copy link

melvin-bot bot commented Nov 22, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Nov 24, 2023

@lakchote, @NicMendonca, @jjcoffee Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Nov 24, 2023
@lakchote
Copy link
Contributor

@NicMendonca I'm currently focusing on critical tasks could you assign it to someone else who have more bandwith please?

Copy link

melvin-bot bot commented Nov 24, 2023

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@NicMendonca
Copy link
Contributor

@MonilBhavsar going to close since this hasn't been reproducible. Please reopen if you end up being able to.

@lanitochka17
Copy link

Issue reproducible on the latest build 1.4.18-3

Recording.997.mp4

@lanitochka17 lanitochka17 reopened this Dec 28, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 28, 2023
@MonilBhavsar
Copy link
Contributor

Will look

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 28, 2023
Copy link

melvin-bot bot commented Jan 2, 2024

@NicMendonca, @jjcoffee, @MonilBhavsar Huh... This is 4 days overdue. Who can take care of this?

@MonilBhavsar
Copy link
Contributor

I am still not able to reproduce. I also dry ran through the code and confirmed that we're sending chat report in Onyx updates. https://github.com/Expensify/Web-Expensify/blob/2cb1b34034c3e44c156376e4421b4534c19015c7/lib/ReportAPI.php#L4764
Not sure what I am missing here.

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
@NicMendonca
Copy link
Contributor

Ok, lets close for now!

@kbecciv
Copy link

kbecciv commented Jan 5, 2024

Issue is reproducible for QA team, build 1.4.22.0

20240105_231638.mp4

@kbecciv kbecciv reopened this Jan 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 8, 2024
@MonilBhavsar
Copy link
Contributor

@kbecciv Is the user in #focus mode?

@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2024
@kbecciv
Copy link

kbecciv commented Jan 9, 2024

@MonilBhavsar No, it's "Most recent"

bandicam.2024-01-09.05-57-06-156.mp4

@melvin-bot melvin-bot bot added the Overdue label Jan 10, 2024
@MonilBhavsar
Copy link
Contributor

Thanks!
I'm dealing with waves issue. I'll circle back

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 11, 2024
@NicMendonca
Copy link
Contributor

@MonilBhavsar if this doesn't fall into a specific wave, then we can just close this for now, yeah?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 16, 2024
@MonilBhavsar
Copy link
Contributor

I'm pretty sure I'm missing some detail because Applause is able to reproduce and I am not.
I tried again and it worked as expected

Screenshot 2024-01-19 at 11 15 25 AM

The first unread is for Money Request
The second unread is for Group chat

Applause team, if you're consistently able to reproduce, could you please mention detailed steps. Seems like I'm missing something.

My steps are:

  1. As a user A start a new group chat with user B and user C
  2. Split bill in the group chat
  3. As a user B logged into another device ensure they get both group chat and money request updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

8 participants