[HOLD for payment 2024-01-17] [HOLD for payment 2023-12-15] [$500] Bank account - Fields with emojis are not turned red and general error message is shown

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR: #31259
Version Number: 1.3.99-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Open the app
2. Navigate to Workspace > Bank account > Connect manually
3. Enter routing and account number
4. Enter emojis in Legal name, address and city fields
5. Fill out the rest with test data and tap "Continue"

Expected Result:

The fields with emojis are highlighted in red and the error message to enter valid info is displayed

Actual Result:

The general error message "Auth SetupWithdrawalAccount returned an error" is displayed, and the fields are not turned red.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6277839_1700065315673.video_2023-11-15_10-41-07.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01087f0962c58f5f4a
• Upwork Job ID: 1724828495604215808
• Last Price Increase: 2023-11-15
• Automatic offers:
• tienifr | Contributor | 27782542

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01087f0962c58f5f4a

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank account - Fields with emojis are not turned red and general error message is shown

What is the root cause of that problem?

We did not verify if the value contains emoji to show the error

What changes do you think we should make in order to solve the problem?

We should use CONST.REGEX.EMOJIS (or extractEmojis function) to check if the text contain emoji, if yes, render the error

text.match(CONST.REGEX.EMOJIS);

then add this check here and other places if needed

Detail implementation:

To validate companyName and addressCity:

 if (values.companyName && !ValidationUtils.isValidLegalName(values.companyName)) {
            errors.companyName = 'bankAccount.error.companyName';
        }

if (values.addressCity && !ValidationUtils.isValidLegalName(values.addressCity)) {
            errors.addressCity = 'bankAccount.error.addressCity';
        }

To validate addressStreet, we already have function isValidAddress, we can change this line

to

if (!isValidLegalName(value)) {

What alternative solutions did you explore? (Optional)

Instead of just limiting emojis, we can restrict user input to only allow specific character ranges (we may use the same regex from BE side)

[parasharrajat]

We can use ValidationUtils.isValidLegalName for these fields but the overall idea is correct. The address field requires more changes. But the idea is correct.

let's go with @tienifr's proposal.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

@tienifr Please update your proposal to contain more details on how will you update Addressfield etc.

[situchan]

Some related issues which can be combined together:

• [$500] Web - Tricky emoji is displaying as black square and not easy to delete it #31387
• [$500] The tricky emoji in the title and description seems to be inconsistent. #31389
• [$500] The tricky emoji is displayed incorrectly in the expiration date and CVV section #31393

[yakupafsin]

@situchan

• [$500] The tricky emoji is displayed incorrectly in the expiration date and CVV section #31393

This issue is related to numeric inputs accepting various types of characters, such as letters or Unicode.

[tienifr]

@parasharrajat I added the detail implementation in my proposal #31385 (comment).

Here's the result

About the company address street we show the error Please enter a valid street address that is not a PO box (The one we already define).It's quite confusing for users IMO, should we show sth like Please enter a valid legal street address that is not a PO box?

[parasharrajat]

There is nothing illegal about street addresses so that sounds fine to me. We can get this confirmed.

About the company address street we show the error Please enter a valid street address that is not a PO box (The one we already define). It's quite confusing for users IMO, should we show sth like Please enter a valid legal street address that is not a PO box?

cc: @grgia

[aldo-expensify]

Just passing some information in case it is useful:

I noticed that this doesn't happen only with emojis, it also happens if you use Cyrillic letters. The address is "sanitized" by the backend and converted to ascii, but in a poor way, so Гвгв or an emoji is converted to '' and then it causes a crash.

[grgia]

About the company address street we show the error Please enter a valid street address that is not a PO box (The one we already define). It's quite confusing for users IMO, should we show sth like Please enter a valid legal street address that is not a PO box?

@parasharrajat @tienifr Personally, I think we can leave the error messages as is for this

[tienifr]

@grgia Thanks for your comment. Do you agree with my solution?

[melvin-bot]

📣 @parasharrajat Please request via NewDot manual requests for the Reviewer role ($500)

[melvin-bot]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[grgia]

Yep all yours @tienifr ! Thank you

[parasharrajat]

@tienifr Bump.

[tienifr]

I'm working on it, will raise the PR soon

[parasharrajat]

Any news @tienifr

[melvin-bot]

@garrettmknight, @parasharrajat, @grgia, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[parasharrajat]

Bump @tienifr

[tienifr]

I'm working on the draft PR. Will raise in the next hour.

[tienifr]

Fix PR is up: #33865.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.23-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Do not allow emojis in address #33865

If no regressions arise, payment will be issued on 2024-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @tienifr requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[parasharrajat]

For clarity, @tienifr has been paid already for this task.

Previous summary #31385 (comment).

[garrettmknight]

Thanks for the reminder, request payment on the 17th!

[garrettmknight]

Summary of payments is above: #31385 (comment)

@parasharrajat when you're ready, request payment!

[parasharrajat]

@garrettmknight Feel free to close it, I will request it later.

[parasharrajat]

Payment requested as per #31385 (comment)

[JmillsExpensify]

$500 approved for @parasharrajat based on this summary.