[$500] Chat - Whisper for flagged message meant for the offender is visible to person who flags it

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. [User A] Send a message (MODERATION_TEST) to user B.
2. [User B] On Android or iOS app, flag the message as Assault.

Expected Result:

User B will not be able to see the whisper message that is meant for User A.

Actual Result:

User B is able to see the whisper message that is meant for User A.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6279129_1700142457636.Screen_Recording_20231115_090825_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dc7ea43f03435a3c
• Upwork Job ID: 1725150741846491136
• Last Price Increase: 2023-11-16

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dc7ea43f03435a3c

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[erquhart]

I would expect this to be addressed on the backend, whispers for other users shouldn't be in the api responses.

[melvin-bot]

@slafortune, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[NikkiWines]

Yep, if whispers are being sent to the wrong users i'd guess it's definitely a backend issue. cc: @pecanoro in case you want to snag this since you have familiarity with our whisper logic.

[pecanoro]

This is unrelated to the whisper logic, I am 99% sure that whoever wrote the flagging functionality is sending push notifications to all chat participants instead of the person in the whisperedTo (the function to send the notification has an additional parameter to only send the notification to some accountIDs and it's probably missing).

[pecanoro]

Adding to my previous comment, that was my theory because if you log out and log in again the whisper is gone, so basically this is due to some faulty pusher events.

[melvin-bot]

@slafortune, @NikkiWines, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@slafortune, @NikkiWines, @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[NikkiWines]

Been OOO, will look into this when I'm back

[melvin-bot]

@slafortune @NikkiWines @aimane-chnaif this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@slafortune @NikkiWines @aimane-chnaif this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[aimane-chnaif]

Not overdue

[melvin-bot]

@slafortune @NikkiWines @aimane-chnaif this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[NikkiWines]

Dropping this to weekly for now, still on my radar

[melvin-bot]

@slafortune @NikkiWines @aimane-chnaif this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[NikkiWines]

I'm not longer able to reproduce this. @kbecciv can we confirm this is still an issue please?

[NikkiWines]

Confirmed not reproducible on staging v1.4.10-1. Closing

RPReplay_Final1702083164.mov