[$500] Room - Invited user to Room does not receive message notification until open the chat first

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

Action Performed:

1. User A (mobile) create a Room and invite User B
2. User A send message to the Room

Expected Result:

User B should receive notification about the message

Actual Result:

User B does not receive notifications until he navigates to the room

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6279211_1700146756870.Recording__1373.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016ef57f5ce2098531
• Upwork Job ID: 1725174862368362496
• Last Price Increase: 2023-11-30

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016ef57f5ce2098531

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync - N/A

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[s-alves10]

I guess this is related to the notification settings of the room on the receiver side

[tienifr]

This is a BE error, when B invited A, the pusher sent to A with notificationPreference setting as Daily; but when A opened the report, OpenReport returned with always.

[melvin-bot]

@lschurr, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[lschurr]

@thesahindia do we need to ask for help from Eng on this one?

[thesahindia]

@thesahindia do we need to ask for help from Eng on this one?

Yeah! This needs to be internal.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[lschurr]

Hiya @tgolen - sounds like this is a backend issue. Will you have a look at it for us?

[tgolen]

This is a BE error, when B invited A, the pusher sent to A with notificationPreference setting as Daily; but when A opened the report, OpenReport returned with always.

@tienifr I haven't ever worked on this flow, so I could use a little more context. What value are you expecting to have returned?

[melvin-bot]

@tgolen @lschurr @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[tgolen]

@tienifr bump on the above question.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@tgolen @lschurr @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@tgolen @lschurr @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[tienifr]

@tgolen Sorry I completely missed this. I think this is a design question of whether a user should receive notification of the room immediately after he is invited; or after he opens the room. As in the OP, it's the former one, so it should be:

When B invited A, the pusher updates A's notificationPreference as Always.

[melvin-bot]

Current assignee @thesahindia is eligible for the Internal assigner, not assigning anyone new.

[tgolen]

@flodnv I was wondering if you could help me with this one (also tagging @iwiznia @dangrous since you might be familiar. I tried to reproduce this, and I found that the issue doesn't seem to be related to notificationPreference. There are two cases here, and it's not clear to me which case the issue was opened about.

@kbecciv Can you please clarify which scenario this issue is about?

• User A invites User B that does not have an existing account
• User A invites User B that does have an existing account, they just haven't chatted together before

In the first case, there is no message sent because this code is triggered and the account is not found.

In the second case, it appears that there is a push message sent to user B and it contains a notification preference of always, which looks like it should be like we expect.

[iwiznia]

In the first case, there is no message sent because this code is triggered and the account is not found.

Huh? Aren't we sending the push notification after we create the account?

[tgolen]

@kbecciv bump on my clarification above. Could you please help answer that?

@iwiznia I am not sure. I will need to dig into the flow more to understand when exactly the account gets created for that first case.

[kbecciv]

@tgolen It is scenario 2. User A invites User B that does have an existing account, they just haven't chatted together before

[tgolen]

OK, thank you. I'll need to look at that one more closely. When I tried it earlier, everyone received an always push notification.

[melvin-bot]

@tgolen @lschurr @thesahindia this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[lschurr]

Any update on this one @tgolen?

[tgolen]

Yeah, I'll be working on this one today and should know more by EOD.

[tgolen]

I have been unable to reproduce this. Looking at the events from the backend, they are all sent with always set as the notification preference. On the frontend, I'm always receiving the notification.